Fix scalafix violations and compilation warnings #33

Merged

mprihoda merged 3 commits from fix/scalafix-violations into main

2026-04-06 13:18:27 +00:00

mprihoda commented

2026-04-06 11:42:53 +00:00

(Migrated from github.com)

Summary

Fix all DisableSyntax scalafix violations (null, var, throw) across core, direct, and effectful modules
Replace imperative var/null BufferedReader.readLine() loops with functional alternatives (@tailrec recursion, Iterator + Option patterns)
Annotate legitimate throw usages (defects: process crashes, I/O failures, timeouts) with // scalafix:ok
Fix all compilation warnings (unused imports, unused private members, unused parameters, discarded values)

Test plan

./mill __.compile — zero warnings
./mill __.checkFormat — all formatted
./mill __.fix --check — zero scalafix violations
./mill __.test — all 397 tests pass

🤖 Generated with Claude Code

## Summary - Fix all `DisableSyntax` scalafix violations (null, var, throw) across core, direct, and effectful modules - Replace imperative `var`/`null` `BufferedReader.readLine()` loops with functional alternatives (`@tailrec` recursion, `Iterator` + `Option` patterns) - Annotate legitimate `throw` usages (defects: process crashes, I/O failures, timeouts) with `// scalafix:ok` - Fix all compilation warnings (unused imports, unused private members, unused parameters, discarded values) ## Test plan - [x] `./mill __.compile` — zero warnings - [x] `./mill __.checkFormat` — all formatted - [x] `./mill __.fix --check` — zero scalafix violations - [x] `./mill __.test` — all 397 tests pass 🤖 Generated with [Claude Code](https://claude.com/claude-code)