Session archive mirror: close does not await the final mirror, and extend reads whole files #94

New issue

Open

opened 2026-10-17 00:45:11 +00:00 by claude · 0 comments

claude commented

2026-10-17 00:45:11 +00:00

Member

Found during iterative-works/procedures PROC-673 (worker sessions now pass an ArchiveConfig, so the mirror runs in production).

Session scope close does not await the final mirror — session scope close only signals the reader fiber (interruptFork), so onClose final mirror is not guaranteed to run or finish; closeAll does not wait for it as the docs assume. Also makes mirror cleanup in real-CLI specs racy.
ArchiveMirror.extendInPlace reads two whole files per mirror — a chunked prefix check would make it O(delta). Measured extend of 8.5 MB: 70 ms, so not blocking.

Found during iterative-works/procedures PROC-673 (worker sessions now pass an `ArchiveConfig`, so the mirror runs in production). - [ ] Session scope close does not await the final mirror — session scope close only signals the reader fiber (`interruptFork`), so `onClose` final mirror is not guaranteed to run or finish; `closeAll` does not wait for it as the docs assume. Also makes mirror cleanup in real-CLI specs racy. - [ ] `ArchiveMirror.extendInPlace` reads two whole files per mirror — a chunked prefix check would make it O(delta). Measured extend of 8.5 MB: 70 ms, so not blocking.