Fail phase-commit when impl tasks are unchecked #254

Merged
mprihoda merged 1 commit from fix/phase-commit-unchecked-guard into main 2026-03-12 22:13:53 +00:00
mprihoda commented 2026-03-12 22:13:49 +00:00 (Migrated from github.com)

Summary

  • Add PhaseTaskFile.findUncheckedImplTasks to detect - [ ] [impl] lines in phase task files
  • phase-commit now validates before staging — if any [impl] tasks are unchecked, it fails with a descriptive error listing the unchecked tasks
  • Prevents silent completion of phases where the agent forgot to check off tasks

Test plan

  • 7 new unit tests for findUncheckedImplTasks (empty list, with/without reviewed marker, ignores non-impl, multiple unchecked, no task lines, empty content)
  • scala-cli compile --scalac-option -Werror .iw/core/ passes
  • ./iw test unit passes
  • ./iw test compile passes (all 32 commands)

🤖 Generated with Claude Code

## Summary - Add `PhaseTaskFile.findUncheckedImplTasks` to detect `- [ ] [impl]` lines in phase task files - `phase-commit` now validates before staging — if any `[impl]` tasks are unchecked, it fails with a descriptive error listing the unchecked tasks - Prevents silent completion of phases where the agent forgot to check off tasks ## Test plan - [x] 7 new unit tests for `findUncheckedImplTasks` (empty list, with/without reviewed marker, ignores non-impl, multiple unchecked, no task lines, empty content) - [x] `scala-cli compile --scalac-option -Werror .iw/core/` passes - [x] `./iw test unit` passes - [x] `./iw test compile` passes (all 32 commands) 🤖 Generated with [Claude Code](https://claude.com/claude-code)
Sign in to join this conversation.
No description provided.