phase-pr leaves review-state.json uncommitted #292

New issue

Closed

opened 2026-03-20 21:16:25 +00:00 by mprihoda · 1 comment

mprihoda commented

2026-03-20 21:16:25 +00:00

(Migrated from github.com)

Problem

iw phase-pr updates review-state.json (sets status to awaiting_review, adds pr_url, appends view-pr action and Review Needed badge) but does not commit the change. This leaves a dirty working tree after every phase PR creation.

Impact

When wf-implement (or ag-implement) is re-run to continue to the next phase, it hits the dirty working tree check and cannot proceed without manual intervention (commit or stash).

This happens consistently — observed on two consecutive phases of DEVDOCS-110.

Expected Behavior

phase-pr should commit the review-state update as part of its operation (either amending the phase commit or creating a small follow-up commit), so the working tree is clean after PR creation.

Reproduction

Run any implementation workflow through to phase-pr
After phase-pr completes, run git status
Observe review-state.json is modified but uncommitted

Workaround

Manually commit review-state.json after each phase-pr call.

## Problem `iw phase-pr` updates `review-state.json` (sets `status` to `awaiting_review`, adds `pr_url`, appends `view-pr` action and `Review Needed` badge) but does not commit the change. This leaves a dirty working tree after every phase PR creation. ## Impact When `wf-implement` (or `ag-implement`) is re-run to continue to the next phase, it hits the dirty working tree check and cannot proceed without manual intervention (commit or stash). This happens consistently — observed on two consecutive phases of DEVDOCS-110. ## Expected Behavior `phase-pr` should commit the review-state update as part of its operation (either amending the phase commit or creating a small follow-up commit), so the working tree is clean after PR creation. ## Reproduction 1. Run any implementation workflow through to `phase-pr` 2. After `phase-pr` completes, run `git status` 3. Observe `review-state.json` is modified but uncommitted ## Workaround Manually commit `review-state.json` after each `phase-pr` call.

mprihoda commented

2026-03-22 12:12:58 +00:00

(Migrated from github.com)

Merged