feedback command posts to the archived GitHub mirror, so it always fails #426
Labels
No labels
bug
contract
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
iterative-works/iw-cli#426
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
What happens
iw feedback "..."always fails:Why
core/commands/Feedback.scalasubmits toConstants.Feedback.Repository, which is"iterative-works/iw-cli"(core/model/Constants.scala:71), andLiveCommandEnv.createFeedbackIssue(line 381) routes that throughGitHubClient.createIssue. So feedback goes to github.com/iterative-works/iw-cli,which is an archived, read-only mirror.
The project's own tracker is Forgejo, not GitHub. From this repo's
.iw/config.conf:The git remotes agree:
originis the Forgejo repo,githubis the mirror.Effect
The one channel for reporting an iw-cli problem is dead, and the error message
("Repository was archived") does not tell the user what to do instead. The user
has to know to reach for
iw kanon/feedback, which is a different target(kanon workflows and guides, not iw-cli defects).
Suggested fix
Route feedback over Forgejo, the way the kanon plugin's command already does.
LiveCommandEnv.createForgejoIssue(line 464) exists and wrapsForgejoClient.createIssue, so the pieces are in place. Seekanon/iw-plugin/commands/feedback.scala, which callsenv.tracker.createForgejoIssueagainstiterative-works/dev-docsathttps://code.iterative.worksand reads$FORGEJO_API_TOKEN.Changes needed:
Feedback.submitcallscreateForgejoIssuewith the Forgejo base URL and token.Constants.Feedbackgains the base URL alongside the repository slug.$FORGEJO_API_TOKENproduces the same helpful message the kanon commandprints, rather than an API error.
--type bug|featureneeds a home on Forgejo (label, or a line in the body as thekanon command does).
Found while filing kanon feedback from cmi-portaly (CMIPL E2E planning).