phase-commit --items has no way to carry a comma inside one item #471

New issue

Closed

opened 2026-08-27 19:10:29 +00:00 by mph · 1 comment

mph commented

2026-08-27 19:10:29 +00:00

Owner

Found triaging IW-437 (hit while committing phase 2).

WHAT. --items splits on every comma with no escape, so an item whose own text contains a comma becomes two bullets.

./iw phase-commit --items "A, and not B,C,D"

writes three bullets, not two. Phase 2's first item came out as:

- Type the createPullRequest error channel as ForgeCreateError so a duplicate
  is recognised by what the forge said
- not how the adapter phrased it

where one sentence was meant.

WHY IT IS EASY TO MISS. The command reports success and echoes the resulting message, so the damage is visible only if the caller actually reads the message field it printed back. Corrected here with git commit --amend.

PROPOSED FIX - a design choice, not a one-liner:

an escape syntax, or
a repeatable --item flag, or
a different separator.

If the decision is instead to keep the restriction, it must at least be stated in the command's --help; #463 covers giving every command a --help that can guide an agent.

Found triaging IW-437 (hit while committing phase 2). WHAT. --items splits on every comma with no escape, so an item whose own text contains a comma becomes two bullets. ./iw phase-commit --items "A, and not B,C,D" writes three bullets, not two. Phase 2's first item came out as: - Type the createPullRequest error channel as ForgeCreateError so a duplicate is recognised by what the forge said - not how the adapter phrased it where one sentence was meant. WHY IT IS EASY TO MISS. The command reports success and echoes the resulting message, so the damage is visible only if the caller actually reads the message field it printed back. Corrected here with git commit --amend. PROPOSED FIX - a design choice, not a one-liner: - an escape syntax, or - a repeatable --item flag, or - a different separator. If the decision is instead to keep the restriction, it must at least be stated in the command's --help; #463 covers giving every command a --help that can guide an agent.

mph referenced this issue

2026-09-01 12:17:53 +00:00

phase-commit: --items splits commas inside bullet strings, mangling commit body #337

mph commented

2026-09-01 12:17:57 +00:00

Author

Owner

Duplicate of #337, which reports the same fault with a fuller reproduction and fix options. Everything this issue added — the second sighting, the why-it-is-easy-to-miss note, the fix options and the #463 --help point — is copied onto #337. Closing here; track it there.