Phase 1: Fix --checkpoint SHA validation and append semantics (defects 3 + 4) #482

Merged

mph merged 3 commits from IW-436-phase-01 into IW-436 2026-08-30 08:51:49 +00:00

Conversation 0 Commits 3 Files changed 11 +683 -43

mph commented 2026-08-29 16:57:09 +00:00

Owner

Copy link

Phase 01 implementation for IW-436.

Files

Browse changed files: https://code.iterative.works/iterative-works/iw-cli/-/blob/IW-436-phase-01/

Phase 01 implementation for IW-436. ### Files Browse changed files: https://code.iterative.works/iterative-works/iw-cli/-/blob/IW-436-phase-01/

mph added 2 commits 2026-08-29 16:57:09 +00:00

chore(IW-436): update review-state for phase 01 520277a59b

Fix --checkpoint SHA validation and append semantics (defects 3 + 4) ... a16b79fd1e

- CONTRACT CHANGE: --checkpoint now accumulates instead of replacing phase_checkpoints (defect 4) — replace silently destroyed earlier phases across two issues and six phases; --clear-checkpoints remains the only way to drop entries and clear-and-set now needs two invocations
- parseCheckpoint rejects a value that is not 7-64 hex characters (defect 3) — the doubled-key form produced 26 malformed context_sha entries in this repository
- parseArrayMode gained unionOnAppend: Boolean; only the checkpoint call site passes it and the other four array fields keep the exclusive clear > replace > append precedence
- Rewrote the test that pinned the defective Replace default — a deliberate contract change and not a test bent to make the fix pass
- Closed the checkpoint coverage gap with 5 phase_checkpoints merge cases that pass against an unmodified ReviewStateUpdater — which is what localises the defect to mode selection; the two Replace cases pin a branch no production path reaches after this fix and are kept on purpose
- ReviewStateValidator and review-state.schema.json deliberately gain no SHA pattern — the validator runs on the merged whole file and would fail the next update of every still-corrupt card

mph added 1 commit 2026-08-29 17:10:23 +00:00

chore(IW-436): update review-state for phase 01 965fc7fb84

mph merged commit c3e00360b7 into IW-436 2026-08-30 08:51:49 +00:00

mph deleted branch IW-436-phase-01 2026-08-30 08:51:49 +00:00

mph referenced this pull request from a commit 2026-08-30 08:51:50 +00:00

Merge pull request 'Phase 1: Fix --checkpoint SHA validation and append semantics (defects 3 + 4)' (#482) from IW-436-phase-01 into IW-436

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

agent-ready

  

bug

Something isn't working

  

contract

Run the tool-contract suite on this PR

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

needs-human

  

needs-input

Intake asked the human a question on the issue; waiting for the answer

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

agent-ready

bug

contract

documentation

duplicate

enhancement

good first issue

help wanted

invalid

needs-human

needs-input

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

iterative-works/iw-cli!482

No description provided.