GitLabClient.parseMrPipeline has no production caller once the gate reads the pipeline list #557

New issue

mph · 2026-09-14T10:13:08Z

mph commented

2026-09-14 10:13:08 +00:00

Found while working IW-517.

After the GitLab CI gate changed to read every pipeline at a commit, GitLabClient.parseMrPipeline has no production caller. It and its six tests (core/test/GitLabCiTest.scala:114-196) are candidates for deletion.

Removing a working implementation needs Michal's explicit approval, so IW-517 left it in place and documented it as not-the-gate's-source in the meantime.

Decide: delete the method and its tests, or state why it stays.

Found while working IW-517. After the GitLab CI gate changed to read every pipeline at a commit, `GitLabClient.parseMrPipeline` has no production caller. It and its six tests (`core/test/GitLabCiTest.scala:114-196`) are candidates for deletion. Removing a working implementation needs Michal's explicit approval, so IW-517 left it in place and documented it as not-the-gate's-source in the meantime. Decide: delete the method and its tests, or state why it stays.

mph referenced this issue from a commit

2026-09-14 12:45:18 +00:00

workflow: Triage lessons for IW-517

mph referenced this issue

2026-09-14 12:45:41 +00:00

fix(IW-517): the GitLab CI gate reads every pipeline at a commit #559

claude commented

2026-09-14 19:15:10 +00:00

Intake: needs-input

Do you approve deleting GitLabClient.parseMrPipeline and its six tests, or must the method stay? If it stays, what future caller or documentation purpose keeps it — so the analyst can record that instead of a deletion? (An analyst cannot make this choice: removing a working implementation needs your explicit approval, and the issue text says so.)
Pull request #559 (branch IW-517 into main) is open, not merged. On main today parseMrPipeline still has a production caller (fetchCiSnapshot, core/adapters/GitLabClient.scala:860), so the issue's premise holds only on the IW-517 branch. Should this deletion be folded into #559 before it merges, or run as a separate change on main after #559 lands?

Intake: needs-input 1. Do you approve deleting `GitLabClient.parseMrPipeline` and its six tests, or must the method stay? If it stays, what future caller or documentation purpose keeps it — so the analyst can record that instead of a deletion? (An analyst cannot make this choice: removing a working implementation needs your explicit approval, and the issue text says so.) 2. Pull request #559 (branch `IW-517` into `main`) is open, not merged. On `main` today `parseMrPipeline` still has a production caller (`fetchCiSnapshot`, `core/adapters/GitLabClient.scala:860`), so the issue's premise holds only on the `IW-517` branch. Should this deletion be folded into #559 before it merges, or run as a separate change on `main` after #559 lands?

claude added the

needs-input

label

2026-09-14 19:15:10 +00:00

mph commented

2026-10-10 20:16:16 +00:00

1: I approve
2: it is merged now

1: I approve 2: it is merged now

claude removed the

needs-input

label

2026-10-10 23:40:16 +00:00