iterative-works/iw-cli
Watch
3
0
Fork
You've already forked iw-cli
 0
Code Issues 119 Pull requests 1 Projects Releases 34 Packages Wiki Activity Actions

Phase 1: Percent-encode the repository slug as one glab api path segment #561

Merged
claude merged 3 commits from IW-558-phase-01 into IW-558 2026-09-14 22:23:39 +00:00
Conversation 0 Commits 3 Files changed 7 +310 -21
claude commented 2026-09-14 22:07:07 +00:00
Member
Copy link

Phase 01 implementation for IW-558.

Files

Browse changed files: https://code.iterative.works/iterative-works/iw-cli/-/blob/IW-558-phase-01/

Phase 01 implementation for IW-558. ### Files Browse changed files: https://code.iterative.works/iterative-works/iw-cli/-/blob/IW-558-phase-01/
Percent-encode the repository slug as one glab api path segment
All checks were successful
CI / changes (pull_request) Successful in 2s
Details
CI / contract (pull_request) Has been skipped
Details
CI / format (pull_request) Successful in 7s
Details
CI / lint (pull_request) Successful in 8s
Details
CI / compile (pull_request) Successful in 1m17s
Details
CI / test (pull_request) Successful in 14m5s
Details
CI / dashboard-build (pull_request) Successful in 1m6s
Details
508805d1fc 
- encodedRepo now percent-encodes the whole slug, with '+' written as %20, so ? # & % and space can no longer end the path or add a parameter
- One central change fixes all four glab api path builders; no call site was edited
- Two regression tests, both proved RED first, one of them through buildMergeRequestForBranchCommand where the slug precedes a real query string
- Existing assertions pinning group%2Fsub%2Fproject pass unchanged: full encoding is byte-identical for a legal slug
chore(IW-558): update review-state for phase 01
All checks were successful
CI / contract (pull_request) Has been skipped
Details
CI / compile (pull_request) Successful in 1m24s
Details
CI / changes (pull_request) Successful in 2s
Details
CI / format (pull_request) Successful in 8s
Details
CI / lint (pull_request) Successful in 8s
Details
CI / dashboard-build (pull_request) Successful in 1m7s
Details
CI / test (pull_request) Successful in 14m50s
Details
69ca4208e8
claude merged commit e3cc2b9cc6 into IW-558 2026-09-14 22:23:39 +00:00
claude deleted branch IW-558-phase-01 2026-09-14 22:23:39 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent-ready

   
bug
Something isn't working

  
contract
Run the tool-contract suite on this PR

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
needs-human

   
needs-input
Intake asked the human a question on the issue; waiting for the answer

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
agent-ready
bug
contract
documentation
duplicate
enhancement
good first issue
help wanted
invalid
needs-human
needs-input
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
iterative-works/iw-cli!561
No description provided.