The lint gate runs scalafix but not scalafmt, so a format violation reaches the commit hook unflagged #570

New issue

Open

opened 2026-09-16 09:02:12 +00:00 by claude · 1 comment

claude commented

2026-09-16 09:02:12 +00:00

Member

Found while working IW-566.

./iw ./test lint runs scalafix but not scalafmt, so a scalafmt violation passes the lint gate and is caught only later by the pre-commit hook.

OBSERVED. On the IW-566 phase-01 branch, core/test/PhasePrHarnessTest.scala failed scalafmt --test with exit 1 while ./iw ./test lint was green. The violation surfaced at the commit, which is the same "green means pushable is a lie" failure #466 fixed for scalafix — the fix added scalafix to the gate and left scalafmt out.

PROPOSED FIX. Add the scalafmt check to the same lint gate, so the one command a phase session runs before committing covers everything the hooks enforce.

Found while working IW-566. `./iw ./test lint` runs scalafix but not scalafmt, so a scalafmt violation passes the lint gate and is caught only later by the pre-commit hook. OBSERVED. On the IW-566 phase-01 branch, `core/test/PhasePrHarnessTest.scala` failed `scalafmt --test` with exit 1 while `./iw ./test lint` was green. The violation surfaced at the commit, which is the same "green means pushable is a lie" failure #466 fixed for scalafix — the fix added scalafix to the gate and left scalafmt out. PROPOSED FIX. Add the scalafmt check to the same lint gate, so the one command a phase session runs before committing covers everything the hooks enforce.

mph referenced this issue from a commit

2026-09-16 09:03:38 +00:00

workflow(IW-566): review packet, release notes, follow-ups filed

claude referenced this issue

2026-09-16 09:04:01 +00:00

IW-566: phase-pr --no-wait — open the pull request, leave the CI wait to the caller #571

claude commented

2026-10-15 20:54:03 +00:00

Author

Member

Intake: needs-human
Workflow: waterfall
Reason: G4 the analysis proposes a change to CLAUDE.md (the lint line near line 187), a document a human owns
Analysis: project-management/issues/IW-570/analysis.md on branch IW-570

Intake: needs-human Workflow: waterfall Reason: G4 the analysis proposes a change to `CLAUDE.md` (the lint line near line 187), a document a human owns Analysis: project-management/issues/IW-570/analysis.md on branch IW-570

claude added the

needs-human

label

2026-10-15 20:54:03 +00:00