phase-pr pushes a card-only commit after a red verdict, so a false red leaves a green head under a ci_failed card #592

New issue

Closed

opened 2026-09-21 14:50:30 +00:00 by claude · 1 comment

claude commented

2026-09-21 14:50:30 +00:00

Member

Found during IW-491 (phase 2 left it out of scope).

After a red verdict, PhasePr.stop (core/commands/PhasePr.scala:535-558) calls persist, which commits and pushes the card. That push makes a new head, and CI runs again on it. When the red was false (a flaky job), the new head goes green, but the card still says ci_failed. Seen on IW-583, run 890.

IW-491 phase 2 already removed the same push from the green path: after green, phase-pr writes the card to disk and does not commit or push it.

PROPOSED FIX. Do the same on the red and stop path: write the card, do not push it. Check first that batch-implement and phase-merge still read a dirty ci_failed card correctly.

Found during IW-491 (phase 2 left it out of scope). After a red verdict, `PhasePr.stop` (`core/commands/PhasePr.scala:535-558`) calls `persist`, which commits and pushes the card. That push makes a new head, and CI runs again on it. When the red was false (a flaky job), the new head goes green, but the card still says `ci_failed`. Seen on IW-583, run 890. IW-491 phase 2 already removed the same push from the green path: after green, `phase-pr` writes the card to disk and does not commit or push it. PROPOSED FIX. Do the same on the red and stop path: write the card, do not push it. Check first that `batch-implement` and `phase-merge` still read a dirty `ci_failed` card correctly.

claude referenced this issue

2026-09-21 14:52:17 +00:00

IW-491: phase-pr pushes a commit after reading CI, so its green can describe a stale head #596

claude referenced this issue

2026-09-21 19:32:19 +00:00

The phase gate reads and writes cards that do not belong to the head under test #601

claude commented

2026-09-21 19:32:25 +00:00

Author

Member

Closed as a duplicate of #601, which takes this defect and three others as one investigation on one branch. This one is phase 2 there.

The four share a cause: the card and the CI reading do not agree on which head they speak about. Fixing them apart would read the same code four times.

Closed as a duplicate of #601, which takes this defect and three others as one investigation on one branch. This one is phase 2 there. The four share a cause: the card and the CI reading do not agree on which head they speak about. Fixing them apart would read the same code four times.

claude closed this issue

2026-09-21 19:32:25 +00:00