ReviewStateUpdater clears ci_wait_started and ci_wait_sha with two flags that every caller must set together #595

New issue

Closed

opened 2026-09-21 14:50:30 +00:00 by claude · 1 comment

claude commented

2026-09-21 14:50:30 +00:00

Member

Found in the composition review of IW-491 phase 1. Related: #568.

ReviewStateUpdater has clearCiWaitStarted and clearCiWaitSha. The two fields describe one wait and must be cleared together, but eight call sites (in PhasePr, PhaseMerge, PhaseMergedCard, CiGateCommand) set the pair by hand. A new call site that sets only one of them leaves a wait start without its head, or the reverse, and nothing catches it.

PROPOSED FIX. Replace the pair with one flag (for example clearCiWait) that clears both fields.

Found in the composition review of IW-491 phase 1. Related: #568. `ReviewStateUpdater` has `clearCiWaitStarted` and `clearCiWaitSha`. The two fields describe one wait and must be cleared together, but eight call sites (in `PhasePr`, `PhaseMerge`, `PhaseMergedCard`, `CiGateCommand`) set the pair by hand. A new call site that sets only one of them leaves a wait start without its head, or the reverse, and nothing catches it. PROPOSED FIX. Replace the pair with one flag (for example `clearCiWait`) that clears both fields.

claude referenced this issue

2026-09-21 14:52:17 +00:00

IW-491: phase-pr pushes a commit after reading CI, so its green can describe a stale head #596

claude referenced this issue

2026-09-21 19:32:19 +00:00

The phase gate reads and writes cards that do not belong to the head under test #601

claude commented

2026-09-21 19:32:25 +00:00

Author

Member

Closed as a duplicate of #601, which takes this defect and three others as one investigation on one branch. This one is phase 1 there.

The four share a cause: the card and the CI reading do not agree on which head they speak about. Fixing them apart would read the same code four times.

Closed as a duplicate of #601, which takes this defect and three others as one investigation on one branch. This one is phase 1 there. The four share a cause: the card and the CI reading do not agree on which head they speak about. Fixing them apart would read the same code four times.

claude closed this issue

2026-09-21 19:32:25 +00:00