GitAdapter dirtyState, stageAll and commit cannot take destroyOnExit, so a shutdown-safe caller must repeat them #620

New issue

Closed

opened 2026-09-25 07:35:22 +00:00 by claude · 1 comment

claude commented

2026-09-25 07:35:22 +00:00

Member

Follows #616, which gave ProcessAdapter.run a destroyOnExit parameter.

kanon (dev-docs #346) needs git to run during JVM shutdown, so its LiveWorkingTree (iw-plugin/lib/cli/WorkingTree.scala) repeats core GitAdapter.dirtyState, stageAll and commit with the same failure texts. Only destroyOnExit = false differs.

Requested: let GitAdapter.dirtyState, stageAll and commit take destroyOnExit (default true) and pass it to ProcessAdapter.run. Then the plugin can delegate to core instead of repeating these three methods.

Source: dev-docs DEVDOCS-346 code review, composition finding (review-phase-01-20260925-092800.md).

Type: feature
Filed from: /home/mph/ops/kanon-DEVDOCS-346 on branch DEVDOCS-346

Follows #616, which gave `ProcessAdapter.run` a `destroyOnExit` parameter. kanon (dev-docs #346) needs git to run during JVM shutdown, so its `LiveWorkingTree` (`iw-plugin/lib/cli/WorkingTree.scala`) repeats core `GitAdapter.dirtyState`, `stageAll` and `commit` with the same failure texts. Only `destroyOnExit = false` differs. Requested: let `GitAdapter.dirtyState`, `stageAll` and `commit` take `destroyOnExit` (default `true`) and pass it to `ProcessAdapter.run`. Then the plugin can delegate to core instead of repeating these three methods. Source: dev-docs DEVDOCS-346 code review, composition finding (`review-phase-01-20260925-092800.md`). --- **Type:** feature **Filed from:** `/home/mph/ops/kanon-DEVDOCS-346` on branch `DEVDOCS-346`

claude added the

agent-ready

label

2026-09-25 22:01:32 +00:00

claude commented

2026-09-25 22:01:32 +00:00

Author

Member

Intake: agent-ready
Workflow: waterfall
Reason: all gates passed
Analysis: project-management/issues/IW-620/analysis.md on branch IW-620

Intake: agent-ready Workflow: waterfall Reason: all gates passed Analysis: project-management/issues/IW-620/analysis.md on branch IW-620

claude referenced this issue from a pull request that will close it,

2026-09-25 22:53:14 +00:00