Command scripts and PhaseMergeHarnessTest.scala do not have exactly two PURPOSE lines #636
Labels
No labels
agent-ready
bug
contract
documentation
duplicate
enhancement
good first issue
help wanted
invalid
needs-human
needs-input
question
wontfix
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
iterative-works/iw-cli#636
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
commands/*.scala— 27 files, count 1.iw/commands/test.scala— count 1core/test/PhaseMergeHarnessTest.scala— count 3research/approach-3-hybrid/commands/{hello,version}.scalaandresearch/approach-4-combined/commands/{hello,version}.scala— count 1The check that #630 asks for cannot pass until these files are fixed.
Intake: needs-input. The fix for
core/test/PhaseMergeHarnessTest.scalais clear from the code. The other files need these decisions. #630 asks the same questions (its question 2), and they have no answer yet, so one answer can settle both issues.docs/testing.md(lines 167-168) says that the 27commands/*.scalashims are "the one deliberate exception" to the two-line// PURPOSE:header, because a second line "could only restate the declaration". Which do you want?docs/testing.mdto agree..iw/commands/test.scalahas one// PURPOSE:line, then// USAGE:and// ARGS:lines. This is the project-command script format. Which do you want?// USAGE:..iw/commands/?research/holds four prototype directories and COMPARISON.md. No build file and no doc refers to them. Forresearch/approach-3-hybrid/commands/{hello,version}.scalaandresearch/approach-4-combined/commands/{hello,version}.scala, which do you want?research/(all of it, or only these approaches).research/from the #630 check.Intake: needs-input. I took your answers to questions 1 and 2:
commands/*.scalashims gets a second PURPOSE line, anddocs/testing.mdlines 167-168 change to agree..iw/commands/test.scalagets a second PURPOSE line above// USAGE:.Your answer to question 3 was (b), "Delete
research/(all of it, or only these approaches)". That option holds one more choice:How much of
research/do you want to delete?research/: the four approach directories andresearch/COMPARISON.md.research/approach-3-hybrid/andresearch/approach-4-combined/.research/approach-3-hybrid/commands/{hello,version}.scalaandresearch/approach-4-combined/commands/{hello,version}.scala.No build file refers to
research/. Only issue documents refer to it:project-management/issues/IW-463/analysis.md:39andproject-management/issues/IW-463/LESSONS.md:151-156citeresearch/approach-3-hybrid/core/CommandMetadata.scala,research/approach-3-hybrid/commands.index.mdandresearch/COMPARISON.mdas prior art. The other.scalafiles in approaches 1 to 4 already have two PURPOSE lines, so (ii) and (iii) also let the #630 check pass.Answer in a comment on this issue; intake reads it on its next iteration.
Delete all of research/
Intake: needs-human
Workflow: waterfall
Reason: G7 — review found a blocking finding: the proposed second PURPOSE line for
.iw/commands/test.scalasays it "stops any build daemon the run started", butwithoutLeavingADaemonwraps only compile/e2e/contract and stops only bloop daemonsAnalysis: project-management/issues/IW-636/analysis.md on branch IW-636
Intake: agent-ready
Workflow: waterfall
Reason: all gates passed
Analysis: project-management/issues/IW-636/analysis.md on branch IW-636