./mill dashboard.test output is not pristine #681

New issue

Closed

opened 2026-10-02 08:45:21 +00:00 by claude · 4 comments

claude commented

2026-10-02 08:45:21 +00:00

Member

Expected warnings must be captured and asserted, not printed.

Found during IW-652 (per-user dashboard, service links, Claude session links). Follow-ups, verbatim:

./mill dashboard.test output is not pristine: tests that existed before IW-652 print a --dev WARNING and two "Forgejo not yet implemented" lines without capturing them.

Expected warnings must be captured and asserted, not printed. Found during IW-652 (per-user dashboard, service links, Claude session links). Follow-ups, verbatim: - [ ] `./mill dashboard.test` output is not pristine: tests that existed before IW-652 print a `--dev` WARNING and two "Forgejo not yet implemented" lines without capturing them.

mph referenced this issue from a commit

2026-10-02 08:47:47 +00:00

workflow: Triage lessons for IW-652

claude added the

needs-human

label

2026-10-03 00:27:57 +00:00

claude commented

2026-10-03 00:27:58 +00:00

Author

Member

Intake: needs-human
Workflow: diagnostic
Reason: G7 — second review blocking finding: merged Mill worker-prefix lines survive the fix, so the acceptance criterion "stray lines: 0" can fail on a complete fix (analysis.md:88, :338)
Analysis: project-management/issues/IW-681/analysis.md on branch IW-681

Intake: needs-human Workflow: diagnostic Reason: G7 — second review blocking finding: merged Mill worker-prefix lines survive the fix, so the acceptance criterion "stray lines: 0" can fail on a complete fix (analysis.md:88, :338) Analysis: project-management/issues/IW-681/analysis.md on branch IW-681

claude commented

2026-10-06 18:16:57 +00:00

Author

Member

Intake: needs-input
Workflow: diagnostic
Reason: G7 (1 standing correction of the analysis review)
Analysis: project-management/issues/IW-681/analysis.md on branch IW-681

[G7] The analysis says the lines with merged Mill worker prefixes disappear with the fix "together with the Undertow line one of them carries" (analysis.md:88, :338), and its acceptance criterion is "stray lines: 0". A re-run of the reproduction at dde0014a gave merged lines with no Undertow text, for example 241-18] 241-15]Running Test Class iw.tests.PullRequestPollerTest: Mill interleaves the output of parallel workers, whatever the fix does. So the criterion can fail on a complete fix. The second review was final, so intake did not correct this. What should the analysis say? Options: a) the reviewer's text: lines with more than one NNN-NN] prefix are Mill's interleaving of parallel worker output and survive the fix; the reproduction strips repeated prefixes (sed -E 's/^([0-9]+-[0-9]+\] ?)+//') before it filters the munit report lines, and "stray lines: 0" is the criterion only after that b) also make the test run serial, so no prefixes merge, and keep "stray lines: 0" on the raw output c) leave the analysis as it is Recommended: a)

Answer in a comment on this issue; intake reads it on its next iteration.

Intake: needs-input Workflow: diagnostic Reason: G7 (1 standing correction of the analysis review) Analysis: project-management/issues/IW-681/analysis.md on branch IW-681 1. [G7] The analysis says the lines with merged Mill worker prefixes disappear with the fix "together with the Undertow line one of them carries" (analysis.md:88, :338), and its acceptance criterion is "stray lines: 0". A re-run of the reproduction at dde0014a gave merged lines with no Undertow text, for example `241-18] 241-15]Running Test Class iw.tests.PullRequestPollerTest`: Mill interleaves the output of parallel workers, whatever the fix does. So the criterion can fail on a complete fix. The second review was final, so intake did not correct this. What should the analysis say? Options: a) the reviewer's text: lines with more than one `NNN-NN]` prefix are Mill's interleaving of parallel worker output and survive the fix; the reproduction strips repeated prefixes (`sed -E 's/^([0-9]+-[0-9]+\] ?)+//'`) before it filters the munit report lines, and "stray lines: 0" is the criterion only after that b) also make the test run serial, so no prefixes merge, and keep "stray lines: 0" on the raw output c) leave the analysis as it is Recommended: a) Answer in a comment on this issue; intake reads it on its next iteration.

claude added

needs-input

and removed

needs-human

labels

2026-10-06 18:16:57 +00:00