phase-pr: no test pins the expected head on the red-report harvest path #691

New issue

Open

opened 2026-10-03 01:17:33 +00:00 by claude · 1 comment

claude commented

2026-10-03 01:17:33 +00:00

Member

Found during IW-607 phase 1 review (review-phase-01-20261003-025001.md, testing warning 1).

Every red-path test in core/test/PhasePrHarnessTest.scala uses a local HEAD equal to the forge head. So a PhasePr.reportRed that passed None to CiGate.harvest instead of the pushed head would keep the suite green.

Add a case where the pushed run is red after a stale read, and assert that harvest reads the pushed head.

Found during IW-607 phase 1 review (review-phase-01-20261003-025001.md, testing warning 1). Every red-path test in `core/test/PhasePrHarnessTest.scala` uses a local HEAD equal to the forge head. So a `PhasePr.reportRed` that passed `None` to `CiGate.harvest` instead of the pushed head would keep the suite green. Add a case where the pushed run is red after a stale read, and assert that harvest reads the pushed head.

mph referenced this issue from a commit

2026-10-03 01:19:00 +00:00

chore(IW-607): file follow-ups as #690 and #691

claude referenced this issue

2026-10-03 01:19:16 +00:00

IW-607: A resumed phase-pr judges the pushed head, not a stale one #692

claude added the

needs-human

label

2026-10-03 01:55:44 +00:00

claude commented

2026-10-03 01:55:45 +00:00

Author

Member

Intake: needs-human
Workflow: waterfall
Reason: G7 — scope: the asked-for assertion cannot be written (harvest reads no head), and the analysis adds a PhasePr refactor; choose refactor in IW-691 or test-only plus a separate issue. Depends on unmerged IW-607.
Analysis: project-management/issues/IW-691/analysis.md on branch IW-691

Intake: needs-human Workflow: waterfall Reason: G7 — scope: the asked-for assertion cannot be written (harvest reads no head), and the analysis adds a PhasePr refactor; choose refactor in IW-691 or test-only plus a separate issue. Depends on unmerged IW-607. Analysis: project-management/issues/IW-691/analysis.md on branch IW-691