review-state card location: route on the key kind, report pointer read errors, keep the routing pure #712

New issue

Closed

opened 2026-10-04 18:05:04 +00:00 by claude · 1 comment

claude commented

2026-10-04 18:05:04 +00:00

Member

Follow-ups from IW-710 phase 1 code review. All four touch the review-state card location code in core/commands.

write/update --issue-id <slug> route on isFramedEffort(cwd), not on the key kind — core/commands/ReviewStatePath.scala, defaultLocations, line 95 on main. (path routes on the parsed WorktreeKey case; write/update do not.)
An unreadable .active-slice pointer is reported as "missing or empty", dropping the read error — core/commands/ReviewStatePath.scala activeSlicePointerContent, case Left(_) => noActiveSlice (review-phase-01, error-handling W1)
The (key kind, slice) routing in ReviewStatePath.locate is a pure decision living in the shell; it could move to ReviewStateLocation with the shell passing root and pointer content — core/commands/ReviewStatePath.scala locate (review-phase-01, architecture W1)
ReviewState.scala holds four subcommands in ~900 lines; path is read-only and could live in its own object — core/commands/ReviewState.scala (review-phase-01, composition W1)

Follow-ups from IW-710 phase 1 code review. All four touch the review-state card location code in `core/commands`. - [ ] `write`/`update --issue-id <slug>` route on `isFramedEffort(cwd)`, not on the key kind — `core/commands/ReviewStatePath.scala`, `defaultLocations`, line 95 on `main`. (`path` routes on the parsed `WorktreeKey` case; `write`/`update` do not.) - [ ] An unreadable `.active-slice` pointer is reported as "missing or empty", dropping the read error — `core/commands/ReviewStatePath.scala` `activeSlicePointerContent`, `case Left(_) => noActiveSlice` (review-phase-01, error-handling W1) - [ ] The (key kind, slice) routing in `ReviewStatePath.locate` is a pure decision living in the shell; it could move to `ReviewStateLocation` with the shell passing root and pointer content — `core/commands/ReviewStatePath.scala` `locate` (review-phase-01, architecture W1) - [ ] `ReviewState.scala` holds four subcommands in ~900 lines; `path` is read-only and could live in its own object — `core/commands/ReviewState.scala` (review-phase-01, composition W1)