fetchIssueComments re-derives the issue number with split("-").last in GitHubClient and GitLabClient #749

New issue

claude · 2026-10-07T23:45:53Z

claude commented

2026-10-07 23:45:53 +00:00

fetchIssueComments in GitHubClient and GitLabClient re-derive the issue number with issueIdValue.split("-").last; make the GitHub one take issueNumber: String and the GitLab one take IssueId (use IssueId.numericPart), as their fetchIssue siblings do, and follow in CommandEnv/LiveCommandEnv/FakeCommandEnv — review-phase-02-20261008-011802.md (IW-672); fetchGitHubIssueComments(issueId: String, …) now receives a bare number

Found during IW-672 (IssueId.numericPart).

- [ ] `fetchIssueComments` in `GitHubClient` and `GitLabClient` re-derive the issue number with `issueIdValue.split("-").last`; make the GitHub one take `issueNumber: String` and the GitLab one take `IssueId` (use `IssueId.numericPart`), as their `fetchIssue` siblings do, and follow in `CommandEnv`/`LiveCommandEnv`/`FakeCommandEnv` — review-phase-02-20261008-011802.md (IW-672); `fetchGitHubIssueComments(issueId: String, …)` now receives a bare number Found during IW-672 (IssueId.numericPart).

mph referenced this issue from a commit

2026-10-07 23:49:26 +00:00

chore(IW-672): file follow-up as #749

claude commented

2026-10-08 00:27:18 +00:00

Intake: needs-human
Workflow: waterfall
Reason: G8 waits for PR #735 (IW-672), which adds IssueId.numericPart and the new fetchIssue signatures and is not merged
Analysis: project-management/issues/IW-749/analysis.md on branch IW-749

Intake: needs-human Workflow: waterfall Reason: G8 waits for PR #735 (IW-672), which adds IssueId.numericPart and the new fetchIssue signatures and is not merged Analysis: project-management/issues/IW-749/analysis.md on branch IW-749

claude added the

needs-human

label

2026-10-08 00:27:19 +00:00

Sign in to join this conversation.