The CI gate and the dashboard do not use the transient/permanent split of a failed forge read #781
Labels
No labels
agent-ready
bug
contract
documentation
duplicate
enhancement
good first issue
help wanted
invalid
needs-human
needs-input
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
iterative-works/iw-cli#781
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Found during IW-513, which gave the forge clients a
TrackerErrorthat tellsUnreachable(transient) fromRefused(permanent). Two readers still treat every failure the same way. Items:Refusedread instead of treating every read failure as "forge silent". — IW-513 FOLLOW-UPS.mdUnreachableinstead of dropping it, now that the client says the failure is transient. — IW-513 FOLLOW-UPS.mdIntake: needs-input
1. The dashboard already keeps a cached pull request when a forge read fails. What should the dashboard item change?
The item says the dashboard drops a cached pull request when a read fails. It does not. The card and the cache both fall back to the stale entry on every failure (WorktreeCardService.scala, PullRequestCacheService.scala). The dashboard readers also reduce the error to a plain message, so the kind of failure is lost.
Refused. The dashboard does not change.Refusedin the dashboard. Keep the cache onUnreachable. OnRefused, drop the entry or mark the card. This changes what users see when authentication fails or a repository is missing.Recommended: a) — the behaviour the item asks for exists already, and b) or c) is new work that nobody has asked for.
Answer in a comment on this issue, per number, for example "1: a", or in your own words; intake reads it on its next iteration.