IW-548: a non-repeatable valued flag given twice takes the last value everywhere #786

Merged

mph merged 13 commits from IW-548 into main 2026-10-11 07:08:12 +00:00

Conversation 0 Commits 13 Files changed 19 +1403 -16

claude commented 2026-10-11 03:16:57 +00:00

Member

Copy link

Summary

A valued flag that is not declared repeatable and is given twice now resolves by one rule everywhere: the last value wins (decision on the issue: "1: a, 2: yes, same rules").

Defects fixed

• Phase 1 (#784): CommandArgParser already kept the last value, but no test pinned it and no document stated it. Tests in CommandArgParserTest now pin last-wins for Flag.Required, Flag.Valued and Flag.Resolved; the parse doc comment and docs/api/CommandArgParser.md state the rule.
• Phase 2 (#785): review-state write and review-state update read scalar flags with ReviewStateCliParser.extractFlag, which took the first occurrence, while the gate validated the last. So --version abc --version 3 wrote version 2, and --issue-id IW-1 --issue-id IW-2 updated the IW-1 card. extractFlag now takes the last occurrence; docs/api/ReviewStateCliParser.md is updated.

Repeatable flags and presence switches are unchanged.

Testing

• Unit: CommandArgParserTest, ReviewStateCliParserTest, ReviewStateHarnessTest.
• E2E: test/review-state.bats (a flag given twice on update stores the last value).
• Pre-push hook: core compile, scalafix, unit tests, command compilation all pass.

Follow-up

The stale resolveIssueId example in docs/api/ReviewStateCliParser.md is filed on #440.

Release notes

See project-management/issues/IW-548/release-notes.md.

🤖 Generated with Claude Code

Closes #548

## Summary A valued flag that is not declared repeatable and is given twice now resolves by one rule everywhere: the **last value wins** (decision on the issue: "1: a, 2: yes, same rules"). ## Defects fixed - **Phase 1 (#784):** `CommandArgParser` already kept the last value, but no test pinned it and no document stated it. Tests in `CommandArgParserTest` now pin last-wins for `Flag.Required`, `Flag.Valued` and `Flag.Resolved`; the `parse` doc comment and `docs/api/CommandArgParser.md` state the rule. - **Phase 2 (#785):** `review-state write` and `review-state update` read scalar flags with `ReviewStateCliParser.extractFlag`, which took the first occurrence, while the gate validated the last. So `--version abc --version 3` wrote version 2, and `--issue-id IW-1 --issue-id IW-2` updated the IW-1 card. `extractFlag` now takes the last occurrence; `docs/api/ReviewStateCliParser.md` is updated. Repeatable flags and presence switches are unchanged. ## Testing - Unit: `CommandArgParserTest`, `ReviewStateCliParserTest`, `ReviewStateHarnessTest`. - E2E: `test/review-state.bats` (a flag given twice on `update` stores the last value). - Pre-push hook: core compile, scalafix, unit tests, command compilation all pass. ## Follow-up The stale `resolveIssueId` example in `docs/api/ReviewStateCliParser.md` is filed on #440. ## Release notes See `project-management/issues/IW-548/release-notes.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Closes #548

claude added 13 commits 2026-10-11 03:16:57 +00:00

workflow(dx): Create diagnostic analysis for IW-548 ... b29f95de0a

CommandArgParser: no test for a non-repeated flag given twice, and last-wins reverses the previous first-wins

Artifacts:
- analysis.md
- issue.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018fPBZaKwU97SaaHzVo3ePq

workflow(dx): Create task index for IW-548 ... ba811f8766

CommandArgParser: no test for a non-repeated flag given twice, and last-wins reverses the previous first-wins

Artifacts:
- tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018fPBZaKwU97SaaHzVo3ePq

docs(IW-548): intake verdict — agent-ready ... 4ad3471e5d

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018fPBZaKwU97SaaHzVo3ePq

Phase 1: context ready ... 70a56b65ac

Issue: IW-548
Phase: 1 - The last-wins rule for a non-repeatable valued flag is not pinned by a test or stated in a document

This commit marks the checkpoint for phase 1 context generation.
Use dx-fix IW-548 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

workflow(dx): Generate Phase 1 tasks for IW-548 ... 62fd6bfe9f

The last-wins rule for a non-repeatable valued flag is not pinned by a test or stated in a document

Artifacts:
- phase-01-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Phase 1: The last-wins rule for a non-repeatable valued flag is not pinned by a test or stated in a document (#784) e2f5621eb9

chore(IW-548): mark phase 01 complete in tasks.md bdab4ce928

Phase 2: context ready ... ec9356944a

Issue: IW-548
Phase: 2 - review-state write/update take the first occurrence of a scalar flag

This commit marks the checkpoint for phase 2 context generation.
Use dx-fix IW-548 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

workflow(dx): Generate Phase 2 tasks for IW-548 ... b04d2ac57a

review-state write/update take the first occurrence of a scalar flag

Artifacts:
- phase-02-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Phase 2: review-state write and update take the first occurrence of a scalar flag, and the gate validates the last one (#785) 5ef8a5ec3d

chore(IW-548): mark phase 02 complete in tasks.md 073afc59f2

chore(IW-548): file follow-up on #440 ... d280272287

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(IW-548): add release notes ... bb4ef1c82d

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

mph merged commit 6240265cc0 into main 2026-10-11 07:08:12 +00:00

mph referenced this pull request from a commit 2026-10-11 07:08:14 +00:00

Merge pull request 'IW-548: a non-repeatable valued flag given twice takes the last value everywhere' (#786) from IW-548 into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

agent-ready

  

bug

Something isn't working

  

contract

Run the tool-contract suite on this PR

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

needs-human

  

needs-input

Intake asked the human a question on the issue; waiting for the answer

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

agent-ready

bug

contract

documentation

duplicate

enhancement

good first issue

help wanted

invalid

needs-human

needs-input

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

iterative-works/iw-cli!786

No description provided.