GitLabClient pipeline reading: test gaps in parseMrPipelines and a wrong sentence in its API doc #790

New issue

claude · 2026-10-11T05:02:39Z

claude commented

2026-10-11 05:02:39 +00:00

Found in IW-557 (deletion of parseMrPipeline).

GitLabClient.parseMrPipelines has no direct test that non-JSON input gives Left, and none that a pipeline's sha is reported as GitLab sends it; the deleted parseMrPipeline tests checked both (IW-557).
docs/api/GitLabClient.md buildMergeRequestCommand says head_pipeline means "no 'which of these pipelines is current' guess is needed", but the gate reads the pipeline list because head_pipeline names at most one pipeline (core/adapters/GitLabClient.scala:804) — reword the sentence (IW-557 review).

Found in IW-557 (deletion of parseMrPipeline). - [ ] `GitLabClient.parseMrPipelines` has no direct test that non-JSON input gives `Left`, and none that a pipeline's `sha` is reported as GitLab sends it; the deleted `parseMrPipeline` tests checked both (IW-557). - [ ] `docs/api/GitLabClient.md` `buildMergeRequestCommand` says `head_pipeline` means "no 'which of these pipelines is current' guess is needed", but the gate reads the pipeline list because `head_pipeline` names at most one pipeline (`core/adapters/GitLabClient.scala:804`) — reword the sentence (IW-557 review).

mph referenced this issue from a commit

2026-10-11 05:03:49 +00:00

chore(IW-557): file follow-ups as #790

claude referenced this issue

2026-10-11 05:05:21 +00:00

IW-557: Delete GitLabClient.parseMrPipeline, its tests and its API doc #791

claude commented

2026-10-11 05:17:40 +00:00

Intake: needs-input
Workflow: waterfall
Reason: G7 (1 [human] finding)
Analysis: project-management/issues/IW-790/analysis.md on branch IW-790

1. Should IW-790 add two new API doc sections, or record them as a follow-up? (G7)

The issue asks to reword one sentence in the GitLab client API doc. The analysis also adds two new sections, about 20 lines each, for buildMergeRequestPipelinesCommand and parseMrPipelines. The issue does not name these two functions (analysis lines 41-42, reason at line 53). The fixes to the fetchCiSnapshot and fetchPrHeadSha paragraphs stay in IW-790 with either option, because those paragraphs repeat the same false sentence.

a) Keep both sections in IW-790. The doc then describes how GitLab CI is read. IW-557 deletes the old parseMrPipeline section, so without these sections the doc says nothing about this. Cost: about 40 more doc lines that go past the issue's scope.
b) Move both sections to FOLLOW-UPS.md. IW-790 does only the three paragraph fixes. Until a follow-up adds the sections, the fixed paragraphs name functions that have no section in the doc.

Recommended: b): This follows your rule to record a gap outside the issue as one line in FOLLOW-UPS.md. Also, the build-iw-cli-skills skill rebuilds all of docs/api/ from the source, so the next rebuild fills the gap.

Answer in a comment on this issue, per number, for example "1: a", or in your own words; intake reads it on its next iteration.

Intake: needs-input Workflow: waterfall Reason: G7 (1 [human] finding) Analysis: project-management/issues/IW-790/analysis.md on branch IW-790 ### 1. Should IW-790 add two new API doc sections, or record them as a follow-up? (G7) The issue asks to reword one sentence in the GitLab client API doc. The analysis also adds two new sections, about 20 lines each, for `buildMergeRequestPipelinesCommand` and `parseMrPipelines`. The issue does not name these two functions ([analysis lines 41-42](https://code.iterative.works/iterative-works/iw-cli/src/branch/IW-790/project-management/issues/IW-790/analysis.md#L41-L42), [reason at line 53](https://code.iterative.works/iterative-works/iw-cli/src/branch/IW-790/project-management/issues/IW-790/analysis.md#L53)). The fixes to the `fetchCiSnapshot` and `fetchPrHeadSha` paragraphs stay in IW-790 with either option, because those paragraphs repeat the same false sentence. - **a) Keep both sections in IW-790.** The doc then describes how GitLab CI is read. IW-557 deletes the old `parseMrPipeline` section, so without these sections the doc says nothing about this. Cost: about 40 more doc lines that go past the issue's scope. - **b) Move both sections to FOLLOW-UPS.md.** IW-790 does only the three paragraph fixes. Until a follow-up adds the sections, the fixed paragraphs name functions that have no section in the doc. **Recommended: b)**: This follows your rule to record a gap outside the issue as one line in FOLLOW-UPS.md. Also, the `build-iw-cli-skills` skill rebuilds all of `docs/api/` from the source, so the next rebuild fills the gap. Answer in a comment on this issue, per number, for example "1: a", or in your own words; intake reads it on its next iteration.

claude added the

needs-input

label

2026-10-11 05:17:40 +00:00

Sign in to join this conversation.