contract job red on the forge: glab missing from CI image + mill show dashboard.assembly shape mismatch #407

New issue

Closed

opened 2026-07-13 12:00:50 +00:00 by mph · 1 comment

mph commented

2026-07-13 12:00:50 +00:00

Owner

Summary

The nightly contract job (tool contract suite, test/contract/*.bats) is failing on the Forgejo runner — run #31 (schedule, 2026-07-13 03:17 UTC): 6 failing tests from two independent root causes, both environmental (the CI image), not the code under test. gh, git, scala-cli (4/4) pass; tmux is skipped by design.

Root cause 1 — `glab` not installed in the CI image (5 failures)

not ok 1 glab: binary on PATH
  glab --version exited with code 127 → 'Command not found'
not ok 2 glab --version exits 0
not ok 3 glab issue view --help advertises --output and --repo flags
not ok 4 glab issue list --help advertises --output flag
not ok 5 glab issue create --help advertises --repo, --title, --description, --label

glab (the GitLab CLI) isn't present in ghcr.io/iterative-works/iw-cli-ci:latest. The binary on PATH guard fails and the other four cascade from the same missing binary (test/contract/glab_adapter_contract.bats).

Fix: add glab to the iw-cli-ci image build, or gate the glab contract behind an env flag (as tmux already is with IW_CONTRACT_TMUX) if glab coverage on the forge runner isn't wanted yet.

Root cause 2 — `mill show dashboard.assembly` output isn't the expected JSON (1 failure)

not ok 4 mill show dashboard.assembly returns a ref-prefixed jar path that exists
  (test/contract/mill_contract.bats, line 34)
  `decoded="$(jq -r '.' <<<"$output")"` failed with status 5
  jq: parse error: Invalid numeric literal at line 1, column 2

mill show dashboard.assembly emitted output that jq can't parse as the expected JSON string (parse error at the first token). This is the contract suite doing its job — flagging that mill's output shape in this environment no longer matches the adapter's assumption (likely a mill-version/output difference in the container, or show printing something non-JSON alongside the value).

Fix: capture what mill show dashboard.assembly actually prints in the CI image, then either pin/adjust the mill version in iw-cli-ci or update mill_contract.bats (and the adapter, if the real parsing depends on the same shape) to the current output.

Notes

Nightly + contract-label gated, so it does not block ordinary CI (compile/test/lint/format/dashboard-build are green on the forge).
Surfaced during the forge Maven-registry cutover; unrelated to that work — iw-cli's only works.iterative dep (scalatags-webawesome:3.2.1.1) resolves from Maven Central.

## Summary The nightly `contract` job (tool contract suite, `test/contract/*.bats`) is failing on the Forgejo runner — run [#31](https://code.iterative.works/iterative-works/iw-cli/actions/runs/31) (`schedule`, 2026-07-13 03:17 UTC): **6 failing tests from two independent root causes**, both environmental (the CI image), not the code under test. `gh`, `git`, `scala-cli` (4/4) pass; `tmux` is skipped by design. ## Root cause 1 — `glab` not installed in the CI image (5 failures) ``` not ok 1 glab: binary on PATH glab --version exited with code 127 → 'Command not found' not ok 2 glab --version exits 0 not ok 3 glab issue view --help advertises --output and --repo flags not ok 4 glab issue list --help advertises --output flag not ok 5 glab issue create --help advertises --repo, --title, --description, --label ``` `glab` (the GitLab CLI) isn't present in `ghcr.io/iterative-works/iw-cli-ci:latest`. The `binary on PATH` guard fails and the other four cascade from the same missing binary (`test/contract/glab_adapter_contract.bats`). **Fix:** add `glab` to the `iw-cli-ci` image build, or gate the glab contract behind an env flag (as `tmux` already is with `IW_CONTRACT_TMUX`) if glab coverage on the forge runner isn't wanted yet. ## Root cause 2 — `mill show dashboard.assembly` output isn't the expected JSON (1 failure) ``` not ok 4 mill show dashboard.assembly returns a ref-prefixed jar path that exists (test/contract/mill_contract.bats, line 34) `decoded="$(jq -r '.' <<<"$output")"` failed with status 5 jq: parse error: Invalid numeric literal at line 1, column 2 ``` `mill show dashboard.assembly` emitted output that `jq` can't parse as the expected JSON string (parse error at the first token). This is the contract suite doing its job — flagging that mill's output shape in this environment no longer matches the adapter's assumption (likely a mill-version/output difference in the container, or `show` printing something non-JSON alongside the value). **Fix:** capture what `mill show dashboard.assembly` actually prints in the CI image, then either pin/adjust the mill version in `iw-cli-ci` or update `mill_contract.bats` (and the adapter, if the real parsing depends on the same shape) to the current output. ## Notes - Nightly + `contract`-label gated, so it does not block ordinary CI (compile/test/lint/format/dashboard-build are green on the forge). - Surfaced during the forge Maven-registry cutover; unrelated to that work — iw-cli's only `works.iterative` dep (`scalatags-webawesome:3.2.1.1`) resolves from Maven Central.

mph referenced this issue

2026-08-21 17:27:45 +00:00

phase-merge: false CI timeout on a green PR — ci_deadline is inherited from an earlier gate, ci_gated_sha goes stale #433

claude referenced this issue

2026-10-16 03:52:16 +00:00

Pin the development and CI toolchain with a Nix flake #428

claude commented

2026-10-16 04:11:26 +00:00

Member

Intake: fixed by 94f2683a and cee05bd9

Both root causes are fixed on main:

Root cause 1 (glab missing): 94f2683a ("fix(ci): install glab in the CI image so the glab contract tests can run") adds glab to .github/Dockerfile.ci (lines 26-28) and to the final version check.
Root cause 2 (mill show dashboard.assembly not JSON): cee05bd9 ("fix(contract): pin mill show stdout, not stdout merged with stderr") makes test/contract/mill_contract.bats use run --separate-stderr. On a cold build, yarn and vite log to stderr, and jq got that log in place of the jar ref.

Intake did not see a green nightly contract run after these commits. When the job is still red, reopen this issue.

Intake: fixed by 94f2683a and cee05bd9 Both root causes are fixed on `main`: - Root cause 1 (glab missing): 94f2683a ("fix(ci): install glab in the CI image so the glab contract tests can run") adds `glab` to `.github/Dockerfile.ci` (lines 26-28) and to the final version check. - Root cause 2 (`mill show dashboard.assembly` not JSON): cee05bd9 ("fix(contract): pin mill show stdout, not stdout merged with stderr") makes `test/contract/mill_contract.bats` use `run --separate-stderr`. On a cold build, yarn and vite log to stderr, and `jq` got that log in place of the jar ref. Intake did not see a green nightly `contract` run after these commits. When the job is still red, reopen this issue.

claude closed this issue

2026-10-16 04:11:26 +00:00