iterative-works/iw-cli

Watch

Fork 0

Move the GitHubHookDoctor binder out of core/model/ #430

New issue

Open

opened 2026-08-21 13:44:23 +00:00 by mph · 3 comments

mph commented

2026-08-21 13:44:23 +00:00

Owner

Problem

core/CLAUDE.md:24 states that model/ takes no imports from adapters/,
output/ or dashboard/. One file still breaks it:

core/model/GitHubHookDoctor.scala:5
import iw.core.adapters.{GitHubClient, CommandRunner}

The cause is the same one fixed in TerminalWorkspaceChecks (commit 45c3b02):
a pure decision and its impure binder live in the same file, so the binder's
dependency on adapters/ is charged to model/.

Fix

Split the same way. Keep the pure verdict in core/model/, taking its process
probe and client as injected parameters. Move the binder to
commands/github.hook-doctor.scala, which is where the checks are already
assembled and which may import adapters/.

commands/github.hook-doctor.scala currently reads:

val ghCliCheck: Check = Check("gh CLI", CoreGitHubHookDoctor.checkGhInstalled)
val ghAuthCheck: Check =
  Check("gh auth", CoreGitHubHookDoctor.checkGhAuthenticated)

Both would bind explicitly, as start.hook-doctor.scala now does.

Acceptance

rg 'import iw\.core\.(adapters|output|commands)' core/model/ returns nothing.

Origin

Found while triaging LESSONS.md for IW-422. Review finding W11 flagged the same
violation in TerminalWorkspaceChecks and accepted it because this file had set
the precedent. That file is now fixed, so this is the last instance and the rule
can be enforced again.

## Problem `core/CLAUDE.md:24` states that `model/` takes **no imports from `adapters/`, `output/` or `dashboard/`**. One file still breaks it: core/model/GitHubHookDoctor.scala:5 import iw.core.adapters.{GitHubClient, CommandRunner} The cause is the same one fixed in `TerminalWorkspaceChecks` (commit 45c3b02): a pure decision and its impure binder live in the same file, so the binder's dependency on `adapters/` is charged to `model/`. ## Fix Split the same way. Keep the pure verdict in `core/model/`, taking its process probe and client as injected parameters. Move the binder to `commands/github.hook-doctor.scala`, which is where the checks are already assembled and which may import `adapters/`. `commands/github.hook-doctor.scala` currently reads: ```scala val ghCliCheck: Check = Check("gh CLI", CoreGitHubHookDoctor.checkGhInstalled) val ghAuthCheck: Check = Check("gh auth", CoreGitHubHookDoctor.checkGhAuthenticated) ``` Both would bind explicitly, as `start.hook-doctor.scala` now does. ## Acceptance `rg 'import iw\.core\.(adapters|output|commands)' core/model/` returns nothing. ## Origin Found while triaging LESSONS.md for IW-422. Review finding W11 flagged the same violation in `TerminalWorkspaceChecks` and accepted it because this file had set the precedent. That file is now fixed, so this is the last instance and the rule can be enforced again.

mph referenced this issue from a commit

2026-08-21 20:59:52 +00:00

workflow: triage lessons for IW-422 (entries 5-6)

claude commented

2026-10-16 03:32:30 +00:00

Member

Intake: agent-ready
Workflow: waterfall
Reason: all gates passed
Analysis: project-management/issues/IW-430/analysis.md on branch IW-430

Intake: agent-ready Workflow: waterfall Reason: all gates passed Analysis: project-management/issues/IW-430/analysis.md on branch IW-430

claude added the

agent-ready

label

2026-10-16 03:32:31 +00:00

claude commented

2026-10-16 04:25:19 +00:00

Member

Implement: needs-human
Reason: batch-implement exit 1 — the kanon plugin does not compile against the iw-cli core of current main. fetchPullRequestForBranch now returns Either[TrackerError, …] (#778), and ForgeCatchUp.scala in the kanon plugin still expects Either[String, …]. No phase ran, and no batch-implement.log was written. The cause is in the plugin, not in this issue: update the kanon plugin to the current core, then release this issue to agent-ready again.

[error] /home/mph/.local/share/iw/plugins/kanon/lib/batch/ForgeCatchUp.scala:143:7
[error] Found:    Either[iw.core.model.TrackerError, Option[batch.ForgeState]]
[error] Required: Either[String, Option[batch.ForgeState]]
Compilation failed

Implement: needs-human Reason: batch-implement exit 1 — the kanon plugin does not compile against the iw-cli core of current main. `fetchPullRequestForBranch` now returns `Either[TrackerError, …]` (#778), and `ForgeCatchUp.scala` in the kanon plugin still expects `Either[String, …]`. No phase ran, and no batch-implement.log was written. The cause is in the plugin, not in this issue: update the kanon plugin to the current core, then release this issue to `agent-ready` again. ``` [error] /home/mph/.local/share/iw/plugins/kanon/lib/batch/ForgeCatchUp.scala:143:7 [error] Found: Either[iw.core.model.TrackerError, Option[batch.ForgeState]] [error] Required: Either[String, Option[batch.ForgeState]] Compilation failed ```

claude added

needs-human

and removed

agent-ready

labels

2026-10-16 04:25:19 +00:00

claude commented

2026-10-16 17:10:32 +00:00

Member

Release: the implement loop failed this issue for a reason outside it. The kanon plugin did not compile against iw-cli main, because the tracker port now returns TrackerError (iw-cli #778). The plugin fix is dev-docs #484, and iw-cli 0.22.1 carries the core change. The issue goes back to the implement loop.

claude added

agent-ready

and removed

needs-human

labels

2026-10-16 17:10:33 +00:00