Phase 2: review-state update refreshes git_sha (defect 5) #484
No reviewers
Labels
No labels
agent-ready
bug
contract
documentation
duplicate
enhancement
good first issue
help wanted
invalid
needs-human
needs-input
question
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
iterative-works/iw-cli!484
Loading…
Reference in a new issue
No description provided.
Delete branch "IW-436-phase-02"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Phase 02 implementation for IW-436.
Files
Browse changed files: https://code.iterative.works/iterative-works/iw-cli/-/blob/IW-436-phase-02/
review-state updaterefreshes git_sha (defect 5)- applyUpdate fills git_sha from HEAD via a shared currentGitSha helper; an explicit --git-sha still wins, and a git failure preserves the card's existing value - 6 harness cases and 1 BATS case covering refresh, override, --commit ordering and the preserve-on-failure branch - FakeGit gained a getHeadSha failure hook, closing a fixture gap that left a non-repository unsimulatable at every tier - docs/commands/review-state.md now states the real git_sha contract on update - LESSONS entries 5-7 record three findings left deliberately unfixed under RESOLVED 3 Phase 2 of IW-436. The pure core is untouched: core/model/, the ReviewStateOps port, ReviewStateAdapter, FakeReviewStateOps and the schema all show zero diff. 🤖 Generated with Claude Code