iterative-works/iw-cli

Watch

Fork 0

Remove dead FeedbackParser.getLabelIdForIssueType and its Linear label constants #455

New issue

Open

opened 2026-08-26 12:44:55 +00:00 by mph · 4 comments

mph commented

2026-08-26 12:44:55 +00:00

Owner

FeedbackParser.getLabelIdForIssueType (core/model/FeedbackParser.scala:60-63) returns Linear
label UUIDs (Constants.IwCliLabels.Bug / Feature). Its only callers are two tests,
FeedbackParserTest.scala:162-170. It has been dead in production since the feedback command left
Linear, and the Forgejo routing added by IW-426 has no label parameter at all —
ForgejoClient.buildCreateIssueBody (core/adapters/ForgejoClient.scala:78-80) is
ujson.Obj("title" -> …, "body" -> …).

A function whose only callers are its own tests is dead code; test-only usage does not make it live.

Remove the helper, its two tests, and the Constants.IwCliLabels entries it is the last reader of.

Found during IW-426.

`FeedbackParser.getLabelIdForIssueType` (`core/model/FeedbackParser.scala:60-63`) returns Linear label UUIDs (`Constants.IwCliLabels.Bug` / `Feature`). Its only callers are two tests, `FeedbackParserTest.scala:162-170`. It has been dead in production since the feedback command left Linear, and the Forgejo routing added by IW-426 has no label parameter at all — `ForgejoClient.buildCreateIssueBody` (`core/adapters/ForgejoClient.scala:78-80`) is `ujson.Obj("title" -> …, "body" -> …)`. A function whose only callers are its own tests is dead code; test-only usage does not make it live. Remove the helper, its two tests, and the `Constants.IwCliLabels` entries it is the last reader of. Found during IW-426.

mph added the

agent-ready

label

2026-09-04 20:27:47 +00:00

mph commented

2026-09-04 20:27:47 +00:00

Author

Owner

Intake: agent-ready
Workflow: waterfall
Reason: all gates passed — analysis reviewed sound, 1 phase, no CLARIFY markers
Analysis: project-management/issues/IW-455/analysis.md on branch IW-455

Intake: agent-ready Workflow: waterfall Reason: all gates passed — analysis reviewed sound, 1 phase, no CLARIFY markers Analysis: project-management/issues/IW-455/analysis.md on branch IW-455

claude removed the

agent-ready

label

2026-09-25 21:51:41 +00:00

claude commented

2026-10-16 01:03:30 +00:00

Member

Intake: agent-ready
Workflow: waterfall
Reason: all gates passed
Analysis: project-management/issues/IW-455/analysis.md on branch IW-455

Intake: agent-ready Workflow: waterfall Reason: all gates passed Analysis: project-management/issues/IW-455/analysis.md on branch IW-455

claude added the

agent-ready

label

2026-10-16 01:03:30 +00:00

claude commented

2026-10-16 01:42:40 +00:00

Member

Implement: needs-human
Reason: batch-implement exit 1 — the kanon plugin does not compile against the iw-cli core of this branch. ForgeCatchUp.scala expects Either[String, …] from fetchPullRequestForBranch, and core returns Either[TrackerError, …] since #778. No phase ran; the branch is unchanged. This failure is not specific to this issue: every iw-cli item fails in the same way until the plugin follows the core change.

No batch-implement.log was written. The last lines of the command output:

[error] /home/mph/.local/share/iw/plugins/kanon/lib/batch/ForgeCatchUp.scala:143:7
[error] Found:    Either[iw.core.model.TrackerError, Option[batch.ForgeState]]
[error] Required: Either[String, Option[batch.ForgeState]]
Compilation failed

Implement: needs-human Reason: batch-implement exit 1 — the kanon plugin does not compile against the iw-cli core of this branch. `ForgeCatchUp.scala` expects `Either[String, …]` from `fetchPullRequestForBranch`, and core returns `Either[TrackerError, …]` since #778. No phase ran; the branch is unchanged. This failure is not specific to this issue: every iw-cli item fails in the same way until the plugin follows the core change. No `batch-implement.log` was written. The last lines of the command output: ``` [error] /home/mph/.local/share/iw/plugins/kanon/lib/batch/ForgeCatchUp.scala:143:7 [error] Found: Either[iw.core.model.TrackerError, Option[batch.ForgeState]] [error] Required: Either[String, Option[batch.ForgeState]] Compilation failed ```

claude added

needs-human

and removed

agent-ready

labels

2026-10-16 01:42:40 +00:00

claude commented

2026-10-16 17:10:33 +00:00

Member

Release: the implement loop failed this issue for a reason outside it. The kanon plugin did not compile against iw-cli main, because the tracker port now returns TrackerError (iw-cli #778). The plugin fix is dev-docs #484, and iw-cli 0.22.1 carries the core change. The issue goes back to the implement loop.

claude added

agent-ready

and removed

needs-human

labels

2026-10-16 17:10:33 +00:00