phase-merge and phase-pr batch merge repeat the commit, merge, checkout and merged-card sequence #584

New issue

Open

opened 2026-09-21 08:33:45 +00:00 by claude · 3 comments

claude commented

2026-09-21 08:33:45 +00:00

Member

Found during IW-578 phase 1.

PhaseMerge.doMergeAndAdvance and PhasePr.doBatchMerge repeat the commit → merge → checkout/reset → merged-card sequence almost verbatim; one shared function would stop the two from diverging. IW-578 phase 1 changed only PhaseMerge; check whether doBatchMerge still has the ordering fault that IW-578 fixed.

Found during IW-578 phase 1. `PhaseMerge.doMergeAndAdvance` and `PhasePr.doBatchMerge` repeat the commit → merge → checkout/reset → merged-card sequence almost verbatim; one shared function would stop the two from diverging. IW-578 phase 1 changed only `PhaseMerge`; check whether `doBatchMerge` still has the ordering fault that IW-578 fixed.

claude referenced this issue

2026-09-21 08:35:33 +00:00

IW-578: phase-merge commits the review-state card before the merge, so the post-merge advance completes #587

claude commented

2026-10-15 19:06:07 +00:00

Author

Member

Intake: agent-ready
Workflow: waterfall
Reason: all gates passed
Analysis: project-management/issues/IW-584/analysis.md on branch IW-584

Intake: agent-ready Workflow: waterfall Reason: all gates passed Analysis: project-management/issues/IW-584/analysis.md on branch IW-584

claude added the

agent-ready

label

2026-10-15 19:06:07 +00:00

claude commented

2026-10-15 19:20:30 +00:00

Author

Member

Implement: needs-human
Reason: batch-implement exit 1 — the kanon plugin did not compile against iw-cli core at main 33e14e5f, so no phase ran

kanon/lib/batch/ForgeCatchUp.scala expects fetchPullRequestForBranch to return Either[String, …]. Core returns Either[TrackerError, …] since #778 / #780. This fault is in the plugin, not in IW-584, and every issue will fail the same way until the plugin is updated. No batch-implement.log was written; the lines below are the compiler output.

[error] .../plugins/kanon/lib/batch/ForgeCatchUp.scala:143:7
[error] Found:    Either[iw.core.model.TrackerError, Option[batch.ForgeState]]
[error] Required: Either[String, Option[batch.ForgeState]]
Compilation failed

Implement: needs-human Reason: batch-implement exit 1 — the kanon plugin did not compile against iw-cli core at main 33e14e5f, so no phase ran `kanon/lib/batch/ForgeCatchUp.scala` expects `fetchPullRequestForBranch` to return `Either[String, …]`. Core returns `Either[TrackerError, …]` since #778 / #780. This fault is in the plugin, not in IW-584, and every issue will fail the same way until the plugin is updated. No `batch-implement.log` was written; the lines below are the compiler output. ``` [error] .../plugins/kanon/lib/batch/ForgeCatchUp.scala:143:7 [error] Found: Either[iw.core.model.TrackerError, Option[batch.ForgeState]] [error] Required: Either[String, Option[batch.ForgeState]] Compilation failed ```

claude added

needs-human

and removed

agent-ready

labels

2026-10-15 19:20:30 +00:00

claude commented

2026-10-16 17:10:36 +00:00

Author

Member

Release: the implement loop failed this issue for a reason outside it. The kanon plugin did not compile against iw-cli main, because the tracker port now returns TrackerError (iw-cli #778). The plugin fix is dev-docs #484, and iw-cli 0.22.1 carries the core change. The issue goes back to the implement loop.

claude added

agent-ready

and removed

needs-human

labels

2026-10-16 17:10:37 +00:00