LinearClient.validateToken hides the cause of a failed token check #642

New issue

Open

opened 2026-09-26 04:47:58 +00:00 by claude · 3 comments

claude commented

2026-09-26 04:47:58 +00:00

Member

Found during IW-637. LinearClient.validateToken catches every exception (catch case _: Exception => false) and maps every non-200 code to false, so it hides the cause of a failure (network error, timeout, 5xx, 401) from hook-doctor users as well as from tests — core/adapters/LinearClient.scala:46.

Found during IW-637. `LinearClient.validateToken` catches every exception (`catch case _: Exception => false`) and maps every non-200 code to `false`, so it hides the cause of a failure (network error, timeout, 5xx, 401) from `hook-doctor` users as well as from tests — `core/adapters/LinearClient.scala:46`.

mph referenced this issue from a commit

2026-09-26 04:49:55 +00:00

chore(IW-637): add release notes, file follow-ups as #642 #643 #644

claude referenced this issue

2026-09-26 04:50:00 +00:00

IW-637: Remove live Linear API calls from the unit tier #645

claude commented

2026-10-15 17:15:51 +00:00

Author

Member

Intake: agent-ready
Workflow: diagnostic
Reason: all gates passed
Analysis: project-management/issues/IW-642/analysis.md on branch IW-642

Intake: agent-ready Workflow: diagnostic Reason: all gates passed Analysis: project-management/issues/IW-642/analysis.md on branch IW-642

claude added the

agent-ready

label

2026-10-15 17:15:51 +00:00

claude commented

2026-10-15 17:18:45 +00:00

Author

Member

Implement: needs-human
Reason: batch-implement exit 1 — the kanon plugin command did not compile, so no phase ran. fetchPullRequestForBranch in the iw-cli core now returns Either[TrackerError, …] (#778–#780), and the plugin's lib/batch/ForgeCatchUp.scala:143 still expects Either[String, …]. The cause is not in this issue: every batch-implement run against the current iw-cli main fails the same way until the plugin is updated. No batch-implement.log was written; the lines below are the command output.

[error] /home/mph/.local/share/iw/plugins/kanon/lib/batch/ForgeCatchUp.scala:143:7
[error] Found:    Either[iw.core.model.TrackerError, Option[batch.ForgeState]]
[error] Required: Either[String, Option[batch.ForgeState]]
Compilation failed

Implement: needs-human Reason: batch-implement exit 1 — the kanon plugin command did not compile, so no phase ran. `fetchPullRequestForBranch` in the iw-cli core now returns `Either[TrackerError, …]` (#778–#780), and the plugin's `lib/batch/ForgeCatchUp.scala:143` still expects `Either[String, …]`. The cause is not in this issue: every `batch-implement` run against the current iw-cli `main` fails the same way until the plugin is updated. No `batch-implement.log` was written; the lines below are the command output. ``` [error] /home/mph/.local/share/iw/plugins/kanon/lib/batch/ForgeCatchUp.scala:143:7 [error] Found: Either[iw.core.model.TrackerError, Option[batch.ForgeState]] [error] Required: Either[String, Option[batch.ForgeState]] Compilation failed ```

claude added

needs-human

and removed

agent-ready

labels

2026-10-15 17:18:45 +00:00

claude commented

2026-10-16 17:10:38 +00:00

Author

Member

Release: the implement loop failed this issue for a reason outside it. The kanon plugin did not compile against iw-cli main, because the tracker port now returns TrackerError (iw-cli #778). The plugin fix is dev-docs #484, and iw-cli 0.22.1 carries the core change. The issue goes back to the implement loop.

claude added

agent-ready

and removed

needs-human

labels

2026-10-16 17:10:38 +00:00