Dashboard server diagnostics: one stderr default sink, one recording test helper, and untested poller branches #796

New issue

Open

opened 2026-10-11 07:14:52 +00:00 by claude · 3 comments

claude commented

2026-10-11 07:14:52 +00:00

Member

Found during IW-681 (CaskServer and the pollers now take a diagnostics sink).

Fold serviceLinksLog into the diagnosticsLog sink of CaskServer.
The devMode test in CaskServerTest can see the --dev WARNING twice when startTestServer retries a failed bind, because CaskServer.start writes it before it binds — review-phase-01-20261011-074013.md (testing warning); the same review suggests one shared stderr default sink and passing the two sinks of CaskServer.start by name.
One shared recording-sink test helper for the poller and CaskServerTest log captures, and the scala.jdk.CollectionConverters import placed after the java.* group in IssuePollerTest/PullRequestPollerTest — review-phase-02-20261011-081327.md (style/scala3 suggestions).
No test pins the failure branch of PullRequestPoller.guarded or the silent read == 0 branch of either poller — review-phase-02-20261011-081327.md (testing suggestion).

Review files are under project-management/issues/IW-681/.

Found during IW-681 (CaskServer and the pollers now take a diagnostics sink). - [ ] Fold `serviceLinksLog` into the `diagnosticsLog` sink of `CaskServer`. - [ ] The devMode test in `CaskServerTest` can see the `--dev` WARNING twice when `startTestServer` retries a failed bind, because `CaskServer.start` writes it before it binds — review-phase-01-20261011-074013.md (testing warning); the same review suggests one shared stderr default sink and passing the two sinks of `CaskServer.start` by name. - [ ] One shared recording-sink test helper for the poller and `CaskServerTest` log captures, and the `scala.jdk.CollectionConverters` import placed after the `java.*` group in `IssuePollerTest`/`PullRequestPollerTest` — review-phase-02-20261011-081327.md (style/scala3 suggestions). - [ ] No test pins the failure branch of `PullRequestPoller.guarded` or the silent `read == 0` branch of either poller — review-phase-02-20261011-081327.md (testing suggestion). Review files are under project-management/issues/IW-681/.

mph referenced this issue from a commit

2026-10-11 07:16:05 +00:00

chore(IW-681): file follow-ups as #795, #796 and #797

claude referenced this issue

2026-10-11 07:16:15 +00:00

IW-681: ./mill dashboard.test output is pristine #798

claude commented

2026-10-15 13:34:07 +00:00

Author

Member

Intake: agent-ready
Workflow: waterfall
Reason: all gates passed
Analysis: project-management/issues/IW-796/analysis.md on branch IW-796

Intake: agent-ready Workflow: waterfall Reason: all gates passed Analysis: project-management/issues/IW-796/analysis.md on branch IW-796

claude added the

agent-ready

label

2026-10-15 13:34:08 +00:00

claude commented

2026-10-15 17:44:42 +00:00

Author

Member

Implement: needs-human
Reason: batch-implement exit 1 — the kanon plugin did not compile against the iw-cli core of this branch, so no phase ran

ForgeCatchUp.scala expects Either[String, ...], but the core now returns Either[TrackerError, ...]. The fault is in the plugin, not in this issue. No batch-implement.log was written; these are the command's output lines:

[error] /home/mph/.local/share/iw/plugins/kanon/lib/batch/ForgeCatchUp.scala:143:7
[error] Found:    Either[iw.core.model.TrackerError, Option[batch.ForgeState]]
[error] Required: Either[String, Option[batch.ForgeState]]
Compilation failed

Implement: needs-human Reason: batch-implement exit 1 — the kanon plugin did not compile against the iw-cli core of this branch, so no phase ran `ForgeCatchUp.scala` expects `Either[String, ...]`, but the core now returns `Either[TrackerError, ...]`. The fault is in the plugin, not in this issue. No `batch-implement.log` was written; these are the command's output lines: ``` [error] /home/mph/.local/share/iw/plugins/kanon/lib/batch/ForgeCatchUp.scala:143:7 [error] Found: Either[iw.core.model.TrackerError, Option[batch.ForgeState]] [error] Required: Either[String, Option[batch.ForgeState]] Compilation failed ```

claude added

needs-human

and removed

agent-ready

labels

2026-10-15 17:44:42 +00:00

claude commented

2026-10-16 17:10:44 +00:00

Author

Member

Release: the implement loop failed this issue for a reason outside it. The kanon plugin did not compile against iw-cli main, because the tracker port now returns TrackerError (iw-cli #778). The plugin fix is dev-docs #484, and iw-cli 0.22.1 carries the core change. The issue goes back to the implement loop.

claude added

agent-ready

and removed

needs-human

labels

2026-10-16 17:10:44 +00:00