Dashboard: the GitHub issue-number parser for a raw string exists three times #733

Open
opened 2026-10-07 01:33:40 +00:00 by claude · 3 comments
Member

Found during IW-672 (IssueId.numericPart).

  • The GitHub issue-number parser on a raw String ("#N", "N", "TEAM-N") has three copies (dashboard/jvm/src/domain/IssueSource.scala:78, dashboard/jvm/src/application/IssueCacheService.scala:164, dashboard/jvm/src/application/IssueSearchService.scala:201); consider one owner.
Found during IW-672 (IssueId.numericPart). - [ ] The GitHub issue-number parser on a raw String ("#N", "N", "TEAM-N") has three copies (dashboard/jvm/src/domain/IssueSource.scala:78, dashboard/jvm/src/application/IssueCacheService.scala:164, dashboard/jvm/src/application/IssueSearchService.scala:201); consider one owner.
Author
Member

Intake: agent-ready
Workflow: waterfall
Reason: all gates passed
Analysis: project-management/issues/IW-733/analysis.md on branch IW-733

Intake: agent-ready Workflow: waterfall Reason: all gates passed Analysis: project-management/issues/IW-733/analysis.md on branch IW-733
Author
Member

Implement: needs-human
Reason: batch-implement exit 1 — the kanon plugin did not compile against the core of this branch: lib/batch/ForgeCatchUp.scala:143 expects Either[String, …] from fetchPullRequestForBranch, and core now returns Either[TrackerError, …] (#778, #780). No phase ran, and no batch-implement.log was written. The plugin must follow the core change before this issue can run.

[warn]  Using directives detected in multiple files:
- /home/mph/.local/share/iw/plugins/kanon/lib/deps.scala:1:1-7:41
It is recommended to keep them centralized in the /home/mph/Devel/iw/iw-cli-IW-733/core/project.scala file.

[error] /home/mph/.local/share/iw/plugins/kanon/lib/batch/ForgeCatchUp.scala:143:7
[error] Found:    Either[iw.core.model.TrackerError, Option[batch.ForgeState]]
[error] Required: Either[String, Option[batch.ForgeState]]
Compilation failed
Implement: needs-human Reason: batch-implement exit 1 — the kanon plugin did not compile against the core of this branch: lib/batch/ForgeCatchUp.scala:143 expects Either[String, …] from fetchPullRequestForBranch, and core now returns Either[TrackerError, …] (#778, #780). No phase ran, and no batch-implement.log was written. The plugin must follow the core change before this issue can run. ``` [warn] Using directives detected in multiple files: - /home/mph/.local/share/iw/plugins/kanon/lib/deps.scala:1:1-7:41 It is recommended to keep them centralized in the /home/mph/Devel/iw/iw-cli-IW-733/core/project.scala file. [error] /home/mph/.local/share/iw/plugins/kanon/lib/batch/ForgeCatchUp.scala:143:7 [error] Found: Either[iw.core.model.TrackerError, Option[batch.ForgeState]] [error] Required: Either[String, Option[batch.ForgeState]] Compilation failed ```
Author
Member

Release: the implement loop failed this issue for a reason outside it. The kanon plugin did not compile against iw-cli main, because the tracker port now returns TrackerError (iw-cli #778). The plugin fix is dev-docs #484, and iw-cli 0.22.1 carries the core change. The issue goes back to the implement loop.

Release: the implement loop failed this issue for a reason outside it. The kanon plugin did not compile against iw-cli main, because the tracker port now returns TrackerError (iw-cli #778). The plugin fix is dev-docs #484, and iw-cli 0.22.1 carries the core change. The issue goes back to the implement loop.
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
iterative-works/iw-cli#733
No description provided.