IW-672: Add IssueId.numericPart instead of repeated split("-").last #735

Merged

mph merged 20 commits from IW-672 into main 2026-10-08 06:23:26 +00:00

Conversation 2 Commits 20 Files changed 27 +1269 -63

claude commented 2026-10-07 01:35:05 +00:00

Member

Copy link

Summary

Adds IssueId.numericPart as the single owner of the rule that turns an issue ID (IW-672) into its number (672). It replaces the repeated issueId.value.split("-").last in the GitHub, GitLab and Forgejo adapters and in the dashboard IssueSource.

Changes

• core/model/IssueId.scala: new numericPart.
• Adapters have explicit contracts: GitHub takes the bare issue number, GitLab takes an IssueId; ForgejoClient.issueNumberOf uses numericPart.
• CommandEnv / LiveCommandEnv / FakeCommandEnv and Issue.scala call sites follow the adapter contracts.
• dashboard/jvm/src/domain/IssueSource.scala builds the issue link with numericPart.

No user-visible behavior change.

Testing

• IssueIdTest covers numericPart; adapter tests (GitHub, GitLab, Forgejo) and IssueHarnessTest updated to the new contracts.
• Phase PR #732 passed CI.

Follow-ups

Filed: #733, #734; added evidence to #586.

Release notes

Internal refactor with no user-visible change: the issue number is now derived from the issue ID in one place, used by issue fetch on GitHub, GitLab and Forgejo and by dashboard issue links. (Czech notes: project-management/issues/IW-672/release-notes.md.)

🤖 Generated with Claude Code

Closes #672

## Summary Adds `IssueId.numericPart` as the single owner of the rule that turns an issue ID (`IW-672`) into its number (`672`). It replaces the repeated `issueId.value.split("-").last` in the GitHub, GitLab and Forgejo adapters and in the dashboard `IssueSource`. ## Changes - `core/model/IssueId.scala`: new `numericPart`. - Adapters have explicit contracts: GitHub takes the bare issue number, GitLab takes an `IssueId`; `ForgejoClient.issueNumberOf` uses `numericPart`. - `CommandEnv` / `LiveCommandEnv` / `FakeCommandEnv` and `Issue.scala` call sites follow the adapter contracts. - `dashboard/jvm/src/domain/IssueSource.scala` builds the issue link with `numericPart`. No user-visible behavior change. ## Testing - `IssueIdTest` covers `numericPart`; adapter tests (GitHub, GitLab, Forgejo) and `IssueHarnessTest` updated to the new contracts. - Phase PR #732 passed CI. ## Follow-ups Filed: #733, #734; added evidence to #586. ## Release notes Internal refactor with no user-visible change: the issue number is now derived from the issue ID in one place, used by issue fetch on GitHub, GitLab and Forgejo and by dashboard issue links. (Czech notes: `project-management/issues/IW-672/release-notes.md`.) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Closes #672

claude added 12 commits 2026-10-07 01:35:06 +00:00

workflow(wf): Create analysis for IW-672 ... 20f7d1d5ef

Add IssueId.numericPart instead of repeated split("-").last

Artifacts:
- analysis.md
- issue.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8ZD5foFWAE2zV1xYojPMa

chore(IW-672): update review-state to tasks_ready fb50b83dec

workflow(wf): Create task index for IW-672 ... c6265547f9

Add IssueId.numericPart instead of repeated split("-").last

Artifacts:
- tasks.md
- review-state.json (tasks_ready)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8ZD5foFWAE2zV1xYojPMa

docs(IW-672): intake verdict — agent-ready ... a233de9f2c

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8ZD5foFWAE2zV1xYojPMa

Phase 1: context ready ... c5de7265a5

Issue: IW-672
Phase: 1 - IssueId.numericPart + adapter contracts

This commit marks the checkpoint for phase 1 context generation.
Use wf-implement IW-672 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-672): update review-state to context_ready 9f6f7d371e

workflow(wf): Generate Phase 1 tasks for IW-672 ... 3128c011fc

IssueId.numericPart + adapter contracts

Artifacts:
- phase-01-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-672): update review-state to tasks_ready a95435020a

Merge remote-tracking branch 'origin/main' into IW-672 0d1b31ca2d

Phase 1: IssueId.numericPart + adapter contracts (#732) ccc9622d60

chore(IW-672): mark phase 01 complete in tasks.md d953c92f08

docs(IW-672): review packet, release notes; file follow-ups ... cf061a97d8

Follow-ups filed: #733 (dashboard issue-number parser), #734 (Small fixes: core),
comment on #586 (phase-pr push output in card message).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude referenced this pull request 2026-10-07 01:58:28 +00:00

Small fixes: core #734

mph requested changes 2026-10-07 07:33:39 +00:00

mph left a comment

Copy link

There are conflicts after merging other branches.

There are conflicts after merging other branches.

mph added 1 commit 2026-10-07 23:12:41 +00:00

docs(IW-672): rework for final PR review 18 ca5c147318

mph added 2 commits 2026-10-07 23:15:53 +00:00

Phase 2: context ready ... 9e24acd3ae

Issue: IW-672
Phase: 2 - Rework for final PR review 18

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

workflow(wf): Generate Phase 2 tasks for IW-672 ... 11a48676c3

Rework for final PR review 18

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude added 1 commit 2026-10-07 23:45:23 +00:00

Phase 2: Rework for final PR review 18 (#748) 32334fcd5b

claude referenced this pull request 2026-10-07 23:47:12 +00:00

phase-merge squashes a sync phase, so the feature branch loses the main ancestry and the final PR stays unmergeable #750

mph added 4 commits 2026-10-07 23:49:26 +00:00

chore(IW-672): mark phase 02 complete in tasks.md 065a351140

chore(IW-672): file follow-up as #749 ... 82f8ce06d2

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge origin/main into IW-672 ... 635339dcbf

Restores the ancestry that the squash merge of the phase 2 sync (#748)
dropped. The tree is identical to the parent: the sync resolution is
kept as reviewed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(IW-672): review packet for the whole branch ... 3d0ead03ba

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude commented 2026-10-07 23:50:13 +00:00

Author

Member

Copy link

Implement: rework for review 18
The rework phase merged into IW-672 through #748; this pull request carries it.

Implement: rework for review 18 The rework phase merged into IW-672 through #748; this pull request carries it.

claude referenced this pull request 2026-10-08 00:27:18 +00:00

fetchIssueComments re-derives the issue number with split("-").last in GitHubClient and GitLabClient #749

claude referenced this pull request 2026-10-08 01:39:05 +00:00

Comment fetch: order, errors and tests differ per adapter #700

mph merged commit 72b4dca274 into main 2026-10-08 06:23:26 +00:00

mph referenced this pull request from a commit 2026-10-08 06:23:28 +00:00

Merge pull request 'IW-672: Add IssueId.numericPart instead of repeated split("-").last' (#735) from IW-672 into main

claude referenced this pull request 2026-10-11 00:47:15 +00:00

Comment fetch: the oldest-first order and the comment-shape probes are not tested for every adapter #783

Sign in to join this conversation.

Reviewers

No reviewers

mph

Labels

Clear labels   

agent-ready

  

bug

Something isn't working

  

contract

Run the tool-contract suite on this PR

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

needs-human

  

needs-input

Intake asked the human a question on the issue; waiting for the answer

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

agent-ready

bug

contract

documentation

duplicate

enhancement

good first issue

help wanted

invalid

needs-human

needs-input

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

iterative-works/iw-cli!735

No description provided.