A failed push in phase-pr writes the pre-push hook's whole output into the review-state card message

claude commented

2026-09-21 08:33:49 +00:00

Member

Found during IW-578 phase 1.

A failed push in phase-pr writes the whole failure text — the pre-push hook's full output, ~600 KB — into the review-state card's message field.

Found during IW-578 phase 1. A failed push in `phase-pr` writes the whole failure text — the pre-push hook's full output, ~600 KB — into the review-state card's `message` field.

claude referenced this issue

2026-09-21 08:35:33 +00:00

IW-578: phase-merge commits the review-state card before the merge, so the post-merge advance completes #587

claude commented

2026-09-21 14:50:36 +00:00

Author

Member

Seen again on IW-491 phase 1: the first phase-pr --no-wait push failed, and the card grew to 623 KB, with message at 516 KB.

Seen again on IW-491 phase 1: the first `phase-pr --no-wait` push failed, and the card grew to 623 KB, with `message` at 516 KB.

mph referenced this issue from a commit

2026-09-21 14:52:05 +00:00

chore(IW-491): file follow-ups on the tracker

claude referenced this issue

2026-09-21 14:52:17 +00:00

IW-491: phase-pr pushes a commit after reading CI, so its green can describe a stale head #596

claude commented

2026-10-02 08:45:31 +00:00

Author

Member

Seen again during IW-652:

iw phase-pr writes the whole output of a push that the pre-push hook refused (about 600 KB of test log) into the review-state message, and the text stays after a later green run — PR #664, review-state.json after the run that was stopped by CommandDeclarationTest.

Seen again during IW-652: - `iw phase-pr` writes the whole output of a push that the pre-push hook refused (about 600 KB of test log) into the review-state `message`, and the text stays after a later green run — PR #664, review-state.json after the run that was stopped by `CommandDeclarationTest`.

mph referenced this issue from a commit

2026-10-02 08:47:47 +00:00

workflow: Triage lessons for IW-652

claude referenced this issue

2026-10-02 08:48:04 +00:00

IW-652: Per-user dashboard on a shared dev machine — tailnet service, service links, Claude session links #683

claude commented

2026-10-05 11:46:32 +00:00

Author

Member

Seen again in IW-715 (2026-10-05):

a failed phase-pr push writes the whole pre-push hook output into the card's message, and later commands keep it — core/adapters/Git.scala:287 puts $reason (all of stderr) into the error, and phase-pr stores it; on 2026-10-05 the IW-715 card grew to 700 KB (message 580 385 chars), still there after phase-advance, so every review-state path/cat of the card floods the terminal.

Seen again in IW-715 (2026-10-05): - [ ] a failed phase-pr push writes the whole pre-push hook output into the card's `message`, and later commands keep it — core/adapters/Git.scala:287 puts `$reason` (all of stderr) into the error, and phase-pr stores it; on 2026-10-05 the IW-715 card grew to 700 KB (`message` 580 385 chars), still there after phase-advance, so every `review-state path`/`cat` of the card floods the terminal.

mph referenced this issue from a commit

2026-10-05 11:47:55 +00:00

workflow(wf): Review packet and release notes for IW-715

claude commented

2026-10-07 01:33:46 +00:00

Author

Member

Seen again during IW-672, phase 1:

iw phase-pr writes the whole failed git push output (pre-push hook log, ~470 KB) into review-state message — seen on IW-672 phase 1; the card should hold a short summary.

Seen again during IW-672, phase 1: - [ ] `iw phase-pr` writes the whole failed `git push` output (pre-push hook log, ~470 KB) into review-state `message` — seen on IW-672 phase 1; the card should hold a short summary.

mph referenced this issue from a commit

2026-10-07 01:34:57 +00:00

docs(IW-672): review packet, release notes; file follow-ups

claude referenced this issue

2026-10-07 01:35:05 +00:00

IW-672: Add IssueId.numericPart instead of repeated split("-").last #735

claude commented

2026-10-15 18:21:30 +00:00

Author

Member

Intake: agent-ready
Workflow: diagnostic
Reason: all gates passed
Analysis: project-management/issues/IW-586/analysis.md on branch IW-586

Intake: agent-ready Workflow: diagnostic Reason: all gates passed Analysis: project-management/issues/IW-586/analysis.md on branch IW-586

claude added the

agent-ready

label

2026-10-15 18:21:30 +00:00

claude commented

2026-10-15 18:48:34 +00:00

Author

Member

Implement: needs-human
Reason: batch-implement exit 1 — the kanon plugin does not compile against the iw-cli core of this branch. ForgeCatchUp.scala:143 expects Either[String, …] from fetchPullRequestForBranch, and the core now returns Either[TrackerError, …] (#778, #780). No phase ran. This stops every iw-cli issue until the plugin is updated, not only this one.

The plugin wrote no batch-implement.log. The last lines of the command output:

[error] /home/mph/.local/share/iw/plugins/kanon/lib/batch/ForgeCatchUp.scala:143:7
[error] Found:    Either[iw.core.model.TrackerError, Option[batch.ForgeState]]
[error] Required: Either[String, Option[batch.ForgeState]]
Compilation failed
exit=1

Implement: needs-human Reason: batch-implement exit 1 — the kanon plugin does not compile against the iw-cli core of this branch. `ForgeCatchUp.scala:143` expects `Either[String, …]` from `fetchPullRequestForBranch`, and the core now returns `Either[TrackerError, …]` (#778, #780). No phase ran. This stops every iw-cli issue until the plugin is updated, not only this one. The plugin wrote no batch-implement.log. The last lines of the command output: ``` [error] /home/mph/.local/share/iw/plugins/kanon/lib/batch/ForgeCatchUp.scala:143:7 [error] Found: Either[iw.core.model.TrackerError, Option[batch.ForgeState]] [error] Required: Either[String, Option[batch.ForgeState]] Compilation failed exit=1 ```

claude added

needs-human

and removed

agent-ready

labels

2026-10-15 18:48:34 +00:00

claude commented

2026-10-16 17:10:37 +00:00

Author

Member

Release: the implement loop failed this issue for a reason outside it. The kanon plugin did not compile against iw-cli main, because the tracker port now returns TrackerError (iw-cli #778). The plugin fix is dev-docs #484, and iw-cli 0.22.1 carries the core change. The issue goes back to the implement loop.

claude added

agent-ready

and removed

needs-human

labels

2026-10-16 17:10:37 +00:00

Rows
Columns

A failed push in phase-pr writes the pre-push hook's whole output into the review-state card message #586