Subcommand dispatch: runParent and runSub are copied in five dispatchers #755

New issue

Open

opened 2026-10-08 02:50:39 +00:00 by claude · 3 comments

claude commented

2026-10-08 02:50:39 +00:00

Member

Found during IW-682 (port allocation for worktrees). IW-744 covers the parent-level handler but was analysed before PortSlotCommand existed. Follow-up, verbatim:

runParent is copied in five dispatchers — core/commands/Config.scala:131, GateCommand.scala:139, Server.scala:186, Service.scala:165, PortSlotCommand.scala; runSub in Server.scala, Service.scala and PortSlotCommand.scala. One shared helper would replace them.

Found during IW-682 (port allocation for worktrees). IW-744 covers the parent-level handler but was analysed before `PortSlotCommand` existed. Follow-up, verbatim: - [ ] `runParent` is copied in five dispatchers — core/commands/Config.scala:131, GateCommand.scala:139, Server.scala:186, Service.scala:165, PortSlotCommand.scala; `runSub` in Server.scala, Service.scala and PortSlotCommand.scala. One shared helper would replace them.

mph referenced this issue from a commit

2026-10-08 02:53:06 +00:00

chore(IW-682): file follow-ups (#440, #585, #754, #755, #756)

claude referenced this issue

2026-10-08 02:53:36 +00:00

IW-682: Port allocation for worktrees (iw port-slot) #757

claude commented

2026-10-15 14:50:23 +00:00

Author

Member

Intake: agent-ready
Workflow: waterfall
Reason: all gates passed
Analysis: project-management/issues/IW-755/analysis.md on branch IW-755

Intake: agent-ready Workflow: waterfall Reason: all gates passed Analysis: project-management/issues/IW-755/analysis.md on branch IW-755

claude added the

agent-ready

label

2026-10-15 14:50:23 +00:00

claude commented

2026-10-15 17:21:43 +00:00

Author

Member

[warn]  Using directives detected in multiple files:
- /home/mph/.local/share/iw/plugins/kanon/lib/deps.scala:1:1-7:41
It is recommended to keep them centralized in the /home/mph/Devel/iw/iw-cli-IW-755/core/project.scala file.

[error] /home/mph/.local/share/iw/plugins/kanon/lib/batch/ForgeCatchUp.scala:143:7
[error] Found:    Either[iw.core.model.TrackerError, Option[batch.ForgeState]]
[error] Required: Either[String, Option[batch.ForgeState]]
Compilation failed

Implement: needs-human Reason: batch-implement exit 1 — the kanon plugin command did not compile against the iw-cli core of this branch, so no phase ran. ForgeCatchUp.scala expects Either[String, …] from fetchPullRequestForBranch, and core now returns Either[TrackerError, …] (#778, #780). The kanon plugin must be updated to TrackerError; the issue itself is not at fault. batch-implement.log was not written; the lines below are the command output. ``` [warn] Using directives detected in multiple files: - /home/mph/.local/share/iw/plugins/kanon/lib/deps.scala:1:1-7:41 It is recommended to keep them centralized in the /home/mph/Devel/iw/iw-cli-IW-755/core/project.scala file. [error] /home/mph/.local/share/iw/plugins/kanon/lib/batch/ForgeCatchUp.scala:143:7 [error] Found: Either[iw.core.model.TrackerError, Option[batch.ForgeState]] [error] Required: Either[String, Option[batch.ForgeState]] Compilation failed ```

claude added

needs-human

and removed

agent-ready

labels

2026-10-15 17:21:43 +00:00

claude commented

2026-10-16 17:10:42 +00:00

Author

Member

Release: the implement loop failed this issue for a reason outside it. The kanon plugin did not compile against iw-cli main, because the tracker port now returns TrackerError (iw-cli #778). The plugin fix is dev-docs #484, and iw-cli 0.22.1 carries the core change. The issue goes back to the implement loop.

claude added

agent-ready

and removed

needs-human

labels

2026-10-16 17:10:43 +00:00