PhaseAdvance.maybeUpdateReviewState repeats the PhaseMergedCard shape instead of calling PhaseMergedCard.update #612

New issue

Closed

opened 2026-09-22 22:11:46 +00:00 by claude · 1 comment

claude commented

2026-09-22 22:11:46 +00:00

Member

Found in IW-606 phase 1.

PhaseAdvance.maybeUpdateReviewState builds the phase-merged card by hand. It repeats the shape that PhaseMergedCard.update already owns. A change to the merged card (for example the owned-badge supersede from IW-606) must be made in two places, and nothing catches a miss.

PROPOSED FIX. Make PhaseAdvance call PhaseMergedCard.update. This also changes needs_attention and the CI-wait fields that phase-advance writes, so it needs its own change and its own tests.

Found in IW-606 phase 1. `PhaseAdvance.maybeUpdateReviewState` builds the phase-merged card by hand. It repeats the shape that `PhaseMergedCard.update` already owns. A change to the merged card (for example the owned-badge supersede from IW-606) must be made in two places, and nothing catches a miss. PROPOSED FIX. Make `PhaseAdvance` call `PhaseMergedCard.update`. This also changes `needs_attention` and the CI-wait fields that `phase-advance` writes, so it needs its own change and its own tests.