IW-606: A merged card still shows the In Progress badge, because no phase command removes one #614

Merged

mph merged 13 commits from IW-606 into main 2026-09-23 15:03:17 +00:00

Conversation 0 Commits 13 Files changed 27 +1677 -25

claude commented 2026-09-22 22:13:40 +00:00

Member

Copy link

Summary

A review-state card could show two or three phase-lifecycle badges at once (In Progress, Review Needed, Complete). Every phase command appended its badge and no command removed the badge before it. So a merged card still said In Progress.

Defect fixed

Phase 1 — Phase-lifecycle badges are only ever added, never removed (#611)

• New PhaseLifecycleBadge enum is the one owner of the three lifecycle labels.
• ReviewStateUpdater.UpdateInput.supersededBadges: when a phase command writes a lifecycle badge, it removes every other badge of the family first. The new badge takes the position of the first badge it removes.
• phase-start, phase-pr, phase-merge (through PhaseMergedCard) and phase-advance use the supersede.
• Badges outside the family (severity, Phase NN: CI not judged) stay.
• The --badge / --append-badge / --clear-badges CLI flags do not change.
• docs/review-state-cards.md documents the rule.

Testing

• Unit: ReviewStateUpdaterTest, PhaseLifecycleBadgeHarnessTest, and the harness tests of phase-start, phase-pr, phase-merge, phase-advance, PhaseMergedCard.
• CI ran the full suite on the phase PR #611.

Follow-ups filed

• #612 — PhaseAdvance.maybeUpdateReviewState repeats the PhaseMergedCard shape.
• #613 — test/help-intercept.bats has a non-final ! grep -q assertion that bats does not check.

Release notes

Karta úkolu na přehledu teď vždy ukazuje jen jeden stav fáze. Každý krok práce na fázi nyní svůj stav nahradí místo toho, aby jen přidal další štítek. Štítek závažnosti a poznámky ke konkrétní fázi zůstávají beze změny. Plné znění: project-management/issues/IW-606/release-notes.md.

🤖 Generated with Claude Code

Closes #606

## Summary A review-state card could show two or three phase-lifecycle badges at once (`In Progress`, `Review Needed`, `Complete`). Every phase command appended its badge and no command removed the badge before it. So a merged card still said `In Progress`. ## Defect fixed **Phase 1 — Phase-lifecycle badges are only ever added, never removed** (#611) - New `PhaseLifecycleBadge` enum is the one owner of the three lifecycle labels. - `ReviewStateUpdater.UpdateInput.supersededBadges`: when a phase command writes a lifecycle badge, it removes every other badge of the family first. The new badge takes the position of the first badge it removes. - `phase-start`, `phase-pr`, `phase-merge` (through `PhaseMergedCard`) and `phase-advance` use the supersede. - Badges outside the family (severity, `Phase NN: CI not judged`) stay. - The `--badge` / `--append-badge` / `--clear-badges` CLI flags do not change. - `docs/review-state-cards.md` documents the rule. ## Testing - Unit: `ReviewStateUpdaterTest`, `PhaseLifecycleBadgeHarnessTest`, and the harness tests of `phase-start`, `phase-pr`, `phase-merge`, `phase-advance`, `PhaseMergedCard`. - CI ran the full suite on the phase PR #611. ## Follow-ups filed - #612 — `PhaseAdvance.maybeUpdateReviewState` repeats the `PhaseMergedCard` shape. - #613 — `test/help-intercept.bats` has a non-final `! grep -q` assertion that bats does not check. ## Release notes Karta úkolu na přehledu teď vždy ukazuje jen jeden stav fáze. Každý krok práce na fázi nyní svůj stav nahradí místo toho, aby jen přidal další štítek. Štítek závažnosti a poznámky ke konkrétní fázi zůstávají beze změny. Plné znění: `project-management/issues/IW-606/release-notes.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Closes #606

claude added 12 commits 2026-09-22 22:13:40 +00:00

workflow(dx): Create diagnostic analysis for IW-606 ... 51eb916e92

A merged card still shows the In Progress badge, because no phase command removes one

Artifacts:
- analysis.md
- issue.md

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-606): update review-state to tasks_ready e73504b674

workflow(dx): Create task index for IW-606 ... ef53c64a23

A merged card still shows the In Progress badge, because no phase command removes one

Artifacts:
- tasks.md
- review-state.json (tasks_ready)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Phase 1: context ready ... e553b7afc6

Issue: IW-606
Phase: 1 - Phase-lifecycle badges are only ever added, never removed

This commit marks the checkpoint for phase 1 context generation.
Use dx-fix IW-606 to return to this point.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-606): update review-state to context_ready e8ea630801

workflow(dx): Generate Phase 1 tasks for IW-606 ... 78cd0e1aad

Phase-lifecycle badges are only ever added, never removed

Artifacts:
- phase-01-tasks.md

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-606): update review-state to tasks_ready 71d0670dd6

Phase 1: Phase-lifecycle badges are only ever added, never removed (#611) 20773ff204

chore(IW-606): update review-state for phase 01 48434cae42

chore(IW-606): mark phase 01 complete in tasks.md 1f1fd5e695

chore(IW-606): file follow-ups as #612 and #613 ... 94f0b568ab

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(IW-606): add release notes ... 4e35cc65f2

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

mph added 1 commit 2026-09-22 22:14:48 +00:00

chore(IW-606): update review-state to all_complete dc6733430f

mph merged commit 66c0e9a18a into main 2026-09-23 15:03:17 +00:00

mph referenced this pull request from a commit 2026-09-23 15:03:19 +00:00

Merge pull request 'IW-606: A merged card still shows the In Progress badge, because no phase command removes one' (#614) from IW-606 into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

agent-ready

  

bug

Something isn't working

  

contract

Run the tool-contract suite on this PR

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

needs-human

  

needs-input

Intake asked the human a question on the issue; waiting for the answer

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

agent-ready

bug

contract

documentation

duplicate

enhancement

good first issue

help wanted

invalid

needs-human

needs-input

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

iterative-works/iw-cli!614

No description provided.