test/help-intercept.bats uses a non-final '! grep -q', which bats does not check #613

New issue

Closed

opened 2026-09-22 22:11:46 +00:00 by claude · 1 comment

claude commented

2026-09-22 22:11:46 +00:00

Member

Found in IW-606 phase 1.

test/help-intercept.bats (lines 114 and 189) asserts ! grep -q "phase_merged" ... as a statement that is not the last one in the test. Bash exempts a command negated with a leading ! from errexit, so bats does not fail the test when grep finds a match. The assertion can never fail.

PROPOSED FIX. Rewrite each one as [[ "$output" != *"phase_merged"* ]], or another construct that aborts the test on a mismatch.

Found in IW-606 phase 1. `test/help-intercept.bats` (lines 114 and 189) asserts `! grep -q "phase_merged" ...` as a statement that is not the last one in the test. Bash exempts a command negated with a leading `!` from `errexit`, so bats does not fail the test when `grep` finds a match. The assertion can never fail. PROPOSED FIX. Rewrite each one as `[[ "$output" != *"phase_merged"* ]]`, or another construct that aborts the test on a mismatch.