iterative-works/iw-cli
Watch
3
0
Fork
You've already forked iw-cli
 0
Code Issues 119 Pull requests 1 Projects Releases 34 Packages Wiki Activity Actions

IW-623: Document that timeoutMs applies when destroyOnExit = false #626

Merged
claude merged 13 commits from IW-623 into main 2026-09-26 11:12:34 +00:00
Conversation 0 Commits 13 Files changed 12 +758 -1
claude commented 2026-09-25 23:44:12 +00:00
Member
Copy link

Summary

The Scaladoc of ProcessAdapter.run now states that timeoutMs applies with either value of destroyOnExit. Before, only docs/api/Process.md said it, so a caller that read only the Scaladoc could think a shutdown-safe call (destroyOnExit = false) has no timeout.

Changes

  • core/adapters/Process.scala: one sentence added to the run Scaladoc. No change to signature or behaviour.
  • core/test/ProcessTest.scala: new test run times out when destroyOnExit is false pins the documented claim.
  • Issue artifacts under project-management/issues/IW-623/ (analysis, phase context, review, review packet, release notes).

Testing

  • ./mill core.test.testOnly 'iw.tests.ProcessTest' passes; the phase PR (#625) ran the full CI suite green.
  • The new test was mutation-checked in phase 1 (see implementation log).

Release notes

See project-management/issues/IW-623/release-notes.md (Czech).

🤖 Generated with Claude Code

Closes #623

## Summary The Scaladoc of `ProcessAdapter.run` now states that `timeoutMs` applies with either value of `destroyOnExit`. Before, only `docs/api/Process.md` said it, so a caller that read only the Scaladoc could think a shutdown-safe call (`destroyOnExit = false`) has no timeout. ## Changes - `core/adapters/Process.scala`: one sentence added to the `run` Scaladoc. No change to signature or behaviour. - `core/test/ProcessTest.scala`: new test `run times out when destroyOnExit is false` pins the documented claim. - Issue artifacts under `project-management/issues/IW-623/` (analysis, phase context, review, review packet, release notes). ## Testing - `./mill core.test.testOnly 'iw.tests.ProcessTest'` passes; the phase PR (#625) ran the full CI suite green. - The new test was mutation-checked in phase 1 (see implementation log). ## Release notes See `project-management/issues/IW-623/release-notes.md` (Czech). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Closes #623
ProcessAdapter.run Scaladoc does not say that timeoutMs applies when destroyOnExit = false

Artifacts:
- analysis.md
- issue.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
ProcessAdapter.run Scaladoc does not say that timeoutMs applies when destroyOnExit = false

Artifacts:
- tasks.md
- review-state.json (tasks_ready)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Issue: IW-623
Phase: 1 - Document and pin timeoutMs with destroyOnExit = false

This commit marks the checkpoint for phase 1 context generation.
Use wf-implement IW-623 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Document and pin timeoutMs with destroyOnExit = false

Artifacts:
- phase-01-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
docs(IW-623): add review packet and release notes
Some checks failed
CI / changes (pull_request) Successful in 4s
Details
CI / contract (pull_request) Has been skipped
Details
CI / format (pull_request) Successful in 10s
Details
CI / test (pull_request) Has been cancelled
Details
CI / dashboard-build (pull_request) Has been cancelled
Details
CI / lint (pull_request) Successful in 13s
Details
CI / compile (pull_request) Has been cancelled
Details
db6366bebd 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chore(IW-623): update review-state to all_complete
All checks were successful
CI / changes (pull_request) Successful in 4s
Details
CI / format (pull_request) Successful in 9s
Details
CI / dashboard-build (pull_request) Successful in 1m14s
Details
CI / contract (pull_request) Has been skipped
Details
CI / lint (pull_request) Successful in 12s
Details
CI / compile (pull_request) Successful in 1m35s
Details
CI / test (pull_request) Successful in 15m35s
Details
1683a8878f
claude merged commit 4ed5d598dc into main 2026-09-26 11:12:34 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent-ready

   
bug
Something isn't working

  
contract
Run the tool-contract suite on this PR

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
needs-human

   
needs-input
Intake asked the human a question on the issue; waiting for the answer

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
agent-ready
bug
contract
documentation
duplicate
enhancement
good first issue
help wanted
invalid
needs-human
needs-input
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
iterative-works/iw-cli!626
No description provided.