iterative-works/iw-cli
Watch
3
0
Fork
You've already forked iw-cli
 0
Code Issues 119 Pull requests 1 Projects Releases 34 Packages Wiki Activity Actions

IW-613: Make non-final negated BATS assertions fail the test #647

Merged
claude merged 13 commits from IW-613 into main 2026-09-26 11:16:16 +00:00
Conversation 0 Commits 13 Files changed 13 +772 -5
claude commented 2026-09-26 05:49:21 +00:00
Member
Copy link

Summary

Five BATS assertions used a negated command (! <cmd>) in a non-final position. Bash does not apply errexit to a pipeline that starts with !, so bats could not fail the test at that line. The assertions were vacuous.

Defects fixed

  • Phase 1 (#646): appended || false to each non-final negated assertion:
    • test/help-intercept.bats:114 and :189
    • test/rm.bats:61
    • test/open.bats:53
    • test/contract/mill_contract.bats:62

Testing

  • Reproduction (negation-repro.bats) confirmed the root cause before the fix.
  • Mutation proof: each of the five assertions goes red when its guarded condition is injected; before the fix, the same mutation on help-intercept.bats:114 stayed green.
  • Unmutated runs green: help-intercept.bats 16/16, rm.bats 2/2, open.bats 1/1, contract/mill_contract.bats 6/6.
  • No hidden defects surfaced when the assertions became effective.

Release notes

See project-management/issues/IW-613/release-notes.md (Czech). Test-only change; no user-visible behavior changes.

🤖 Generated with Claude Code

Closes #613

## Summary Five BATS assertions used a negated command (`! <cmd>`) in a non-final position. Bash does not apply `errexit` to a pipeline that starts with `!`, so bats could not fail the test at that line. The assertions were vacuous. ## Defects fixed - **Phase 1 (#646):** appended ` || false` to each non-final negated assertion: - `test/help-intercept.bats:114` and `:189` - `test/rm.bats:61` - `test/open.bats:53` - `test/contract/mill_contract.bats:62` ## Testing - Reproduction (`negation-repro.bats`) confirmed the root cause before the fix. - Mutation proof: each of the five assertions goes red when its guarded condition is injected; before the fix, the same mutation on `help-intercept.bats:114` stayed green. - Unmutated runs green: `help-intercept.bats` 16/16, `rm.bats` 2/2, `open.bats` 1/1, `contract/mill_contract.bats` 6/6. - No hidden defects surfaced when the assertions became effective. ## Release notes See `project-management/issues/IW-613/release-notes.md` (Czech). Test-only change; no user-visible behavior changes. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Closes #613
test/help-intercept.bats uses a non-final '! grep -q', which bats does not check

Artifacts:
- analysis.md
- issue.md

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
test/help-intercept.bats uses a non-final '! grep -q', which bats does not check

Artifacts:
- tasks.md
- review-state.json (tasks_ready)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Issue: IW-613
Phase: 1 - Negated commands in a non-final position do not fail the test

This commit marks the checkpoint for phase 1 context generation.
Use dx-fix IW-613 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Negated commands in a non-final position do not fail the test

Artifacts:
- phase-01-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
docs(IW-613): add release notes
Some checks failed
CI / changes (pull_request) Successful in 4s
Details
CI / contract (pull_request) Has been skipped
Details
CI / format (pull_request) Successful in 9s
Details
CI / lint (pull_request) Successful in 12s
Details
CI / test (pull_request) Has been cancelled
Details
CI / dashboard-build (pull_request) Has been cancelled
Details
CI / compile (pull_request) Has been cancelled
Details
d9a0ff3929 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chore(IW-613): update review-state to all_complete
All checks were successful
CI / changes (pull_request) Successful in 4s
Details
CI / contract (pull_request) Has been skipped
Details
CI / format (pull_request) Successful in 10s
Details
CI / lint (pull_request) Successful in 12s
Details
CI / compile (pull_request) Successful in 1m34s
Details
CI / dashboard-build (pull_request) Successful in 1m14s
Details
CI / test (pull_request) Successful in 15m33s
Details
2d1addbc66
claude merged commit 94689b3124 into main 2026-09-26 11:16:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent-ready

   
bug
Something isn't working

  
contract
Run the tool-contract suite on this PR

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
needs-human

   
needs-input
Intake asked the human a question on the issue; waiting for the answer

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
agent-ready
bug
contract
documentation
duplicate
enhancement
good first issue
help wanted
invalid
needs-human
needs-input
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
iterative-works/iw-cli!647
No description provided.