Phase 1: The session join attaches without checking for a terminal, and reports tmux's refusal as a command failure #686

Merged

claude merged 7 commits from IW-599-phase-01 into IW-599 2026-10-03 00:31:34 +00:00

Conversation 0 Commits 7 Files changed 20 +412 -52

claude commented 2026-10-02 23:51:42 +00:00

Member

Copy link

Phase 01 implementation for IW-599.

Files

Browse changed files: https://code.iterative.works/iterative-works/iw-cli/-/blob/IW-599-phase-01/

Phase 01 implementation for IW-599. ### Files Browse changed files: https://code.iterative.works/iterative-works/iw-cli/-/blob/IW-599-phase-01/

claude added 5 commits 2026-10-02 23:51:43 +00:00

chore(IW-599): update review-state for phase 01 c3a5b46aae

phase(IW-599): phase 01 implementation, before code review ... c1aafce065

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Do not attach when standard input is not a terminal ... 146c094d11

- Stdin.isTerminal capability, live check through sh -c 'test -t 0'
- WorkspaceSession.join prints the attach command and returns ok when stdin is not a terminal
- Harness regression tests and BATS exit-status assertions, plus a pty test for the attach branch

docs(IW-599): follow-up for the phase-pr push timeout ... 3a504720a6

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(IW-599): state the phase-pr push follow-up as evidence only ... 230ceda646

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

mph added 1 commit 2026-10-02 23:52:41 +00:00

chore(IW-599): update review-state for phase 01 17deccc00b

mph added 1 commit 2026-10-03 00:13:44 +00:00

fix(test): give the attach test a terminal type tmux accepts ... 83f512eed3

CI runs with TERM unset or dumb, so tmux refused to attach the pty that
script(1) provides: "terminal does not support clear".

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude merged commit 93a319b71c into IW-599 2026-10-03 00:31:34 +00:00

claude deleted branch IW-599-phase-01 2026-10-03 00:31:34 +00:00

claude referenced this pull request from a commit 2026-10-03 00:31:34 +00:00

Phase 1: The session join attaches without checking for a terminal, and reports tmux's refusal as a command failure (#686)

claude referenced this pull request 2026-10-03 00:33:49 +00:00

IW-599: start and open exit 0 without a terminal instead of failing the attach #688

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

agent-ready

  

bug

Something isn't working

  

contract

Run the tool-contract suite on this PR

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

needs-human

  

needs-input

Intake asked the human a question on the issue; waiting for the answer

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

agent-ready

bug

contract

documentation

duplicate

enhancement

good first issue

help wanted

invalid

needs-human

needs-input

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

iterative-works/iw-cli!686

No description provided.