IW-599: start and open exit 0 without a terminal instead of failing the attach #688

Merged

mph merged 14 commits from IW-599 into main 2026-10-06 21:15:12 +00:00

Conversation 0 Commits 14 Files changed 24 +1177 -36

claude commented 2026-10-03 00:33:49 +00:00

Member

Copy link

Summary

iw start and iw open no longer exit non-zero when standard input is not a terminal (CI container, agent shell). Before, they did all their work, then tried tmux attach, tmux refused, and the command reported exit 1.

Now the session join checks for a terminal first. With no terminal it prints that the session is ready, why it does not attach, and the command to attach with, and exits 0. With a terminal, and inside a workspace, the behaviour is unchanged. The --prompt path with no terminal still exits 5.

Defects fixed

• Phase 1 (#686): The session join attaches without checking for a terminal, and reports tmux's refusal as a command failure.
  • Root cause: WorkspaceSession.join called env.workspace.attach with no terminal check, and entered mapped the refusal to CommandResult.error.
  • Fix: Stdin.isTerminal capability (live probe: test -t 0 with inherited stdin); join guards only the attach branch.

Testing

• Unit: 5 new cases in WorkspaceSessionTest, 1 each in StartHarnessTest and OpenHarnessTest.
• E2E: start.bats, open.bats, open-prompt.bats, start-prompt.bats, analyze.bats now run with </dev/null and assert the exit status (the old workaround comment in start.bats is gone). A new pty test in open.bats (script -qec) covers the live probe returning true; a mutation check turned it red.
• Phase PR CI was green.

Follow-ups filed

• #687 — an attached session is killed after 5 minutes (attach runs under the default process timeout).
• #585 — comment added: another phase-pr push failure that matches the push timeout pattern.

Release notes

See project-management/issues/IW-599/release-notes.md (Czech).

Closes #599

🤖 Generated with Claude Code

## Summary `iw start` and `iw open` no longer exit non-zero when standard input is not a terminal (CI container, agent shell). Before, they did all their work, then tried `tmux attach`, tmux refused, and the command reported exit 1. Now the session join checks for a terminal first. With no terminal it prints that the session is ready, why it does not attach, and the command to attach with, and exits 0. With a terminal, and inside a workspace, the behaviour is unchanged. The `--prompt` path with no terminal still exits 5. ## Defects fixed - **Phase 1 (#686):** The session join attaches without checking for a terminal, and reports tmux's refusal as a command failure. - Root cause: `WorkspaceSession.join` called `env.workspace.attach` with no terminal check, and `entered` mapped the refusal to `CommandResult.error`. - Fix: `Stdin.isTerminal` capability (live probe: `test -t 0` with inherited stdin); `join` guards only the attach branch. ## Testing - Unit: 5 new cases in `WorkspaceSessionTest`, 1 each in `StartHarnessTest` and `OpenHarnessTest`. - E2E: `start.bats`, `open.bats`, `open-prompt.bats`, `start-prompt.bats`, `analyze.bats` now run with `</dev/null` and assert the exit status (the old workaround comment in `start.bats` is gone). A new pty test in `open.bats` (`script -qec`) covers the live probe returning `true`; a mutation check turned it red. - Phase PR CI was green. ## Follow-ups filed - #687 — an attached session is killed after 5 minutes (attach runs under the default process timeout). - #585 — comment added: another `phase-pr` push failure that matches the push timeout pattern. ## Release notes See `project-management/issues/IW-599/release-notes.md` (Czech). Closes #599 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude added 13 commits 2026-10-03 00:33:49 +00:00

workflow(dx): Create diagnostic analysis for IW-599 ... 7481eddb01

start and open try to attach without a TTY and fail, so a BATS test cannot assert their exit status

Artifacts:
- analysis.md
- issue.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-599): update review-state to tasks_ready 2bc7e12e70

workflow(dx): Create task index for IW-599 ... 70fe8266cc

start and open try to attach without a TTY and fail, so a BATS test cannot assert their exit status

Artifacts:
- tasks.md
- review-state.json (tasks_ready)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(IW-599): intake verdict — agent-ready ... 93724017ef

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Phase 1: context ready ... 78bee2866d

Issue: IW-599
Phase: 1 - The session join attaches without checking for a terminal, and reports tmux's refusal as a command failure

This commit marks the checkpoint for phase 1 context generation.
Use dx-fix IW-599 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-599): update review-state to context_ready 9823f0d556

workflow(dx): Generate Phase 1 tasks for IW-599 ... 08ca73ccb7

The session join attaches without checking for a terminal, and reports tmux's refusal as a command failure

Artifacts:
- phase-01-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-599): update review-state to tasks_ready 677220709c

Phase 1: The session join attaches without checking for a terminal, and reports tmux's refusal as a command failure (#686) 93a319b71c

chore(IW-599): update review-state for phase 01 9f5df171b3

chore(IW-599): mark phase 01 complete in tasks.md 00a145e74d

chore(IW-599): file follow-ups to the tracker ... 29df1cb18f

Filed as #687; the push timeout went to #585 as a comment.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(IW-599): add release notes ... d24d9a1eef

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

mph added 1 commit 2026-10-03 00:34:53 +00:00

chore(IW-599): update review-state to all_complete 2a1a92c441

mph merged commit 33042e126c into main 2026-10-06 21:15:12 +00:00

mph referenced this pull request from a commit 2026-10-06 21:15:12 +00:00

Merge pull request 'IW-599: start and open exit 0 without a terminal instead of failing the attach' (#688) from IW-599 into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

agent-ready

  

bug

Something isn't working

  

contract

Run the tool-contract suite on this PR

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

needs-human

  

needs-input

Intake asked the human a question on the issue; waiting for the answer

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

agent-ready

bug

contract

documentation

duplicate

enhancement

good first issue

help wanted

invalid

needs-human

needs-input

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

iterative-works/iw-cli!688

No description provided.