IW-612: phase-advance writes the shared merged card #697

Merged

mph merged 21 commits from IW-612 into main 2026-10-07 07:31:30 +00:00

Conversation 2 Commits 21 Files changed 16 +1036 -9

claude commented 2026-10-03 05:18:01 +00:00

Member

Copy link

Summary

iw phase-advance now writes the merged-phase review-state card through PhaseMergedCard.update, the same function that phase-merge and phase-pr --batch use. The hand-built copy of the card in PhaseAdvance.maybeUpdateReviewState is gone, so the three writers cannot disagree.

Changes

• core/commands/PhaseAdvance.scala: call PhaseMergedCard.update(phase) instead of a hand-built UpdateInput.
• core/commands/PhaseMergedCard.scala: PURPOSE line names all three callers.
• core/test/PhaseAdvanceHarnessTest.scala: tests for the two intended behavior changes.

Behavior change after phase-advance (intended, see analysis):

1. needs_attention is false.
2. ci_wait_started and ci_wait_sha are removed, so the next phase's CI gate does not read a stale wait start.

Status, display, badges, message and the commit message do not change.

Testing

• Harness tests in PhaseAdvanceHarnessTest (needs_attention cleared, CI-wait fields cleared).
• Phase PR #696 passed CI on the full suite.

Review packet: project-management/issues/IW-612/review-packet.md

Release notes

Uzavření fáze po sloučení už nenechává na nástěnce falešné upozornění. Dokončená fáze je po posunu větve vedena jako hotová a nežádá o pozornost, a z karty zmizí záznam o čekání na kontrolu sestavení, který mohl zmást kontrolu následující fáze. Všechny cesty uzavření fáze nyní zapisují kartu stejně.

🤖 Generated with Claude Code

Closes #612

## Summary `iw phase-advance` now writes the merged-phase review-state card through `PhaseMergedCard.update`, the same function that `phase-merge` and `phase-pr --batch` use. The hand-built copy of the card in `PhaseAdvance.maybeUpdateReviewState` is gone, so the three writers cannot disagree. ## Changes - `core/commands/PhaseAdvance.scala`: call `PhaseMergedCard.update(phase)` instead of a hand-built `UpdateInput`. - `core/commands/PhaseMergedCard.scala`: PURPOSE line names all three callers. - `core/test/PhaseAdvanceHarnessTest.scala`: tests for the two intended behavior changes. Behavior change after `phase-advance` (intended, see analysis): 1. `needs_attention` is `false`. 2. `ci_wait_started` and `ci_wait_sha` are removed, so the next phase's CI gate does not read a stale wait start. Status, display, badges, message and the commit message do not change. ## Testing - Harness tests in `PhaseAdvanceHarnessTest` (needs_attention cleared, CI-wait fields cleared). - Phase PR #696 passed CI on the full suite. Review packet: `project-management/issues/IW-612/review-packet.md` ## Release notes Uzavření fáze po sloučení už nenechává na nástěnce falešné upozornění. Dokončená fáze je po posunu větve vedena jako hotová a nežádá o pozornost, a z karty zmizí záznam o čekání na kontrolu sestavení, který mohl zmást kontrolu následující fáze. Všechny cesty uzavření fáze nyní zapisují kartu stejně. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Closes #612

claude added 12 commits 2026-10-03 05:18:01 +00:00

workflow(wf): Create analysis for IW-612 ... 13c2996647

PhaseAdvance.maybeUpdateReviewState repeats the PhaseMergedCard shape instead of calling PhaseMergedCard.update

Artifacts:
- analysis.md
- issue.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-612): update review-state to tasks_ready 6d3e67f749

workflow(wf): Create task index for IW-612 ... bf743dce3a

PhaseAdvance.maybeUpdateReviewState repeats the PhaseMergedCard shape instead of calling PhaseMergedCard.update

Artifacts:
- tasks.md
- review-state.json (tasks_ready)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(IW-612): intake verdict — agent-ready ... 064a49f142

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Phase 1: context ready ... 7440e87c8d

Issue: IW-612
Phase: 1 - phase-advance writes the shared merged card

This commit marks the checkpoint for phase 1 context generation.
Use wf-implement IW-612 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-612): update review-state to context_ready 45192ff7a7

workflow(wf): Generate Phase 1 tasks for IW-612 ... f010d0c1ec

phase-advance writes the shared merged card

Artifacts:
- phase-01-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-612): update review-state to tasks_ready 53e8ecc79a

Phase 1: phase-advance writes the shared merged card (#696) 0323293934

chore(IW-612): update review-state for phase 01 d091c08998

chore(IW-612): mark phase 01 complete in tasks.md 9181333e59

docs(IW-612): add review packet and release notes ... a5dc419c81

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

mph added 1 commit 2026-10-03 05:19:05 +00:00

chore(IW-612): update review-state to all_complete 909f486186

mph requested changes 2026-10-06 21:17:57 +00:00

mph left a comment

Copy link

We have conflicts.

We have conflicts.

mph added 1 commit 2026-10-06 22:03:04 +00:00

Merge remote-tracking branch 'origin/main' into IW-612 ... fadfa7beb2

# Conflicts:
#	core/commands/PhaseAdvance.scala

mph added 1 commit 2026-10-06 22:44:24 +00:00

docs(IW-612): rework for final PR review 15 3b8d0fde02

mph added 3 commits 2026-10-06 22:46:41 +00:00

chore(IW-612): move review-state card out of the tree 211cb70e58

Phase 2: context ready ... d6018e2751

Issue: IW-612
Phase: 2 - Rework for final PR review 15

This commit marks the checkpoint for phase 2 context generation.
Use wf-implement IW-612 to return to this point.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

workflow(wf): Generate Phase 2 tasks for IW-612 ... bb543aaa37

Rework for final PR review 15

Artifacts:
- phase-02-tasks.md

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude added 1 commit 2026-10-06 22:50:25 +00:00

Phase 2: Rework for final PR review 15 (#727) a29cfe9c4d

mph added 2 commits 2026-10-06 22:52:43 +00:00

chore(IW-612): mark phase 02 complete in tasks.md 9f7318ff85

docs(IW-612): regenerate review packet and release notes after phase 2 ... b7f3d0066e

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude commented 2026-10-06 22:53:15 +00:00

Author

Member

Copy link

Implement: rework for review 15
The rework phase merged into IW-612 through #727; this pull request carries it.

Implement: rework for review 15 The rework phase merged into IW-612 through #727; this pull request carries it.

mph merged commit 84f29fc9be into main 2026-10-07 07:31:30 +00:00

mph referenced this pull request from a commit 2026-10-07 07:31:32 +00:00

Merge pull request 'IW-612: phase-advance writes the shared merged card' (#697) from IW-612 into main

Sign in to join this conversation.

Reviewers

No reviewers

mph

Labels

Clear labels   

agent-ready

  

bug

Something isn't working

  

contract

Run the tool-contract suite on this PR

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

needs-human

  

needs-input

Intake asked the human a question on the issue; waiting for the answer

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

agent-ready

bug

contract

documentation

duplicate

enhancement

good first issue

help wanted

invalid

needs-human

needs-input

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

iterative-works/iw-cli!697

No description provided.