Small fixes: core #707

New issue

Closed

opened 2026-10-04 14:12:06 +00:00 by claude · 2 comments

claude commented

2026-10-04 14:12:06 +00:00

Member

Collector for small fixes in the core module (filed from IW-702 follow-ups).

Move the WorktreeGitDir tests out of core/test/ServiceDeclarationTest.scala into their own WorktreeGitDirTest.scala (the class name does not say what they test).
ReviewStateWrite.tryUpdate prints Error: Warning: Failed to update review-state: ...; the doubled prefix predates IW-702 (ReviewStateMove prints Warning: ...). — core/commands/ReviewStateWrite.scala
core/commands/CiGate.scala: the doc comment of CiGate.poll sits above startOfWait (it predates IW-702), so poll has no doc comment and startOfWait has two.

Collector for small fixes in the `core` module (filed from IW-702 follow-ups). - [ ] Move the `WorktreeGitDir` tests out of `core/test/ServiceDeclarationTest.scala` into their own `WorktreeGitDirTest.scala` (the class name does not say what they test). - [ ] `ReviewStateWrite.tryUpdate` prints `Error: Warning: Failed to update review-state: ...`; the doubled prefix predates IW-702 (`ReviewStateMove` prints `Warning: ...`). — `core/commands/ReviewStateWrite.scala` - [ ] `core/commands/CiGate.scala`: the doc comment of `CiGate.poll` sits above `startOfWait` (it predates IW-702), so `poll` has no doc comment and `startOfWait` has two.

mph referenced this issue from a commit

2026-10-04 14:14:37 +00:00

chore(IW-702): file follow-ups (#706, #707, #708, dev-docs#439)

claude referenced this issue

2026-10-04 14:14:47 +00:00

IW-702: Keep the review-state card out of version control #709

claude commented

2026-10-05 20:06:05 +00:00

Author

Member

From IW-718 follow-ups:

Card writes are not crash-atomic: LiveCommandEnv.fs.write uses os.write.over with no temp file and rename, so a crash during the write can leave a partial card. — core/commands/LiveCommandEnv.scala:91-95

From IW-718 follow-ups: - [ ] Card writes are not crash-atomic: `LiveCommandEnv.fs.write` uses `os.write.over` with no temp file and rename, so a crash during the write can leave a partial card. — `core/commands/LiveCommandEnv.scala:91-95`

mph referenced this issue from a commit

2026-10-05 20:07:42 +00:00

chore(IW-718): file follow-ups, add review packet

claude referenced this issue

2026-10-05 20:07:54 +00:00

IW-718: review-state update --drop-checkpoints-after N #722

claude commented

2026-10-07 00:00:19 +00:00

Author

Member

Intake: agent-ready
Workflow: waterfall
Reason: all gates passed
Analysis: project-management/issues/IW-707/analysis.md on branch IW-707

Intake: agent-ready Workflow: waterfall Reason: all gates passed Analysis: project-management/issues/IW-707/analysis.md on branch IW-707