Phase 8: Generated docs and skill #539

Merged

mph merged 7 commits from IW-463-phase-08 into IW-463 2026-09-07 08:35:47 +00:00

Conversation 0 Commits 7 Files changed 63 +3280 -680

mph commented 2026-09-06 23:14:01 +00:00

Owner

Copy link

Phase 08 implementation for IW-463.

Files

Browse changed files: https://code.iterative.works/iterative-works/iw-cli/-/blob/IW-463-phase-08/

Phase 08 implementation for IW-463. ### Files Browse changed files: https://code.iterative.works/iterative-works/iw-cli/-/blob/IW-463-phase-08/

mph added 4 commits 2026-09-06 23:14:01 +00:00

chore(IW-463): update review-state for phase 08 2aeff8f2e0

docs(IW-463): split review-state and rm documentation into generated page + companion ... 1700224bd6

Moves everything docs/commands/review-state.md and docs/commands/rm.md carry
that no CommandDeclaration can express — the schema contract, backward
compatibility, common workflows, troubleshooting, what `rm` refuses beyond its
exit codes, and the dashboard's Remove control — into two new companion pages
at docs/ root: docs/review-state-cards.md and docs/worktree-removal.md.

Committed on its own, before either docs/commands/ page is regenerated
(Phase 8 Step 3, Risks 2's containment): a single commit that both moved prose
and regenerated a page would hide any loss it caused. Nothing is deleted here;
the two docs/commands/ pages and their README.md links are re-pointed in the
next commit, once these companions exist to receive the content leaving them.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WehHdHp9MRKJkrhGFiKNxa

Generated docs and skill ... 8cea0acbac

- iw command-docs writes docs/commands/ from the declaration registry; --check gates drift
- review-state.md and rm.md are generated; their unexpressible prose moved to companions first
- build-iw-cli-skills reads the registry: its roster, categories, exclusion and Known-State block deleted
- a docs/commands/* arm in change-scope.sh makes a hand edit to a generated page pay the code gate
- two review iterations closed 5 criticals; the symlink write path is guarded behind CommandEnv

chore(IW-463): register phase 8 review artifacts c888dcaf22

mph added 1 commit 2026-09-07 04:36:23 +00:00

fix(dashboard): close() waits for the poll in flight ... f48fd685c4

IssuePoller.close() called shutdownNow() and returned, so the poller
thread could still be inside a write while the caller deleted what it
had written. IssuePollerTest's tempDir fixture does exactly that, which
is why CI failed with DirectoryNotEmptyException on a run whose diff
touched no dashboard code.

close() now follows shutdownNow() with a bounded awaitTermination, so
"closed" means the poller has let go of its files. The bound keeps a
wedged poll from holding a shutdown open; an interrupt during the wait
restores the interrupt flag.

The test pins the guarantee: a poll that rides out its interrupt must
have finished by the time close() returns. It fails against the old
body.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WehHdHp9MRKJkrhGFiKNxa

mph added 1 commit 2026-09-07 07:51:04 +00:00

fix(dashboard): a started server can be stopped ... 6325d59d69

CaskServer.start ran a server and returned nothing, so nothing could
stop one. Every test in CaskServerTest leaked a running server with two
live pollers, and each test's finally deleted the state directory those
pollers were still writing — which is why CI failed with
DirectoryNotEmptyException on a run whose diff touched no dashboard code.

start now returns a RunningServer that stops the listener and closes the
server; close() closes both pollers. PullRequestPoller.close() gained the
same bounded awaitTermination IssuePoller.close() has, so closing a
server means both its writers have let go.

CaskServerTest records each server by the state path it writes and stops
it at the head of every teardown, before anything is deleted. The other
three call sites discard the handle explicitly.

The PullRequestPoller test fails against the old close(): a poll that
rides out its interrupt must have finished by the time close() returns.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01WehHdHp9MRKJkrhGFiKNxa

mph added 1 commit 2026-09-07 08:14:06 +00:00

chore(IW-463): update review-state for phase 08 b2e31c075e

mph merged commit c28cac71d5 into IW-463 2026-09-07 08:35:47 +00:00

mph deleted branch IW-463-phase-08 2026-09-07 08:35:47 +00:00

mph referenced this pull request from a commit 2026-09-07 08:35:48 +00:00

Merge pull request 'Phase 8: Generated docs and skill' (#539) from IW-463-phase-08 into IW-463

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

agent-ready

  

bug

Something isn't working

  

contract

Run the tool-contract suite on this PR

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

needs-human

  

needs-input

Intake asked the human a question on the issue; waiting for the answer

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

agent-ready

bug

contract

documentation

duplicate

enhancement

good first issue

help wanted

invalid

needs-human

needs-input

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

iterative-works/iw-cli!539

No description provided.