IW-616: Shutdown-safe ProcessAdapter.run #618

Merged

mph merged 12 commits from IW-616 into main 2026-09-25 05:19:22 +00:00

Conversation 0 Commits 12 Files changed 14 +994 -3

claude commented 2026-09-24 19:57:48 +00:00

Member

Copy link

Summary

ProcessAdapter.run gets a destroyOnExit: Boolean = true parameter, passed to os.proc(...).call. With destroyOnExit = false, a caller (for example a shutdown hook) can spawn a process while the JVM shuts down. The default stays true, so no current caller changes behavior.

Changes

• core/adapters/Process.scala — new destroyOnExit parameter and Scaladoc.
• core/test/ShutdownSpawnProbe.scala — probe main that spawns git from a shutdown hook.
• core/test/ProcessTest.scala — two forked-JVM tests: default path throws during shutdown; destroyOnExit = false succeeds.
• docs/api/Process.md — documents the parameter.

Testing

• Phase 1 PR #617 passed CI (full suite).
• Unit: the two forked-JVM tests in ProcessTest; the existing run tests are unchanged.
• No CLI command changed, so no BATS change.

Review packet: project-management/issues/IW-616/review-packet.md

Release notes

Bezpečnější spouštění příkazů při ukončování procesu — nástroje postavené na iw-cli teď mohou spustit příkaz i ve chvíli, kdy jejich proces končí, pokud si to vyžádají (destroyOnExit = false). Výchozí chování se nemění. Viz project-management/issues/IW-616/release-notes.md.

🤖 Generated with Claude Code

Closes #616

## Summary `ProcessAdapter.run` gets a `destroyOnExit: Boolean = true` parameter, passed to `os.proc(...).call`. With `destroyOnExit = false`, a caller (for example a shutdown hook) can spawn a process while the JVM shuts down. The default stays `true`, so no current caller changes behavior. ## Changes - `core/adapters/Process.scala` — new `destroyOnExit` parameter and Scaladoc. - `core/test/ShutdownSpawnProbe.scala` — probe main that spawns `git` from a shutdown hook. - `core/test/ProcessTest.scala` — two forked-JVM tests: default path throws during shutdown; `destroyOnExit = false` succeeds. - `docs/api/Process.md` — documents the parameter. ## Testing - Phase 1 PR #617 passed CI (full suite). - Unit: the two forked-JVM tests in `ProcessTest`; the existing `run` tests are unchanged. - No CLI command changed, so no BATS change. Review packet: `project-management/issues/IW-616/review-packet.md` ## Release notes Bezpečnější spouštění příkazů při ukončování procesu — nástroje postavené na iw-cli teď mohou spustit příkaz i ve chvíli, kdy jejich proces končí, pokud si to vyžádají (`destroyOnExit = false`). Výchozí chování se nemění. Viz `project-management/issues/IW-616/release-notes.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Closes #616

claude added 11 commits 2026-09-24 19:57:48 +00:00

workflow(wf): Create analysis for IW-616 ... f40aa254b3

ProcessAdapter.run cannot spawn during JVM shutdown, so no recovery step can reach git

Artifacts:
- analysis.md
- issue.md

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-616): update review-state to tasks_ready ddf10e5107

workflow(wf): Create task index for IW-616 ... 2fb1e910b1

ProcessAdapter.run cannot spawn during JVM shutdown, so no recovery step can reach git

Artifacts:
- tasks.md
- review-state.json (tasks_ready)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Phase 1: context ready ... f52b7c18a1

Issue: IW-616
Phase: 1 - Shutdown-safe ProcessAdapter.run

This commit marks the checkpoint for phase 1 context generation.
Use wf-implement IW-616 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-616): update review-state to context_ready f0a70ed681

workflow(wf): Generate Phase 1 tasks for IW-616 ... 257dae2996

Shutdown-safe ProcessAdapter.run

Artifacts:
- phase-01-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-616): update review-state to tasks_ready 45bbd41b68

Phase 1: Shutdown-safe ProcessAdapter.run (#617) 1e22e77d4c

chore(IW-616): update review-state for phase 01 a63eabef23

chore(IW-616): mark phase 01 complete in tasks.md f5d6626cdd

docs(IW-616): add review packet for final PR ... 8a598d2a3c

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

mph added 1 commit 2026-09-24 19:58:51 +00:00

chore(IW-616): update review-state to all_complete 69f98518cb

mph merged commit 151e305d96 into main 2026-09-25 05:19:22 +00:00

mph referenced this pull request from a commit 2026-09-25 05:19:22 +00:00

Merge pull request 'IW-616: Shutdown-safe ProcessAdapter.run' (#618) from IW-616 into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

agent-ready

  

bug

Something isn't working

  

contract

Run the tool-contract suite on this PR

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

needs-human

  

needs-input

Intake asked the human a question on the issue; waiting for the answer

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

agent-ready

bug

contract

documentation

duplicate

enhancement

good first issue

help wanted

invalid

needs-human

needs-input

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

iterative-works/iw-cli!618

No description provided.