iterative-works/iw-cli

Watch

Fork 0

IW-552: A flag value beginning with a double dash is refused as missing #788

Open

claude wants to merge 21 commits from IW-552 into main

claude commented

2026-10-11 04:06:41 +00:00

Member

Summary

A value-taking flag followed by a token that starts with -- was refused as "requires a value", although the value was given. iw issue create --title T --description "--max-turns ..." failed this way; IW-610 hit the same with review-state update --display-subtext "--comments command".

Defects fixed

Phase 1 (#787): Rejection.MissingValue conflated "no value was given" with "a value was given but is flag-shaped". The parser now has Rejection.FlagShapedValue(name, token). When the next token is not a flag of this command (and not --help), the refusal names the token and shows the inline form --flag='<token>' that passes it. When the next token is a declared flag of the command or --help, the refusal stays "requires a value" with no inline hint (option a, as answered on the issue). The rule that a -- token is never taken as a separate value is unchanged.

Testing

CommandArgParserTest: 7 tests for both rejection shapes (single and repeated flags, inline declared flag, --help).
HelpTest: two-line rendering of the new rejection.
IssueHarnessTest: issue create with a flag-shaped description asserts the new message, exit 1, no tracker call.
Mutation check: reverting the new branch fails exactly the new tests.
CI green on the phase PR.

Release notes

See project-management/issues/IW-552/release-notes.md (Czech).

Closes #552

🤖 Generated with Claude Code

## Summary A value-taking flag followed by a token that starts with `--` was refused as "requires a value", although the value was given. `iw issue create --title T --description "--max-turns ..."` failed this way; IW-610 hit the same with `review-state update --display-subtext "--comments command"`. ## Defects fixed - **Phase 1 (#787):** `Rejection.MissingValue` conflated "no value was given" with "a value was given but is flag-shaped". The parser now has `Rejection.FlagShapedValue(name, token)`. When the next token is not a flag of this command (and not `--help`), the refusal names the token and shows the inline form `--flag='<token>'` that passes it. When the next token is a declared flag of the command or `--help`, the refusal stays "requires a value" with no inline hint (option a, as answered on the issue). The rule that a `--` token is never taken as a separate value is unchanged. ## Testing - `CommandArgParserTest`: 7 tests for both rejection shapes (single and repeated flags, inline declared flag, `--help`). - `HelpTest`: two-line rendering of the new rejection. - `IssueHarnessTest`: `issue create` with a flag-shaped description asserts the new message, exit 1, no tracker call. - Mutation check: reverting the new branch fails exactly the new tests. - CI green on the phase PR. ## Release notes See `project-management/issues/IW-552/release-notes.md` (Czech). Closes #552 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude added 14 commits

2026-10-11 04:06:41 +00:00

workflow(dx): Create diagnostic analysis for IW-552 d79bcbbe84

A flag value beginning with a double dash cannot be passed, and the refusal
reports it as missing

Artifacts:
- analysis.md

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011M2HjEYoJpcfD43KYP6zxt

workflow(dx): Record analysis_ready review state for IW-552 38683d159a

Artifacts:
- review-state.json

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011M2HjEYoJpcfD43KYP6zxt

workflow(dx): Create task index for IW-552 2a0657a28b

A flag value beginning with a double dash cannot be passed, and the refusal
reports it as missing

Artifacts:
- tasks.md
- review-state.json (tasks_ready)

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011M2HjEYoJpcfD43KYP6zxt

docs(IW-552): intake verdict — needs-human d3c2d0a9de

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011M2HjEYoJpcfD43KYP6zxt

Merge remote-tracking branch 'origin/main' into IW-552 913883671e

docs(IW-552): apply the answers from the issue b1e2eedde4

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018fPBZaKwU97SaaHzVo3ePq

chore(IW-552): move review-state card out of the tree b14e8835d9

workflow(dx): Create task index for IW-552 96419cc142

A flag value beginning with a double dash cannot be passed, and the refusal reports it as missing

Artifacts:
- tasks.md
- issue.md

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018fPBZaKwU97SaaHzVo3ePq

docs(IW-552): intake verdict — agent-ready 1c5c1404ea

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018fPBZaKwU97SaaHzVo3ePq

Phase 1: context ready b85450b2a8

Issue: IW-552
Phase: 1 - Rejection.MissingValue conflates "no value was given" with "a value was given but is flag-shaped"

This commit marks the checkpoint for phase 1 context generation.
Use dx-fix IW-552 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

workflow(dx): Generate Phase 1 tasks for IW-552 aeb6e7903c

Rejection.MissingValue conflates "no value was given" with "a value was given but is flag-shaped"

Artifacts:
- phase-01-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Phase 1: Rejection.MissingValue conflates "no value was given" with "a value was given but is flag-shaped" (#787 ) b5d61b4789

chore(IW-552): mark phase 01 complete in tasks.md f7557db9c8

docs(IW-552): release notes

CI / changes (pull_request) Successful in 5s

Details

CI / contract (pull_request) Has been skipped

Details

CI / format (pull_request) Successful in 10s

Details

CI / lint (pull_request) Successful in 12s

Details

CI / compile (pull_request) Successful in 1m44s

Details

CI / dashboard-build (pull_request) Successful in 1m29s

Details

CI / test (pull_request) Successful in 19m34s

Details

9b37b6a4ba

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

mph requested changes

2026-10-11 07:08:53 +00:00

mph left a comment

Conflicting files

mph added 1 commit

2026-10-15 13:01:17 +00:00

docs(IW-552): rework for final PR review 24

CI / contract (pull_request) Has been skipped

Details

CI / changes (pull_request) Successful in 4s

Details

CI / compile (pull_request) Successful in 1m4s

Details

CI / format (pull_request) Successful in 10s

Details

CI / lint (pull_request) Successful in 12s

Details

CI / dashboard-build (pull_request) Has been cancelled

Details

CI / test (pull_request) Has been cancelled

Details

7ddf0c9f87

mph added 2 commits

2026-10-15 13:05:18 +00:00

Phase 2: context ready 8107688da3

Issue: IW-552
Phase: 2 - Rework for final PR review 24

This commit marks the checkpoint for phase 2 context generation.
Use dx-fix IW-552 to return to this point.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

workflow(dx): Generate Phase 2 tasks for IW-552

CI / changes (pull_request) Successful in 5s

Details

CI / contract (pull_request) Has been skipped

Details

CI / compile (pull_request) Successful in 1m7s

Details

CI / format (pull_request) Successful in 10s

Details

CI / lint (pull_request) Successful in 10s

Details

CI / dashboard-build (pull_request) Successful in 2m5s

Details

CI / test (pull_request) Successful in 20m22s

Details

3e74dcb739

Rework for final PR review 24

Artifacts:
- phase-02-tasks.md

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude added 1 commit

2026-10-15 13:38:48 +00:00

Phase 2: Rework for final PR review 24 (#800 )

CI / changes (pull_request) Successful in 4s

Details

CI / contract (pull_request) Has been skipped

Details

CI / format (pull_request) Successful in 11s

Details

CI / lint (pull_request) Successful in 11s

Details

CI / compile (pull_request) Successful in 1m4s

Details

CI / dashboard-build (pull_request) Successful in 1m29s

Details

CI / test (pull_request) Has been cancelled

Details

249f468a38

mph added 3 commits

2026-10-15 13:44:33 +00:00

chore(IW-552): mark phase 02 complete in tasks.md 53f4b913d3

chore(IW-552): file follow-up on #598 6fd4a09510

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Merge origin/main into IW-552

CI / changes (pull_request) Successful in 5s

Details

CI / contract (pull_request) Has been skipped

Details

CI / compile (pull_request) Successful in 1m5s

Details

CI / format (pull_request) Successful in 10s

Details

CI / lint (pull_request) Successful in 11s

Details

CI / dashboard-build (pull_request) Successful in 1m25s

Details

CI / test (pull_request) Successful in 19m14s

Details

9cec329203

Restores the main ancestry that the squash merge of #800 dropped
(see #750). The tree is identical to the parent on IW-552.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude commented

2026-10-15 13:45:23 +00:00

Author

Member

Implement: rework for review 24
The rework phase merged into IW-552 through #800; this pull request carries it.

Implement: rework for review 24 The rework phase merged into IW-552 through #800; this pull request carries it.

claude requested review from mph

2026-10-16 17:18:48 +00:00

CI / changes (pull_request) Successful in 5s

Details

CI / contract (pull_request) Has been skipped

Details

CI / compile (pull_request) Successful in 1m5s

Details

CI / format (pull_request) Successful in 10s

Details

CI / lint (pull_request) Successful in 11s

Details

CI / dashboard-build (pull_request) Successful in 1m25s

Details

CI / test (pull_request) Successful in 19m14s

Details

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin IW-552:IW-552

git switch IW-552

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff IW-552

git switch IW-552

git rebase main

git switch main

git merge --ff-only IW-552

git switch IW-552

git rebase main

git switch main

git merge --no-ff IW-552

git switch main

git merge --squash IW-552