IW-707: Small fixes: core #768

Merged

mph merged 18 commits from IW-707 into main 2026-10-10 21:36:52 +00:00

Conversation 2 Commits 18 Files changed 29 +1575 -137

claude commented 2026-10-08 06:47:56 +00:00

Member

Copy link

Summary

Collector of small fixes in the core module (IW-707), done in one phase (#766).

Changes

• Atomic file writes. LiveFileSystem.write and ReviewStateAdapter.writeFile now write through AtomicFile.write (temp file in the same directory, then atomic move). A crash or full disk during a write leaves the old file, never a partial one. The helper is moved out of WorktreeServices, which now uses it too.
• Warning prefix. Four stderr warnings printed Error: Warning: ...; they now print Warning: ... (ReviewStateWrite, two in CiGate, PhaseIndexSync).
• Doc comment. The Scaladoc of CiGate.poll was above startOfWait; it is now on poll.
• Test move. The WorktreeGitDir tests move from ServiceDeclarationTest.scala to WorktreeGitDirTest.scala; the PURPOSE header is corrected.

Testing

• New AtomicFileTest, plus tests for the warning text in CiGateHarnessTest, PhaseAdvanceHarnessTest and ReviewStateAdapterTest.
• Pre-push hook on the final commit: core compile with warnings as errors, scalafix, core unit tests, all commands compile — passed.

Follow-ups

• #767 — consolidate the remaining state-file writers on one atomic helper and state its contract.
• Comment on #762 — shared assertWarned test helper.

Release notes

See project-management/issues/IW-707/release-notes.md. Review packet: project-management/issues/IW-707/review-packet.md.

🤖 Generated with Claude Code

Closes #707

## Summary Collector of small fixes in the `core` module (IW-707), done in one phase (#766). ## Changes - **Atomic file writes.** `LiveFileSystem.write` and `ReviewStateAdapter.writeFile` now write through `AtomicFile.write` (temp file in the same directory, then atomic move). A crash or full disk during a write leaves the old file, never a partial one. The helper is moved out of `WorktreeServices`, which now uses it too. - **Warning prefix.** Four stderr warnings printed `Error: Warning: ...`; they now print `Warning: ...` (`ReviewStateWrite`, two in `CiGate`, `PhaseIndexSync`). - **Doc comment.** The Scaladoc of `CiGate.poll` was above `startOfWait`; it is now on `poll`. - **Test move.** The `WorktreeGitDir` tests move from `ServiceDeclarationTest.scala` to `WorktreeGitDirTest.scala`; the PURPOSE header is corrected. ## Testing - New `AtomicFileTest`, plus tests for the warning text in `CiGateHarnessTest`, `PhaseAdvanceHarnessTest` and `ReviewStateAdapterTest`. - Pre-push hook on the final commit: core compile with warnings as errors, scalafix, core unit tests, all commands compile — passed. ## Follow-ups - #767 — consolidate the remaining state-file writers on one atomic helper and state its contract. - Comment on #762 — shared `assertWarned` test helper. ## Release notes See `project-management/issues/IW-707/release-notes.md`. Review packet: `project-management/issues/IW-707/review-packet.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Closes #707

claude added 10 commits 2026-10-08 06:47:56 +00:00

workflow(wf): Create analysis for IW-707 ... d43ee02b5f

Small fixes: core

Artifacts:
- analysis.md
- issue.md

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VuB38s4FzXfyuePZHx32w7

workflow(wf): Create task index for IW-707 ... ab08e723e3

Small fixes: core

Artifacts:
- tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VuB38s4FzXfyuePZHx32w7

docs(IW-707): intake verdict — agent-ready ... 4d8d66be36

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VuB38s4FzXfyuePZHx32w7

Merge remote-tracking branch 'origin/main' into IW-707 41f88268d7

Phase 1: context ready ... afb8d2fac8

Issue: IW-707
Phase: 1 - core small fixes (test move, warning prefix, doc comment, atomic writes)

This commit marks the checkpoint for phase 1 context generation.
Use wf-implement IW-707 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

workflow(wf): Generate Phase 1 tasks for IW-707 ... 02e4ffbac3

core small fixes (test move, warning prefix, doc comment, atomic writes)

Artifacts:
- phase-01-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Phase 1: core small fixes (test move, warning prefix, doc comment, atomic writes) (#766) 479a699b02

chore(IW-707): mark phase 01 complete in tasks.md 78218bfe61

chore(IW-707): file follow-ups as #767 and on #762 ... 88bb8f4e64

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(IW-707): add review packet and release notes ... f990ffb453

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

mph requested changes 2026-10-10 18:37:29 +00:00

mph left a comment

Copy link

There are conflicts

There are conflicts

mph added 1 commit 2026-10-10 19:03:06 +00:00

docs(IW-707): rework for final PR review 23 adf523f0a4

mph added 2 commits 2026-10-10 19:07:29 +00:00

Phase 2: context ready ... f19f602dcb

Issue: IW-707
Phase: 2 - Rework for final PR review 23

This commit marks the checkpoint for phase 2 context generation.
Use wf-implement IW-707 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

workflow(wf): Generate Phase 2 tasks for IW-707 ... 14429848e8

Rework for final PR review 23

Artifacts:
- phase-02-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude added 1 commit 2026-10-10 19:43:25 +00:00

Phase 2: Rework for final PR review 23 (#776) 185bec7ca6

mph added 1 commit 2026-10-10 19:45:58 +00:00

chore(IW-707): mark phase 02 complete in tasks.md 95ae51721f

claude referenced this pull request 2026-10-10 19:46:42 +00:00

phase-merge squashes a sync phase, so the feature branch loses the main ancestry and the final PR stays unmergeable #750

mph referenced this pull request from a commit 2026-10-10 19:47:50 +00:00

Merge origin/main into IW-707

mph added 2 commits 2026-10-10 19:47:50 +00:00

Merge origin/main into IW-707 ... e2c8e85f25

Restore main as a parent of the branch. The phase 2 sync merge (4baea0bf)
was squashed by the phase PR merge, which kept main's content but dropped
main's history, so PR #768 still reported conflicts. The tree is identical
to the parent 95ae5172: both conflicts take the resolution phase 2 made.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(IW-707): log the merge that restores main ancestry ... 7687cfcc25

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

mph added 1 commit 2026-10-10 19:49:43 +00:00

docs(IW-707): regenerate review packet for the whole branch ... 9967a47bab

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude commented 2026-10-10 19:50:35 +00:00

Author

Member

Copy link

Implement: rework for review 23
The rework phase merged into IW-707 through #776; this pull request carries it.

Implement: rework for review 23 The rework phase merged into IW-707 through #776; this pull request carries it.

mph merged commit 945792b8ac into main 2026-10-10 21:36:52 +00:00

mph referenced this pull request from a commit 2026-10-10 21:36:54 +00:00

Merge pull request 'IW-707: Small fixes: core' (#768) from IW-707 into main

Sign in to join this conversation.

Reviewers

No reviewers

mph

Labels

Clear labels   

agent-ready

  

bug

Something isn't working

  

contract

Run the tool-contract suite on this PR

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

needs-human

  

needs-input

Intake asked the human a question on the issue; waiting for the answer

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

agent-ready

bug

contract

documentation

duplicate

enhancement

good first issue

help wanted

invalid

needs-human

needs-input

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

iterative-works/iw-cli!768

No description provided.