IW-426: Route iw feedback to Forgejo instead of the archived GitHub mirror #457

Merged

mph merged 34 commits from IW-426 into main 2026-08-26 14:08:10 +00:00

Conversation 0 Commits 34 Files changed 22 +2699 -83

mph commented 2026-08-26 13:47:33 +00:00

Owner

Copy link

Fixes IW-426.

Summary

iw feedback posted every submission to github.com/iterative-works/iw-cli, an archived
read-only mirror, so the command always failed with Repository was archived so is read-only.
The one channel for reporting an iw-cli problem was dead. Feedback now goes to Forgejo at
https://code.iterative.works, where the project's issues actually live.

Defects fixed

Defect 1 — feedback routed to the archived GitHub mirror. Feedback.submit now calls
env.tracker.createForgejoIssue against Constants.Feedback.Repository at the new
Constants.Feedback.BaseUrl, replacing the createFeedbackIssue/GitHubClient path. The
--type bug|feature selector is carried in the issue body (analysis Option A), together with the
working directory and branch the feedback was filed from, so a triager sees the provenance without
asking. Body rendering lives in core/model/FeedbackBody.scala; values interpolated into the
provenance footer are wrapped as markdown code spans so they cannot close the span and render as
live markdown.

Defect 2 — no guidance when the token is missing. A missing FORGEJO_API_TOKEN is now caught
before any API call and reports what is unset, where iw-cli files feedback, and what access the
token needs — instead of surfacing a raw API error after the request.

Cleanup (Phase 2). The createFeedbackIssue layer that Phase 1 orphaned is removed from
CommandEnv, LiveCommandEnv and the FakeCommandEnv recorder, and the PURPOSE headers,
test/feedback.bats header and test name no longer describe the command as targeting GitHub.

Testing

• core/test/FeedbackBodyTest.scala — body rendering, type label, provenance footer, and the
  code-span escaping of backticks and newlines.
• core/test/FeedbackHarnessTest.scala — the Forgejo call and its arguments, the missing-token
  guard and its exact message, and the reported issue number and URL.
• test/feedback.bats — E2E wiring smoke test.
• Unit suite and command compilation green; both phase PRs (#449, #453) passed CI before merge.
• Manual end-to-end submission against the live Forgejo instance was exercised while probing the
  create-issue API during Phase 1.

Lessons

Triaged before this PR. Two new tracker issues filed (IW-455 dead test-only helper, IW-456 forge
resolution duplicated across five call sites); two entries matched issues already open (IW-450,
IW-437); one lesson went to the global CLAUDE.md; one is retained as issue context. The decision
ledger is in project-management/issues/IW-426/LESSONS.md.

Release notes

project-management/issues/IW-426/release-notes.md (Czech, for non-technical readers).

🤖 Generated with Claude Code

Fixes IW-426. ## Summary `iw feedback` posted every submission to `github.com/iterative-works/iw-cli`, an archived read-only mirror, so the command always failed with `Repository was archived so is read-only`. The one channel for reporting an iw-cli problem was dead. Feedback now goes to Forgejo at `https://code.iterative.works`, where the project's issues actually live. ## Defects fixed **Defect 1 — feedback routed to the archived GitHub mirror.** `Feedback.submit` now calls `env.tracker.createForgejoIssue` against `Constants.Feedback.Repository` at the new `Constants.Feedback.BaseUrl`, replacing the `createFeedbackIssue`/`GitHubClient` path. The `--type bug|feature` selector is carried in the issue body (analysis Option A), together with the working directory and branch the feedback was filed from, so a triager sees the provenance without asking. Body rendering lives in `core/model/FeedbackBody.scala`; values interpolated into the provenance footer are wrapped as markdown code spans so they cannot close the span and render as live markdown. **Defect 2 — no guidance when the token is missing.** A missing `FORGEJO_API_TOKEN` is now caught before any API call and reports what is unset, where iw-cli files feedback, and what access the token needs — instead of surfacing a raw API error after the request. **Cleanup (Phase 2).** The `createFeedbackIssue` layer that Phase 1 orphaned is removed from `CommandEnv`, `LiveCommandEnv` and the `FakeCommandEnv` recorder, and the PURPOSE headers, `test/feedback.bats` header and test name no longer describe the command as targeting GitHub. ## Testing - `core/test/FeedbackBodyTest.scala` — body rendering, type label, provenance footer, and the code-span escaping of backticks and newlines. - `core/test/FeedbackHarnessTest.scala` — the Forgejo call and its arguments, the missing-token guard and its exact message, and the reported issue number and URL. - `test/feedback.bats` — E2E wiring smoke test. - Unit suite and command compilation green; both phase PRs (#449, #453) passed CI before merge. - Manual end-to-end submission against the live Forgejo instance was exercised while probing the create-issue API during Phase 1. ## Lessons Triaged before this PR. Two new tracker issues filed (IW-455 dead test-only helper, IW-456 forge resolution duplicated across five call sites); two entries matched issues already open (IW-450, IW-437); one lesson went to the global CLAUDE.md; one is retained as issue context. The decision ledger is in `project-management/issues/IW-426/LESSONS.md`. ## Release notes `project-management/issues/IW-426/release-notes.md` (Czech, for non-technical readers). 🤖 Generated with Claude Code

mph added 33 commits 2026-08-26 13:47:33 +00:00

workflow(dx): Create diagnostic analysis for IW-426 ... 84670680f2

feedback command posts to the archived GitHub mirror, so it always fails

Artifacts:
- analysis.md

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JXfJvKSTj49QaAAW9oAVWT

chore(IW-426): update review-state to analysis_ready ... 577a8c7419

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JXfJvKSTj49QaAAW9oAVWT

workflow: Resolve clarifications for IW-426 ... 5cc3c13d45

Resolved:
- analysis.md: Which forge should feedback target for users who have no token
  on our Forgejo instance? → team-only channel, target stays hardcoded to
  Forgejo; no external-filer path for now, revisit as a separate issue

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JXfJvKSTj49QaAAW9oAVWT

chore(IW-426): update review-state to tasks_ready 325f4f2fd5

workflow(dx): Create task index for IW-426 ... 51d3ba31e3

feedback command posts to the archived GitHub mirror, so it always fails

Artifacts:
- tasks.md
- review-state.json (tasks_ready)

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JXfJvKSTj49QaAAW9oAVWT

Phase 1: context ready ... 81eeb74339

Issue: IW-426
Phase: 1 - Route feedback to Forgejo, with a guided missing-token path

This commit marks the checkpoint for phase 1 context generation.
Use dx-fix IW-426 to return to this point.

🤖 Generated with Claude Code

chore(IW-426): update review-state to context_ready 4b4652da6e

workflow(dx): Generate Phase 1 tasks for IW-426 ... eac39aad4d

Route feedback to Forgejo, with a guided missing-token path

Artifacts:
- phase-01-tasks.md

🤖 Generated with Claude Code

chore(IW-426): update review-state to tasks_ready bc55664a90

chore(IW-426): update review-state for phase 01 f7c5e5fd2f

wip: phase 1 review fixes (iteration 2 baseline) 32186bd838

Route feedback to Forgejo, with a guided missing-token path ... 71625d87ba

- Route iw feedback to Forgejo instead of the archived GitHub mirror
- Guard a missing FORGEJO_API_TOKEN with an actionable three-line message
- Carry the issue type and filing provenance in the issue body

chore(IW-426): update review-state for phase 01 49ab3c2c71

workflow(dx): record phase-pr resume defect in LESSONS for IW-426 669bb18086

chore(IW-426): update review-state to awaiting_review 26b35c0a12

Merge pull request 'Phase 1: Route feedback to Forgejo, with a guided missing-token path' (#449) from IW-426-phase-01 into IW-426 ... 8fb2edf2f1

Reviewed-on: #449

chore(IW-426): update review-state for phase 01 122c33d51e

chore(IW-426): mark phase 01 complete in tasks.md a51d46eb6c

workflow(dx): complete step 8 and record Forgejo label API findings ... 503f09eeb9

Filed issue #450 through the merged iw feedback command; verified the
server accepted it and the body carries the type and provenance lines.
Probed the label endpoint to close the open question from the phase
context: create takes label IDs as integers, not names.

workflow(dx): widen forge-resolution lesson to the whole resolution path 60bcba8628

Phase 2: context ready ... e47d987d4e

Issue: IW-426
Phase: 2 - Clear the stale GitHub assumptions left behind

This commit marks the checkpoint for phase 2 context generation.
Use dx-fix IW-426 to return to this point.

🤖 Generated with Claude Code

chore(IW-426): update review-state to context_ready 5faceaed5f

workflow(dx): Generate Phase 2 tasks for IW-426 ... 11905c0576

Clear the stale GitHub assumptions left behind

Artifacts:
- phase-02-tasks.md

🤖 Generated with Claude Code

chore(IW-426): update review-state to tasks_ready d2efef0219

chore(IW-426): update review-state for phase 02 f7ce82d3fe

Clear the stale GitHub assumptions left behind ... ba66953c11

- Rewrite the commands/feedback.scala PURPOSE header to name Forgejo
- Name the Forgejo destination in the test/feedback.bats NOTE and rename its test off GitHub
- Remove the dead createFeedbackIssue layer from TrackerOps and both its implementations
- Drop the three FeedbackParser imports the removal orphans
- Open follow-up issue #452 for the GitHubClient.createIssue overload the removal orphans

chore(IW-426): update review-state for phase 02 bc9dc7b971

chore(IW-426): update review-state to awaiting_review dd975e5061

workflow(dx): record phase-pr false-failure lesson for IW-426 666a3150b6

Merge pull request 'Phase 2: Clear the stale GitHub assumptions left behind' (#453) from IW-426-phase-02 into IW-426 ... cee2c2d28f

Reviewed-on: #453

chore(IW-426): update review-state for phase 02 db9d51e94d

chore(IW-426): mark phase 02 complete in tasks.md 5f4c7afb39

workflow: Triage lessons for IW-426 ... 3cbabaf560

Promoted:
- a helper kept alive only by its own tests reads as live code -> IW-455
- issue creation resolves its forge four separate ways -> IW-456
- iw phase-pr cannot resume its own CI wait -> already filed as IW-450
- phase-pr marked a green phase ci_failed -> already covered by IW-437
- a baseline comparison reached for the shared stash stack -> ~/.claude-iw/CLAUDE.md (outside this repo)

Retained:
- Forgejo POST /issues takes label IDs, not names: explains this issue only

Also adds release-notes.md.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01JXfJvKSTj49QaAAW9oAVWT

mph added 1 commit 2026-08-26 13:48:39 +00:00

chore(IW-426): update review-state to all_complete 047aebf8f2

mph merged commit 25b48cece0 into main 2026-08-26 14:08:10 +00:00

mph deleted branch IW-426 2026-08-26 14:08:10 +00:00

mph referenced this pull request from a commit 2026-08-26 14:08:11 +00:00

Merge pull request 'IW-426: Route iw feedback to Forgejo instead of the archived GitHub mirror' (#457) from IW-426 into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

agent-ready

  

bug

Something isn't working

  

contract

Run the tool-contract suite on this PR

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

needs-human

  

needs-input

Intake asked the human a question on the issue; waiting for the answer

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

agent-ready

bug

contract

documentation

duplicate

enhancement

good first issue

help wanted

invalid

needs-human

needs-input

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

iterative-works/iw-cli!457

No description provided.