IW-601: The phase gate reads and writes cards that do not belong to the head under test #609

Merged

mph merged 33 commits from IW-601 into main 2026-09-22 14:01:57 +00:00

Conversation 0 Commits 33 Files changed 45 +3979 -156

claude commented 2026-09-22 13:35:46 +00:00

Member

Copy link

Summary

The phase gate gives each CI verdict about one commit. Four places in phase-pr and phase-merge broke that rule. This branch fixes all four, one phase each.

Defects fixed

• Phase 1 (#602): one flag clears one wait. ReviewStateUpdater has one clearCiWait flag in place of the hand-set pair clearCiWaitStarted / clearCiWaitSha. A card can only lose both wait fields together.
• Phase 2 (#603): a red verdict leaves the head where it was. On a red or other terminal verdict, phase-pr writes the card to disk. It commits nothing and pushes nothing, the same as the green path from IW-491. A false red can no longer produce a green head with a ci_failed card.
• Phase 3 (#604): a reading of a head that was not pushed is not judged. Before phase-merge judges a reading, it compares the pull request head with the pushed sha. A stale reading after a recovery push makes it wait and read again. It does not use up a --max-retries attempt.
• Phase 4 (#605): the state-only merge says what it did not judge. When a state-only merge takes a head that is not ci_gated_sha and has no green reading, the merged card gets a "Phase NN: CI not judged" badge and a message that names the unjudged head and the proved head. This is the settled trade from 2026-09-21.

Testing

• Each phase started with a failing test that reproduced its defect. Harness tests are in core/test, and the git adapter contract is in test/contract/git_adapter_contract.bats.
• Each phase PR passed CI on its own head. The pre-push hook (core compile with warnings as errors, scalafix, unit tests, command compilation) passed on this branch head.

Release notes

See project-management/issues/IW-601/release-notes.md (Czech).

Closes #601

🤖 Generated with Claude Code

## Summary The phase gate gives each CI verdict about one commit. Four places in `phase-pr` and `phase-merge` broke that rule. This branch fixes all four, one phase each. ## Defects fixed - **Phase 1 (#602): one flag clears one wait.** `ReviewStateUpdater` has one `clearCiWait` flag in place of the hand-set pair `clearCiWaitStarted` / `clearCiWaitSha`. A card can only lose both wait fields together. - **Phase 2 (#603): a red verdict leaves the head where it was.** On a red or other terminal verdict, `phase-pr` writes the card to disk. It commits nothing and pushes nothing, the same as the green path from IW-491. A false red can no longer produce a green head with a `ci_failed` card. - **Phase 3 (#604): a reading of a head that was not pushed is not judged.** Before `phase-merge` judges a reading, it compares the pull request head with the pushed sha. A stale reading after a recovery push makes it wait and read again. It does not use up a `--max-retries` attempt. - **Phase 4 (#605): the state-only merge says what it did not judge.** When a state-only merge takes a head that is not `ci_gated_sha` and has no green reading, the merged card gets a "Phase NN: CI not judged" badge and a message that names the unjudged head and the proved head. This is the settled trade from 2026-09-21. ## Testing - Each phase started with a failing test that reproduced its defect. Harness tests are in `core/test`, and the git adapter contract is in `test/contract/git_adapter_contract.bats`. - Each phase PR passed CI on its own head. The pre-push hook (core compile with warnings as errors, scalafix, unit tests, command compilation) passed on this branch head. ## Release notes See `project-management/issues/IW-601/release-notes.md` (Czech). Closes #601 🤖 Generated with [Claude Code](https://claude.com/claude-code)

claude added 32 commits 2026-09-22 13:35:46 +00:00

workflow(dx): Create diagnostic analysis for IW-601 ... 295c7d8af6

The phase gate reads and writes cards that do not belong to the head under test

Artifacts:
- analysis.md

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

workflow(dx): Create task index for IW-601 ... 5eda3e7148

The phase gate reads and writes cards that do not belong to the head under test

Artifacts:
- tasks.md
- review-state.json (tasks_ready)

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

Phase 1: context ready ... fcda62151d

Issue: IW-601
Phase: 1 - One wait is cleared through two hand-set flags

This commit marks the checkpoint for phase 1 context generation.
Use dx-fix IW-601 to return to this point.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

chore(IW-601): update review-state to context_ready bf8c69837c

workflow(dx): Generate Phase 1 tasks for IW-601 ... 6727d2ce30

One wait is cleared through two hand-set flags

Artifacts:
- phase-01-tasks.md

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

chore(IW-601): update review-state to tasks_ready 3c63bd2c8a

Phase 1: One wait is cleared through two hand-set flags (#602) c0de8fe1e4

chore(IW-601): update review-state for phase 01 b0ab0038bf

chore(IW-601): mark phase 01 complete in tasks.md 811d122944

Phase 2: context ready ... cfcf716cef

Issue: IW-601
Phase: 2 - A red verdict pushes the card and moves the head

This commit marks the checkpoint for phase 2 context generation.
Use dx-fix IW-601 to return to this point.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

chore(IW-601): update review-state to context_ready d62d6af1b0

workflow(dx): Generate Phase 2 tasks for IW-601 ... a048b3f072

A red verdict pushes the card and moves the head

Artifacts:
- phase-02-tasks.md

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

chore(IW-601): update review-state to tasks_ready 6a6a7f1ea3

Phase 2: A red verdict pushes the card and moves the head (#603) 26f8b3abe9

chore(IW-601): update review-state for phase 02 28c7700803

chore(IW-601): mark phase 02 complete in tasks.md 8af4ae0e8a

Phase 3: context ready ... adb639e2f9

Issue: IW-601
Phase: 3 - A stale reading after a recovery push uses up a retry

This commit marks the checkpoint for phase 3 context generation.
Use dx-fix IW-601 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

chore(IW-601): update review-state to context_ready d1600a32db

workflow(dx): Generate Phase 3 tasks for IW-601 ... f6a6ceeb2c

A stale reading after a recovery push uses up a retry

Artifacts:
- phase-03-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

chore(IW-601): update review-state to tasks_ready c34dbd39bd

Phase 3: A stale reading after a recovery push uses up a retry (#604) d13387e90f

chore(IW-601): update review-state for phase 03 39dd39ca78

chore(IW-601): mark phase 03 complete in tasks.md 115f649e56

Phase 4: context ready ... eca1d5c43d

Issue: IW-601
Phase: 4 - The state-only merge does not say what it did not judge

This commit marks the checkpoint for phase 4 context generation.
Use dx-fix IW-601 to return to this point.

The "CI not judged" badge names its phase, so it stays true after later
phases (no command removes a badge). analysis.md carries the same form.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

chore(IW-601): update review-state to context_ready 6ebaee3def

workflow(dx): Generate Phase 4 tasks for IW-601 ... 6ac1951f74

The state-only merge does not say what it did not judge

Artifacts:
- phase-04-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

chore(IW-601): update review-state to tasks_ready 9e2391486b

Phase 4: The state-only merge does not say what it did not judge (#605) 4cd34a5c24

chore(IW-601): update review-state for phase 04 0b164f19cf

chore(IW-601): mark phase 04 complete in tasks.md c2b7e23c0e

workflow: Triage lessons for IW-601 ... 9da04e836e

Follow-ups filed: 2 (#607, #608), commented: 2 (#568, #440), struck: 0
Lessons: 1 approved, 0 rejected, 0 still pending

Promoted:
- A reviewer subagent can revert the uncommitted change it reviews → kanon note dev-docs#321

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

docs(IW-601): add release notes ... c63dd4aea2

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

mph added 1 commit 2026-09-22 13:36:48 +00:00

chore(IW-601): update review-state to all_complete 594977a2d4

mph merged commit 37c08716ad into main 2026-09-22 14:01:57 +00:00

mph referenced this pull request from a commit 2026-09-22 14:01:57 +00:00

Merge pull request 'IW-601: The phase gate reads and writes cards that do not belong to the head under test' (#609) from IW-601 into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

agent-ready

  

bug

Something isn't working

  

contract

Run the tool-contract suite on this PR

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

needs-human

  

needs-input

Intake asked the human a question on the issue; waiting for the answer

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

agent-ready

bug

contract

documentation

duplicate

enhancement

good first issue

help wanted

invalid

needs-human

needs-input

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

iterative-works/iw-cli!609

No description provided.