IW-679: Shared subcommand runner for six commands #746

Merged

mph merged 20 commits from IW-679 into main 2026-10-08 06:23:05 +00:00

Conversation 2 Commits 20 Files changed 30 +2432 -417

claude commented 2026-10-07 05:36:52 +00:00

Member

Copy link

Summary

The six commands with subcommands — service, server, config, gate, review-state and issue — now run through one shared runner, core/commands/Subcommand.scala, in place of six hand-written copies of the same dispatch code. Behaviour does not change: help text, error messages and output stay the same.

Changes

• Subcommand[A] binds a subcommand declaration to its action with the same type A. Subcommand.dispatch parses, prints help, rejects bad input and runs the action for all six commands. Subcommand.runParsed holds the parse/help/reject/act sequence for one declaration.
• DispatchOutcome in core/model takes a type parameter, so ToSubcommand returns the binding itself. The eq arms and the unreachable internal: unexpected subcommand fallbacks are gone.
• Each command declares one subcommands list and builds its parent declaration from it, so the help cannot list a subcommand that has no action.
• review-state write and update keep reading raw argv after parse (a recorded earlier decision); they use the readingArgv form of the binding.
• The current behaviour of every affected command was pinned by harness tests before the move.

Phase PR: #743. Review packet: project-management/issues/IW-679/review-packet.md.

Known differences kept on purpose

• iw review-state --bogus still reports Missing subcommand, while the other dispatchers report Unknown flag. Filed in #744.

Follow-ups filed

• #744 — one parent-level handler for every command, and a check that the parent declares the dispatched subcommands.
• #745 — 15 commands without subcommands repeat the sequence that Subcommand.runParsed holds.

Testing

• Unit / harness tests in core/test (SubcommandTest plus harness tests per command); CI ran the full suite on the phase PR #743.

Release notes (CZ)

Tato změna je čistě vnitřní úprava nástroje iw-cli a pro uživatele nepřináší žádnou novou funkci ani viditelnou změnu chování. Příkazy service, server, config, gate, review-state a issue se ovládají přesně stejně jako dosud; nyní ale sdílejí jedno společné místo pro zpracování podpříkazů. Viz project-management/issues/IW-679/release-notes.md.

🤖 Generated with Claude Code

Closes #679

## Summary The six commands with subcommands — `service`, `server`, `config`, `gate`, `review-state` and `issue` — now run through one shared runner, `core/commands/Subcommand.scala`, in place of six hand-written copies of the same dispatch code. Behaviour does not change: help text, error messages and output stay the same. ## Changes - `Subcommand[A]` binds a subcommand declaration to its action with the same type `A`. `Subcommand.dispatch` parses, prints help, rejects bad input and runs the action for all six commands. `Subcommand.runParsed` holds the parse/help/reject/act sequence for one declaration. - `DispatchOutcome` in `core/model` takes a type parameter, so `ToSubcommand` returns the binding itself. The `eq` arms and the unreachable `internal: unexpected subcommand` fallbacks are gone. - Each command declares one `subcommands` list and builds its parent declaration from it, so the help cannot list a subcommand that has no action. - `review-state write` and `update` keep reading raw argv after parse (a recorded earlier decision); they use the `readingArgv` form of the binding. - The current behaviour of every affected command was pinned by harness tests before the move. Phase PR: #743. Review packet: `project-management/issues/IW-679/review-packet.md`. ## Known differences kept on purpose - `iw review-state --bogus` still reports `Missing subcommand`, while the other dispatchers report `Unknown flag`. Filed in #744. ## Follow-ups filed - #744 — one parent-level handler for every command, and a check that the parent declares the dispatched subcommands. - #745 — 15 commands without subcommands repeat the sequence that `Subcommand.runParsed` holds. ## Testing - Unit / harness tests in `core/test` (`SubcommandTest` plus harness tests per command); CI ran the full suite on the phase PR #743. ## Release notes (CZ) Tato změna je čistě vnitřní úprava nástroje iw-cli a pro uživatele nepřináší žádnou novou funkci ani viditelnou změnu chování. Příkazy `service`, `server`, `config`, `gate`, `review-state` a `issue` se ovládají přesně stejně jako dosud; nyní ale sdílejí jedno společné místo pro zpracování podpříkazů. Viz `project-management/issues/IW-679/release-notes.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Closes #679

claude added 12 commits 2026-10-07 05:36:52 +00:00

workflow(wf): Create analysis for IW-679 ... e678dfea3e

Subcommand dispatch boilerplate is repeated across seven commands

Artifacts:
- analysis.md
- issue.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8ZD5foFWAE2zV1xYojPMa

chore(IW-679): update review-state to tasks_ready 47524045a5

workflow(wf): Create task index for IW-679 ... f7c9c492cd

Subcommand dispatch boilerplate is repeated across seven commands

Artifacts:
- tasks.md
- review-state.json (tasks_ready)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8ZD5foFWAE2zV1xYojPMa

docs(IW-679): intake verdict — agent-ready ... 7e6ef437ea

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8ZD5foFWAE2zV1xYojPMa

Merge remote-tracking branch 'origin/main' into IW-679 32b411dbf1

chore(IW-679): move review-state card out of the tree 12853960e3

Phase 1: context ready ... f3917564d9

Issue: IW-679
Phase: 1 - Shared subcommand runner + migrate six commands

This commit marks the checkpoint for phase 1 context generation.
Use wf-implement IW-679 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

workflow(wf): Generate Phase 1 tasks for IW-679 ... 0283728632

Shared subcommand runner + migrate six commands

Artifacts:
- phase-01-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Phase 1: Shared subcommand runner + migrate six commands (#743) f26298e60d

chore(IW-679): mark phase 01 complete in tasks.md b370f6cb91

chore(IW-679): file follow-ups as #744 and #745 ... f36f4da1c4

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(IW-679): review packet and release notes ... 430c0695aa

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

mph requested changes 2026-10-07 07:33:27 +00:00

mph left a comment

Copy link

There are conflicts after merging other branches.

There are conflicts after merging other branches.

claude referenced this pull request 2026-10-07 22:15:04 +00:00

15 commands without subcommands repeat the parse, help, reject and act sequence that Subcommand.runParsed holds #745

claude referenced this pull request 2026-10-07 22:33:57 +00:00

Subcommand dispatch: one parent-level handler for every command, and a check that the parent declares the dispatched subcommands #744

mph added 1 commit 2026-10-08 00:12:27 +00:00

docs(IW-679): rework for final PR review 17 ccbffb2773

mph added 2 commits 2026-10-08 00:15:26 +00:00

Phase 2: context ready ... 8581677a83

Issue: IW-679
Phase: 2 - Rework for final PR review 17

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

workflow(wf): Generate Phase 2 tasks for IW-679 ... 981c2cb65e

Rework for final PR review 17

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude added 1 commit 2026-10-08 00:43:00 +00:00

Phase 2: Rework for final PR review 17 (#751) 7d862467d4

mph added 4 commits 2026-10-08 00:46:37 +00:00

chore(IW-679): mark phase 02 complete in tasks.md 8263d35cca

docs(IW-679): date release notes dcbad41042

Merge origin/main into IW-679 to restore ancestry ... e7cf2c88b1

Phase 2 PR #751 was squash-merged, which dropped the parent link of
merge 4421a10b to origin/main d9e76182. The tree already held that
merge's resolution, so this merge keeps the branch side of
core/commands/Issue.scala and leaves the tree unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(IW-679): record ancestry repair in log and review packet 1b5e5f48c7

claude commented 2026-10-08 00:47:20 +00:00

Author

Member

Copy link

Implement: rework for review 17
The rework phase merged into IW-679 through #751; this pull request carries it.

Implement: rework for review 17 The rework phase merged into IW-679 through #751; this pull request carries it.

mph merged commit 7add7a709f into main 2026-10-08 06:23:05 +00:00

mph referenced this pull request from a commit 2026-10-08 06:23:06 +00:00

Merge pull request 'IW-679: Shared subcommand runner for six commands' (#746) from IW-679 into main

Sign in to join this conversation.

Reviewers

No reviewers

mph

Labels

Clear labels   

agent-ready

  

bug

Something isn't working

  

contract

Run the tool-contract suite on this PR

  

documentation

Improvements or additions to documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature or request

  

good first issue

Good for newcomers

  

help wanted

Extra attention is needed

  

invalid

This doesn't seem right

  

needs-human

  

needs-input

Intake asked the human a question on the issue; waiting for the answer

  

question

Further information is requested

  

wontfix

This will not be worked on

No labels

agent-ready

bug

contract

documentation

duplicate

enhancement

good first issue

help wanted

invalid

needs-human

needs-input

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

iterative-works/iw-cli!746

No description provided.