iterative-works/iw-cli
Watch
3
0
Fork
You've already forked iw-cli
 0
Code Issues 119 Pull requests 1 Projects Releases 34 Packages Wiki Activity Actions

IW-620: Shutdown-safe GitAdapter read, stage and commit #624

Merged
claude merged 14 commits from IW-620 into main 2026-09-26 11:12:23 +00:00
Conversation 0 Commits 14 Files changed 15 +1210 -39
claude commented 2026-09-25 22:53:14 +00:00
Member
Copy link

Summary

GitAdapter.dirtyState, stageAll, commit and getFullHeadSha now take destroyOnExit: Boolean = true as their last parameter and pass it to ProcessAdapter.run (added by #616). A caller can now read the dirty state, stage, commit and read the new SHA from inside a JVM shutdown hook. kanon's LiveWorkingTree can delegate to core and stop repeating these methods.

Changes

  • core/adapters/Git.scala: the flag goes through the full call chain of each public method, including commit → getFullHeadSha and the private porcelainStatus. The default keeps all current callers unchanged.
  • core/test/GitTest.scala, core/test/ShutdownSpawnProbe.scala, core/test/ProcessTest.scala: forked-JVM tests run dirtyState, stageAll and commit inside a shutdown hook. The probe harness is shared with the ProcessAdapter shutdown test.
  • docs/api/Git.md: documents the new parameter.

Testing

  • Unit tests in core.test pass, including two forked-JVM shutdown tests (see review-packet.md).
  • Phase PR #621 passed CI.

Follow-ups filed

Release notes

Bezpečnější čtení stavu gitu, příprava a commit při ukončování procesu. Zjištění rozpracovaných změn, jejich příprava ke commitu a vytvoření commitu mohou proběhnout i v kroku spuštěném těsně před ukončením procesu, se stejným chováním a chybovými hláškami jako za běžného provozu. Bez výslovného vyžádání se nic nemění. Podrobnosti: project-management/issues/IW-620/release-notes.md.

🤖 Generated with Claude Code

Closes #620

## Summary `GitAdapter.dirtyState`, `stageAll`, `commit` and `getFullHeadSha` now take `destroyOnExit: Boolean = true` as their last parameter and pass it to `ProcessAdapter.run` (added by #616). A caller can now read the dirty state, stage, commit and read the new SHA from inside a JVM shutdown hook. kanon's `LiveWorkingTree` can delegate to core and stop repeating these methods. ## Changes - `core/adapters/Git.scala`: the flag goes through the full call chain of each public method, including `commit` → `getFullHeadSha` and the private `porcelainStatus`. The default keeps all current callers unchanged. - `core/test/GitTest.scala`, `core/test/ShutdownSpawnProbe.scala`, `core/test/ProcessTest.scala`: forked-JVM tests run `dirtyState`, `stageAll` and `commit` inside a shutdown hook. The probe harness is shared with the `ProcessAdapter` shutdown test. - `docs/api/Git.md`: documents the new parameter. ## Testing - Unit tests in `core.test` pass, including two forked-JVM shutdown tests (see `review-packet.md`). - Phase PR #621 passed CI. ## Follow-ups filed - #622, #623 ## Release notes Bezpečnější čtení stavu gitu, příprava a commit při ukončování procesu. Zjištění rozpracovaných změn, jejich příprava ke commitu a vytvoření commitu mohou proběhnout i v kroku spuštěném těsně před ukončením procesu, se stejným chováním a chybovými hláškami jako za běžného provozu. Bez výslovného vyžádání se nic nemění. Podrobnosti: `project-management/issues/IW-620/release-notes.md`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Closes #620
GitAdapter dirtyState, stageAll and commit cannot take destroyOnExit, so a shutdown-safe caller must repeat them

Artifacts:
- analysis.md
- issue.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GitAdapter dirtyState, stageAll and commit cannot take destroyOnExit, so a shutdown-safe caller must repeat them

Artifacts:
- tasks.md
- review-state.json (tasks_ready)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Issue: IW-620
Phase: 1 - Shutdown-safe GitAdapter read, stage and commit

This commit marks the checkpoint for phase 1 context generation.
Use wf-implement IW-620 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Shutdown-safe GitAdapter read, stage and commit

Artifacts:
- phase-01-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
docs(IW-620): add review packet for the feature branch
Some checks failed
CI / changes (pull_request) Successful in 4s
Details
CI / contract (pull_request) Has been skipped
Details
CI / format (pull_request) Successful in 10s
Details
CI / lint (pull_request) Successful in 12s
Details
CI / test (pull_request) Has been cancelled
Details
CI / dashboard-build (pull_request) Has been cancelled
Details
CI / compile (pull_request) Has been cancelled
Details
a7516946cd 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chore(IW-620): update review-state to all_complete
All checks were successful
CI / dashboard-build (pull_request) Successful in 1m14s
Details
CI / test (pull_request) Successful in 15m41s
Details
CI / contract (pull_request) Has been skipped
Details
CI / changes (pull_request) Successful in 4s
Details
CI / format (pull_request) Successful in 10s
Details
CI / lint (pull_request) Successful in 11s
Details
CI / compile (pull_request) Successful in 1m33s
Details
720a130e64
claude merged commit 82f267d712 into main 2026-09-26 11:12:23 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agent-ready

   
bug
Something isn't working

  
contract
Run the tool-contract suite on this PR

  
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
needs-human

   
needs-input
Intake asked the human a question on the issue; waiting for the answer

  
question
Further information is requested

  
wontfix
This will not be worked on

No labels
agent-ready
bug
contract
documentation
duplicate
enhancement
good first issue
help wanted
invalid
needs-human
needs-input
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
iterative-works/iw-cli!624
No description provided.