IW-671: Split the Forgejo issue timeline read out of ForgejoClient

claude commented

2026-10-07 00:40:27 +00:00

Member

Summary

The issue timeline read moves out of core/adapters/ForgejoClient.scala into its own object, ForgejoIssueTimeline. The behavior does not change: the HTTP requests, the results and the error texts are the same. ForgejoIssueTimeline gets its one effect (the authenticated page GET) as a function parameter, so it names no sttp, token or backend.

Changes

core/adapters/ForgejoIssueTimeline.scala (new): URL builder, page parser, event mapping, page limit, stop rule and the paged read.
core/adapters/ForgejoClient.scala: the moved code is removed (about 1212 lines remain); TextResponse is top level and private[adapters]; fetchIssueState calls ForgejoIssueTimeline.read. No forwarders.
core/test/ForgejoIssueTimelineTest.scala (new): the moved pure tests, plus four direct timelineComplete tests (each checked by a mutation).
test/contract/forgejo_api_contract.bats: the PURPOSE comment names both objects.
CI fix, separate: dashboard/jvm/itest/src/ItestServer.scala retries on another port when any cause of a startup failure is a BindException (Undertow wraps it). Three tests in ItestServerItest.

Testing

ForgejoClientTest 126 + ForgejoIssueTimelineTest 14 = 140 pass (baseline 136).
ItestServerItest and ClaudeSessionLinksItest pass.
core.compile has no warnings; lint passes; the pre-push hook (./iw ./test unit) passed on this branch.
Review packet: project-management/issues/IW-671/review-packet.md.

For the reviewer

The public names ForgejoClient.parseTimelinePage, TimelinePage, TimelinePageLimit, timelineComplete and buildIssueTimelineUrl are gone. In this repository only the tests used them.
IW-672 also edits ForgejoClient.scala next to the deleted buildIssueTimelineUrl. At that conflict, keep both deletions.
Follow-ups: #730 (extract the CI and pull-request clusters), and two push cases added to #585.

Release notes

Tato změna je čistě vnitřní úprava nástroje iw-cli. Pro uživatele se nic nemění: všechny příkazy, jejich výstupy i chybová hlášení zůstávají stejné jako dosud.

Úprava zjednodušuje tu část nástroje, která komunikuje s Forgejo a zjišťuje stav úkolů. Díky tomu půjde tuto oblast v budoucnu snáze udržovat a opravovat. Současně jsme odstranili občasné selhání interních automatických testů dashboardu, které se uživatele nedotýkalo.

Po aktualizaci není nutné nic nastavovat ani měnit.

🤖 Generated with Claude Code

Closes #671

## Summary The issue timeline read moves out of `core/adapters/ForgejoClient.scala` into its own object, `ForgejoIssueTimeline`. The behavior does not change: the HTTP requests, the results and the error texts are the same. `ForgejoIssueTimeline` gets its one effect (the authenticated page GET) as a function parameter, so it names no sttp, token or backend. ## Changes - `core/adapters/ForgejoIssueTimeline.scala` (new): URL builder, page parser, event mapping, page limit, stop rule and the paged `read`. - `core/adapters/ForgejoClient.scala`: the moved code is removed (about 1212 lines remain); `TextResponse` is top level and `private[adapters]`; `fetchIssueState` calls `ForgejoIssueTimeline.read`. No forwarders. - `core/test/ForgejoIssueTimelineTest.scala` (new): the moved pure tests, plus four direct `timelineComplete` tests (each checked by a mutation). - `test/contract/forgejo_api_contract.bats`: the PURPOSE comment names both objects. - CI fix, separate: `dashboard/jvm/itest/src/ItestServer.scala` retries on another port when any cause of a startup failure is a `BindException` (Undertow wraps it). Three tests in `ItestServerItest`. ## Testing - `ForgejoClientTest` 126 + `ForgejoIssueTimelineTest` 14 = 140 pass (baseline 136). - `ItestServerItest` and `ClaudeSessionLinksItest` pass. - `core.compile` has no warnings; lint passes; the pre-push hook (`./iw ./test unit`) passed on this branch. - Review packet: `project-management/issues/IW-671/review-packet.md`. ## For the reviewer - The public names `ForgejoClient.parseTimelinePage`, `TimelinePage`, `TimelinePageLimit`, `timelineComplete` and `buildIssueTimelineUrl` are gone. In this repository only the tests used them. - IW-672 also edits `ForgejoClient.scala` next to the deleted `buildIssueTimelineUrl`. At that conflict, keep both deletions. - Follow-ups: #730 (extract the CI and pull-request clusters), and two push cases added to #585. ## Release notes Tato změna je čistě vnitřní úprava nástroje iw-cli. Pro uživatele se nic nemění: všechny příkazy, jejich výstupy i chybová hlášení zůstávají stejné jako dosud. Úprava zjednodušuje tu část nástroje, která komunikuje s Forgejo a zjišťuje stav úkolů. Díky tomu půjde tuto oblast v budoucnu snáze udržovat a opravovat. Současně jsme odstranili občasné selhání interních automatických testů dashboardu, které se uživatele nedotýkalo. Po aktualizaci není nutné nic nastavovat ani měnit. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Closes #671

claude added 13 commits

2026-10-07 00:40:27 +00:00

workflow(wf): Create analysis for IW-671 050f316dea

Split the Forgejo issue timeline read out of ForgejoClient

Artifacts:
- analysis.md
- issue.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8ZD5foFWAE2zV1xYojPMa

chore(IW-671): update review-state to tasks_ready 2246e0c408

workflow(wf): Create task index for IW-671 2c78bf9936

Split the Forgejo issue timeline read out of ForgejoClient

Artifacts:
- tasks.md
- review-state.json (tasks_ready)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8ZD5foFWAE2zV1xYojPMa

docs(IW-671): intake verdict — agent-ready 225ea6e8fe

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01B8ZD5foFWAE2zV1xYojPMa

Phase 1: context ready 286082e199

Issue: IW-671
Phase: 1 - Extract ForgejoIssueTimeline + move its tests

This commit marks the checkpoint for phase 1 context generation.
Use wf-implement IW-671 to return to this point.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-671): update review-state to context_ready d40ea0248a

workflow(wf): Generate Phase 1 tasks for IW-671 24c4445706

Extract ForgejoIssueTimeline + move its tests

Artifacts:
- phase-01-tasks.md

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

chore(IW-671): update review-state to tasks_ready f84a969722

Merge remote-tracking branch 'origin/main' into IW-671 3444e18a99

Phase 1: Extract ForgejoIssueTimeline + move its tests (#729 ) a92da1aed6

chore(IW-671): mark phase 01 complete in tasks.md 3a4bdd10bb

chore(IW-671): file follow-ups (#730 , #585 ) 99bb405683

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

docs(IW-671): review packet and release notes

CI / changes (pull_request) Successful in 5s

Details

CI / contract (pull_request) Has been skipped

Details

CI / format (pull_request) Successful in 11s

Details

CI / lint (pull_request) Successful in 12s

Details

CI / compile (pull_request) Successful in 1m41s

Details

CI / dashboard-build (pull_request) Successful in 1m29s

Details

CI / test (pull_request) Successful in 18m15s

Details

5587ae796b

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude referenced this pull request

2026-10-07 01:01:59 +00:00

Extract the CI and pull-request clusters out of ForgejoClient #730

mph added 1 commit

2026-10-07 22:04:54 +00:00

docs(IW-671): rework for final PR review 19

CI / changes (pull_request) Successful in 5s

Details

CI / contract (pull_request) Has been skipped

Details

CI / format (pull_request) Successful in 10s

Details

CI / lint (pull_request) Successful in 12s

Details

CI / compile (pull_request) Successful in 1m43s

Details

CI / dashboard-build (pull_request) Has been cancelled

Details

CI / test (pull_request) Has been cancelled

Details

1831128a45

mph added 2 commits

2026-10-07 22:08:10 +00:00

Phase 2: context ready d3e8f116cb

Issue: IW-671
Phase: 2 - Rework for final PR review 19

This commit marks the checkpoint for phase 2 context generation.
Use wf-implement IW-671 to return to this point.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

workflow(wf): Generate Phase 2 tasks for IW-671

CI / changes (pull_request) Successful in 4s

Details

CI / contract (pull_request) Has been skipped

Details

CI / format (pull_request) Successful in 10s

Details

CI / lint (pull_request) Successful in 13s

Details

CI / compile (pull_request) Successful in 1m37s

Details

CI / dashboard-build (pull_request) Successful in 1m25s

Details

CI / test (pull_request) Successful in 18m8s

Details

daf0cebd36

Rework for final PR review 19

Artifacts:
- phase-02-tasks.md

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude added 1 commit

2026-10-07 22:57:12 +00:00

Phase 2: Rework for final PR review 19 (#747 )

CI / changes (pull_request) Successful in 5s

Details

CI / contract (pull_request) Has been skipped

Details

CI / format (pull_request) Successful in 10s

Details

CI / lint (pull_request) Successful in 13s

Details

CI / compile (pull_request) Successful in 1m39s

Details

CI / test (pull_request) Has been cancelled

Details

CI / dashboard-build (pull_request) Has been cancelled

Details

5aa8033843

mph referenced this pull request from a commit

2026-10-07 22:59:00 +00:00

workflow(IW-671): add Phase 3 sync with main d9e76182fb86

mph added 2 commits

2026-10-07 22:59:00 +00:00

chore(IW-671): mark phase 02 complete in tasks.md f719b9cdd6

workflow(IW-671): add Phase 3 sync with main d9e76182fb

CI / changes (pull_request) Successful in 4s

Details

CI / contract (pull_request) Has been skipped

Details

CI / format (pull_request) Successful in 11s

Details

CI / lint (pull_request) Successful in 14s

Details

CI / compile (pull_request) Successful in 1m33s

Details

CI / dashboard-build (pull_request) Successful in 1m28s

Details

CI / test (pull_request) Has been cancelled

Details

bd5d6f8e91

Final PR #731 cannot merge: core/adapters/ForgejoClient.scala conflicts with IW-610 (#694).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

mph added 1 commit

2026-10-07 23:02:32 +00:00

Phase 3: context ready

CI / changes (pull_request) Successful in 5s

Details

CI / contract (pull_request) Has been skipped

Details

CI / format (pull_request) Successful in 11s

Details

CI / lint (pull_request) Successful in 13s

Details

CI / compile (pull_request) Successful in 1m37s

Details

CI / dashboard-build (pull_request) Successful in 1m28s

Details

CI / test (pull_request) Successful in 18m20s

Details

691224b0c2

Issue: IW-671
Phase: 3 - Sync with main d9e76182fb

Adds a CLARIFY in analysis.md: the squash merge of the Phase 2 PR dropped main as a
parent, so the way the merge lands on IW-671 needs a decision.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude commented

2026-10-07 23:03:10 +00:00

Author

Member

Implement: rework for review 19
The rework phase merged into IW-671 through #747; this pull request carries it.

Implement: rework for review 19 The rework phase merged into IW-671 through #747; this pull request carries it.

mph added 1 commit

2026-10-08 06:38:32 +00:00

workflow: Resolve clarifications for IW-671

CI / changes (pull_request) Successful in 4s

Details

CI / contract (pull_request) Has been skipped

Details

CI / compile (pull_request) Successful in 1m42s

Details

CI / format (pull_request) Successful in 11s

Details

CI / lint (pull_request) Successful in 15s

Details

CI / dashboard-build (pull_request) Successful in 1m24s

Details

CI / test (pull_request) Successful in 18m28s

Details

6e8915b307

Resolved:
- analysis.md: How does the merge from main land on IW-671? → b) Phase 3 PR, merged by hand with a merge commit; sync to current origin/main, which now conflicts in five files

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Gb1uDXz47sTSnzukutVe2t

claude referenced this pull request

2026-10-08 07:12:24 +00:00

Split the Forgejo issue timeline read out of ForgejoClient #671

mph added 1 commit

2026-10-15 12:55:33 +00:00

workflow: Triage lessons for IW-671

CI / changes (pull_request) Successful in 4s

Details

CI / contract (pull_request) Has been skipped

Details

CI / format (pull_request) Successful in 10s

Details

CI / lint (pull_request) Successful in 13s

Details

CI / compile (pull_request) Successful in 1m3s

Details

CI / dashboard-build (pull_request) Successful in 1m28s

Details

CI / test (pull_request) Successful in 18m31s

Details

b01a793509

Follow-ups filed: 0, commented: 0, struck: 0
Lessons: 1 approved, 0 rejected, 0 still pending

Promoted:
- 2026-10-08 — a squashed phase PR drops the merge from main → source fix #750

Decided on the issue: #671 (comment)

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

claude referenced this pull request

2026-10-15 12:56:18 +00:00

Split the Forgejo issue timeline read out of ForgejoClient #671

claude commented

2026-10-16 18:07:59 +00:00

Author

Member

Closed without a merge, at Michal's decision. The branch is 318 commits behind main, and a merge of main conflicts in 14 files, among them ForgejoClient.scala, which the TrackerError change (#778) rewrote. To resolve that costs more than to do the split again on current main. A new issue takes the work again; the branch stays on the forge.

claude closed this pull request

2026-10-16 18:07:59 +00:00

claude referenced this pull request

2026-10-16 18:07:59 +00:00

Split the Forgejo issue timeline read out of ForgejoClient #802

claude referenced this pull request

2026-10-16 18:07:59 +00:00

Split the Forgejo issue timeline read out of ForgejoClient #671